[issue29714] can't interpolate byte string with \x00 before replacement identifier

Changes by Donald Stufft : -- pull_requests: +998 ___ Python tracker ___ ___

[issue29714] can't interpolate byte string with \x00 before replacement identifier

Xiang Zhang added the comment: New changeset df6d7b406f3d1b2e4e2014751bfa25574c4df222 by Xiang Zhang in branch '3.6': [3.6] bpo-29714: Fix a regression that bytes format may fail when containing zero bytes inside. (GH-504)

[issue29714] can't interpolate byte string with \x00 before replacement identifier

Xiang Zhang added the comment: New changeset b76ad5121e2cfa89d6476d700cbcb65b7ffc39ac by Xiang Zhang in branch 'master': bpo-29714: Fix a regression that bytes format may fail when containing zero bytes inside. (GH-499)

[issue29714] can't interpolate byte string with \x00 before replacement identifier

Changes by Larry Hastings : -- pull_requests: +616 ___ Python tracker ___ ___

[issue29714] can't interpolate byte string with \x00 before replacement identifier

STINNER Victor added the comment: Xiang Zhang added the comment: > I think no. String is not affected now and its code uses related macros so I > don't think it could suffer possible regression. Regressions are not something "expected", shit happens, all the time. Unexpected corner cases are

[issue29714] can't interpolate byte string with \x00 before replacement identifier

Xiang Zhang added the comment: I think no. String is not affected now and its code uses related macros so I don't think it could suffer possible regression. -- ___ Python tracker

[issue29714] can't interpolate byte string with \x00 before replacement identifier

STINNER Victor added the comment: Oh, and thank you for adding new unit tests ;-) Do we need similar unit tests for str%args and str.format()? -- ___ Python tracker

[issue29714] can't interpolate byte string with \x00 before replacement identifier

STINNER Victor added the comment: I confirm that I introduced the regression with the commit fa7762ec066aa3632a25b6a52bb7597b8f17c2f3: "Issue #25349: Optimize bytes % args using the new private _PyBytesWriter API". Sorry about that, I always forget that str*() functions should not be used in

[issue29714] can't interpolate byte string with \x00 before replacement identifier

Xiang Zhang added the comment: Thanks for the report, Nick! -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker

[issue29714] can't interpolate byte string with \x00 before replacement identifier

Changes by Xiang Zhang : -- pull_requests: +412 ___ Python tracker ___ ___ Python-bugs-list

[issue29714] can't interpolate byte string with \x00 before replacement identifier

Changes by Xiang Zhang : -- pull_requests: +407 ___ Python tracker ___ ___ Python-bugs-list

[issue29714] can't interpolate byte string with \x00 before replacement identifier

Xiang Zhang added the comment: The problem is now _PyBytes_FormatEx uses strchr to sniff %. It should use memchr instead. -- assignee: -> xiang.zhang nosy: +xiang.zhang ___ Python tracker

[issue29714] can't interpolate byte string with \x00 before replacement identifier

Serhiy Storchaka added the comment: Could this be due to using _PyBytesWriter? -- keywords: +3.6regression nosy: +haypo, serhiy.storchaka stage: -> needs patch type: -> behavior versions: +Python 3.7 ___ Python tracker

[issue29714] can't interpolate byte string with \x00 before replacement identifier

New submission from Nick Huber: Python 3.6.0 (default, Mar 3 2017, 00:15:36) [GCC 4.9.2] on linux Type "help", "copyright", "credits" or "license" for more information. >>> b'a\x00%i' % 1 Traceback (most recent call last): File "", line 1, in TypeError: not all arguments converted during