[issue29718] Fixed compile on cygwin.

Decorater added the comment: Closing this in favor of https://www.python.org/dev/peps/pep-0539/. -- stage: -> resolved status: open -> closed ___ Python tracker

[issue29718] Fixed compile on cygwin.

Erik Bray added the comment: This seems to be fixing a number of different Cygwin issues, many of which are known (some of these patches come from the Cygwin port of Python). However, some of these issues are already being handled separately, such as #25658, and I think rather than one big

[issue29718] Fixed compile on cygwin.

STINNER Victor added the comment: Please remove TSS from the Cygwin patch in that case. -- ___ Python tracker ___

[issue29718] Fixed compile on cygwin.

Masayuki Yamamoto added the comment: We should avoid to submit quickfix to official as much as we can. Especially the case of unofficial (or inarticulate) support platform, a patch for specific platform is probably rejected because the code won't be maintained. Thread Specific Storage API

[issue29718] Fixed compile on cygwin.

Decorater added the comment: And yeah that is why I stuck most of the changes in here under __CYGWIN__ macros for now until I know otherwise that all of the changes will not break other platforms. -- ___ Python tracker

[issue29718] Fixed compile on cygwin.

Decorater added the comment: hmm maybe if TSS is available on all platforms maybe python could use that instead of TLS so that way I would not have to have a lot of __CYGWIN__'s all over the place. However I am not sure if all of the OS's that are on the buildbot for python supports TSS. hmm

[issue29718] Fixed compile on cygwin.

Masayuki Yamamoto added the comment: The patch can split to several issues, moreover, some issues are able to pick up as general not Cygwin specific. Perhaps, it will be an opportunity to fix even if Cygwin specific, if we could explain the implicit issue on implementation. See #4032, #25658,

[issue29718] Fixed compile on cygwin.

Decorater added the comment: Also I just realized my Cygwin updated to 2.7.0 as well. -- ___ Python tracker ___

[issue29718] Fixed compile on cygwin.

Decorater added the comment: Well then I am thinking about figuring out how to make an batch file under tools/buildbot to target cygwin building in windows. tbh windows 7 or newer on cygwin is fine with me. It is just that I need to figure out how to make it invoke Cygwin.bat and yet also

[issue29718] Fixed compile on cygwin.

Decorater added the comment: I use cygwin to test things that I write in python to see if they work under linux without having to boot up into an linux VM to find out as it would be too slow to even do that with the computer I have. And besides cygwin makes all of this faster. The version of

[issue29718] Fixed compile on cygwin.

STINNER Victor added the comment: Please explain why you want to support Cygwin. Which Cygwin and Windows versions are you targetingW -- ___ Python tracker

[issue29718] Fixed compile on cygwin.

Decorater added the comment: For now I stuck it under cygwin only but it could easily move out to not only cygwin if desired. -- ___ Python tracker ___

[issue29718] Fixed compile on cygwin.

Decorater added the comment: Yes, it is because of the fact in Cygwin it will cause an compile Error when ints are involved forcing other methods to be put in place. -- ___ Python tracker

[issue29718] Fixed compile on cygwin.

Changes by Decorater : Added file: http://bugs.python.org/file46698/cygwin_build.patch ___ Python tracker ___

[issue29718] Fixed compile on cygwin.

STINNER Victor added the comment: +/* Define if pthread_key_t is compatible with int. */ +#undef PTHREAD_KEY_T_IS_COMPATIBLE_WITH_INT Is this change the implementation of the issue #25658? -- ___ Python tracker

[issue29718] Fixed compile on cygwin.

STINNER Victor added the comment: https://github.com/python/cpython/pull/324#issuecomment-283931430 @AraHaan: "By the way guys I will be working on cpython to work on some changes to a few things for cygwin to compile using the official cpython source code on 3.5, 3.6, and 3.7. (...)" Cygwin

[issue29718] Fixed compile on cygwin.

Changes by Decorater : Removed file: http://bugs.python.org/file46697/cygwin_build.patch ___ Python tracker ___

[issue29718] Fixed compile on cygwin.

Changes by Decorater : -- pull_requests: +373 ___ Python tracker ___ ___

[issue29718] Fixed compile on cygwin.

Changes by Decorater : -- keywords: +patch Added file: http://bugs.python.org/file46697/cygwin_build.patch ___ Python tracker ___

[issue29718] Fixed compile on cygwin.

New submission from Decorater: Cygwin had an issue with building and installing python after it was configured. The main issue was the TLS key stuff which would make python fail to fully build or work correctly. This issue contains a patch for cygwin specifically to make it compile and work