[issue29750] smtplib doesn't handle unicode passwords

Sebastien Luttringer added the comment: Utf8 passwords are still broken on python 3.8. Patch works great on 3.8. -- ___ Python tracker ___

[issue29750] smtplib doesn't handle unicode passwords

Windson Yang added the comment: I just updated the PR -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29750] smtplib doesn't handle unicode passwords

Change by Windson Yang : -- pull_requests: +14813 pull_request: https://github.com/python/cpython/pull/15064 ___ Python tracker ___

[issue29750] smtplib doesn't handle unicode passwords

Windson Yang added the comment: Sorry, I forgot about this PR, I will update the patch depends on review soon :D -- ___ Python tracker ___

[issue29750] smtplib doesn't handle unicode passwords

Sebastien Luttringer added the comment: I hit the same issue. Do you have news about the patch review and its inclusion? -- nosy: +seblu ___ Python tracker ___

[issue29750] smtplib doesn't handle unicode passwords

Windson Yang added the comment: I added a pitch to support utf-8. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29750] smtplib doesn't handle unicode passwords

Change by Windson Yang : -- keywords: +patch pull_requests: +8411 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue29750] smtplib doesn't handle unicode passwords

Vadim Pushtaev added the comment: That's OK, you can do it. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29750] smtplib doesn't handle unicode passwords

Windson Yang added the comment: @Vadim Pushtaev I also want to work on it. If you wanna work together. Maybe we can talk on zulipchat. :D -- nosy: +Windson Yang ___ Python tracker

[issue29750] smtplib doesn't handle unicode passwords

Tal Einat added the comment: A comment here is all that is needed. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29750] smtplib doesn't handle unicode passwords

Vadim Pushtaev added the comment: Hello. I would like to work on this, should the issue be assigned on me or this comment is enough? -- nosy: +Vadim Pushtaev ___ Python tracker

[issue29750] smtplib doesn't handle unicode passwords

Tal Einat added the comment: Never mind, I won't have time for this any time soon, better if someone else can do it. -- ___ Python tracker ___

[issue29750] smtplib doesn't handle unicode passwords

Tal Einat added the comment: I have worked on this, almost ready for a PR. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue29750] smtplib doesn't handle unicode passwords

Gabriele Tornetta added the comment: Are there any PRs already for this issue? I couldn't find any on GitHub. Also, is the plan to branch the fix down to at least 3.6? -- nosy: +Gabriele Tornetta ___ Python tracker

[issue29750] smtplib doesn't handle unicode passwords

R. David Murray added the comment: I didn't think to look at the standards for the auth mechanisms, I only looked at the smtp standards. So, if the standard says utf-8, then we should use that. But we should still support bytes passwords so that an application could work around issues

[issue29750] smtplib doesn't handle unicode passwords

Tal Einat added the comment: >From reading the aforementioned discussion on Thunderbird's issue tracker, >ISTM that encoding with UTF-8 is the way to go. -- ___ Python tracker

[issue29750] smtplib doesn't handle unicode passwords

Tal Einat added the comment: There's also some discussion there (from 3 years ago) of possibly needing to fall back to ISO-8859-1 to work with MS Exchange, despite the standards saying UTF-8 should be used. It's unclear to me whether that's actually the case. --

[issue29750] smtplib doesn't handle unicode passwords

Tal Einat added the comment: This specifically seems relevant: > In order for Thunderbird to be standards-compliant-enough to interoperate > with standards-compliant servers, it should use UTF-8 for the SASL PLAIN > mechanism regardless of the underlying protocol (IMAP, POP and SMTP). That

[issue29750] smtplib doesn't handle unicode passwords

Tal Einat added the comment: I found the Thunderbirg bugzilla issues where they appear to have dealt precisely with this issue (for a variety of protocols, including SMTP): https://bugzilla.mozilla.org/show_bug.cgi?id=312593 -- ___ Python tracker

[issue29750] smtplib doesn't handle unicode passwords

R. David Murray added the comment: We must continue to support at least ascii strings, for backward compatibility reasons. We can certainly improve the error messages, but the goal of this issue is to add support for bytes passwords. I lean toward continuing to only support ascii strings,

[issue29750] smtplib doesn't handle unicode passwords

david added the comment: I would like to see the second option (allow both, warning on non-ascii) On 17 June 2018 at 21:03, Tal Einat wrote: > > Tal Einat added the comment: > > > And yes, by binary passwords I mean that the module needs to support > being passed a bytes-like object as the

[issue29750] smtplib doesn't handle unicode passwords

Tal Einat added the comment: > And yes, by binary passwords I mean that the module needs to support being > passed a bytes-like object as the password, since clearly there are servers > "in the wild" that support non-ascii passwords and the only way to be sure > one can send the server the

[issue29750] smtplib doesn't handle unicode passwords

david added the comment: Yes, i used thunderbird for both On June 14, 2018 5:14:31 PM GMT+02:00, "R. David Murray" wrote: > >R. David Murray added the comment: > >For the web cases I presume you also set the password using the web >interface, so that doesn't really tell us anything useful.

[issue29750] smtplib doesn't handle unicode passwords

R. David Murray added the comment: For the web cases I presume you also set the password using the web interface, so that doesn't really tell us anything useful. Did you use thunderbird to access the mailbox that you set up via gmail and/or sogo? That would make what thunderbird does the

[issue29750] smtplib doesn't handle unicode passwords

david added the comment: Both thunderbird, sogo (web) and gmail (web). On June 14, 2018 3:54:31 PM GMT+02:00, "R. David Murray" wrote: > >R. David Murray added the comment: > >While you are correct that latin1 may be common in this situation, I >think it may still be better to have utf-8

[issue29750] smtplib doesn't handle unicode passwords

R. David Murray added the comment: While you are correct that latin1 may be common in this situation, I think it may still be better to have utf-8 be the default, since that is the (still emerging? :) standard. However, you are correct to call for examples: if in the *majority* of the

[issue29750] smtplib doesn't handle unicode passwords

david added the comment: In my case I was doing tests with "contraseña" which is (spanish for password) and it failed On June 14, 2018 8:36:30 AM GMT+02:00, Tal Einat wrote: > >Tal Einat added the comment: > >It would be extremely helpful to have some test cases that actually >work for

[issue29750] smtplib doesn't handle unicode passwords

Tal Einat added the comment: It would be extremely helpful to have some test cases that actually work for users but fail with smtplib. So far we have no actual examples, likely due to these being passwords. > Note: it is definitely the case, regardless of what the RFC says, that binary >

[issue29750] smtplib doesn't handle unicode passwords

Change by R. David Murray : -- stage: -> needs patch versions: +Python 3.8 -Python 3.7 ___ Python tracker ___ ___ Python-bugs-list

[issue29750] smtplib doesn't handle unicode passwords

R. David Murray added the comment: Note: it is definitely the case, regardless of what the RFC says, that binary passwords need to be supported. utf-8 should probably be used as the default encoding for string passwords, rather than ascii. See also #33741. --

[issue29750] smtplib doesn't handle unicode passwords

Change by R. David Murray : -- nosy: +JustAnother1, giampaolo.rodola, taleinat ___ Python tracker ___ ___ Python-bugs-list mailing

[issue29750] smtplib doesn't handle unicode passwords

R. David Murray added the comment: See msg253287. Someone should check the RFC. It is not obvious that just encoding using utf8 is correct; fundamentally passwords are binary data. But the auth methods don't currently accept binary data. UTF8 is a reasonable default these days, I think,

[issue29750] smtplib doesn't handle unicode passwords

david added the comment: I'm sorry I rushed my comment. Same thing happens on line 604 return encode_base64(s.encode('ascii'), eol='') changing both from 'ascii' to 'utf-8' works for me. -- ___ Python tracker

[issue29750] smtplib doesn't handle unicode passwords

New submission from david: Trying to use unicode passwords on smtplib fails miserably on python3. My particular issue arises on line 643 of said library: (code, resp) = self.docmd(encode_base64(password.encode('ascii'), eol='')) which obviously dies when trying to handle unicode chars.