[issue29822] inspect.isabstract does not work on abstract base classes during __init_subclass__

Serhiy Storchaka added the comment: Thank you for your contribution Nate. -- resolution: -> fixed stage: backport needed -> resolved status: open -> closed ___ Python tracker

[issue29822] inspect.isabstract does not work on abstract base classes during __init_subclass__

Serhiy Storchaka added the comment: New changeset 09b6c0c71ea944f7e8b46998f3ebaf5b9fbe15f6 by Serhiy Storchaka (Nate) in branch '3.6': [3.6] bpo-29822: make inspect.isabstract() work during __init_subclass__ (#1979)

[issue29822] inspect.isabstract does not work on abstract base classes during __init_subclass__

Changes by Nate Soares : -- pull_requests: +2045 ___ Python tracker ___ ___

[issue29822] inspect.isabstract does not work on abstract base classes during __init_subclass__

Changes by Serhiy Storchaka : -- stage: patch review -> backport needed versions: -Python 3.5 ___ Python tracker ___

[issue29822] inspect.isabstract does not work on abstract base classes during __init_subclass__

Serhiy Storchaka added the comment: New changeset fcfe80ec2592fed8b3941c79056a8737abef7d3b by Serhiy Storchaka (Nate) in branch 'master': bpo-29822: Make inspect.isabstract() work during __init_subclass__. (#678) https://github.com/python/cpython/commit/fcfe80ec2592fed8b3941c79056a8737abef7d3b

[issue29822] inspect.isabstract does not work on abstract base classes during __init_subclass__

Serhiy Storchaka added the comment: LGTM, but would be nice if Yury and Nick take a look. -- ___ Python tracker ___

[issue29822] inspect.isabstract does not work on abstract base classes during __init_subclass__

Changes by Serhiy Storchaka : -- nosy: +ncoghlan ___ Python tracker ___ ___

[issue29822] inspect.isabstract does not work on abstract base classes during __init_subclass__

Nate Soares added the comment: I didn't know about issue29638, and I'm not sure whether my PR fixes it. Looking at that bug, I don't think that my PR would fix it, because I still trust TPFLAGS_IS_ABSTRACT when __abstractmethods__ exists. That said, I'm not clear on how the cache works, so

[issue29822] inspect.isabstract does not work on abstract base classes during __init_subclass__

Serhiy Storchaka added the comment: Is this an alternate fix of issue29638? -- components: +Library (Lib) nosy: +yselivanov stage: -> patch review type: -> behavior versions: +Python 3.5, Python 3.6 ___ Python tracker

[issue29822] inspect.isabstract does not work on abstract base classes during __init_subclass__

Ivan Levkivskyi added the comment: Serhiy, sorry for a distraction, but it looks like here is one more situation where inspect.isabstract is problematic, similar to what was discussed in http://bugs.python.org/issue29638 recently. -- nosy: +levkivskyi, serhiy.storchaka

[issue29822] inspect.isabstract does not work on abstract base classes during __init_subclass__

Changes by Nate Soares : -- pull_requests: +556 ___ Python tracker ___ ___ Python-bugs-list

[issue29822] inspect.isabstract does not work on abstract base classes during __init_subclass__

New submission from Nate Soares: Here's an example test that fails: def test_isabstract_during_init_subclass(self): from abc import ABCMeta, abstractmethod isabstract_checks = [] class AbstractChecker(metaclass=ABCMeta): def __init_subclass__(cls):