[issue29974] Change typing.TYPE_CHECKING doc example

Ivan Levkivskyi added the comment: > Sorry for making a typo in your last name No problem! This actually happened maaany times with me :-) -- ___ Python tracker

[issue29974] Change typing.TYPE_CHECKING doc example

Mathias Rav added the comment: Sorry for making a typo in your last name, Ivan Levkivskyi! I should know better and use copy-and-paste. -- ___ Python tracker

[issue29974] Change typing.TYPE_CHECKING doc example

Berker Peksag added the comment: Now all backport PRs have been merged. Thanks for the PR, Mathias. > Thanks for making backport PRs! (and sorry for closing prematurely) No problem, thanks for the reviews! By the way, sorry I missed the typo in your last name while doing the initial merge.

[issue29974] Change typing.TYPE_CHECKING doc example

Berker Peksag added the comment: New changeset 04f389b8b357c8507b6c9642adcb8b956489e034 by Berker Peksag in branch '3.6': bpo-29974: Improve typing.TYPE_CHECKING example (GH-982) https://github.com/python/cpython/commit/04f389b8b357c8507b6c9642adcb8b956489e034 --

[issue29974] Change typing.TYPE_CHECKING doc example

Berker Peksag added the comment: New changeset 271a289a03ad10c91c5326bde3020f1cdf6a1fff by Berker Peksag in branch '3.5': bpo-29974: Improve typing.TYPE_CHECKING example (GH-982) https://github.com/python/cpython/commit/271a289a03ad10c91c5326bde3020f1cdf6a1fff --

[issue29974] Change typing.TYPE_CHECKING doc example

Ivan Levkivskyi added the comment: > 87c07fe9d908d0a2143fcc8369255c6ff3241503 should still be backported to 3.5 > and 3.6 branches so please don't close it yet. Thanks for making backport PRs! (and sorry for closing prematurely) -- ___ Python

[issue29974] Change typing.TYPE_CHECKING doc example

Changes by Berker Peksag : -- pull_requests: +1406 ___ Python tracker ___ ___

[issue29974] Change typing.TYPE_CHECKING doc example

Changes by Berker Peksag : -- pull_requests: +1404 ___ Python tracker ___ ___

[issue29974] Change typing.TYPE_CHECKING doc example

Berker Peksag added the comment: 87c07fe9d908d0a2143fcc8369255c6ff3241503 should still be backported to 3.5 and 3.6 branches so please don't close it yet. -- resolution: fixed -> stage: resolved -> backport needed status: closed -> open ___ Python

[issue29974] Change typing.TYPE_CHECKING doc example

Changes by Ivan Levkivskyi : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue29974] Change typing.TYPE_CHECKING doc example

Berker Peksag added the comment: New changeset 87c07fe9d908d0a2143fcc8369255c6ff3241503 by Berker Peksag (Mathias Rav) in branch 'master': bpo-29974: Improve typing.TYPE_CHECKING example (GH-982) https://github.com/python/cpython/commit/87c07fe9d908d0a2143fcc8369255c6ff3241503 --

[issue29974] Change typing.TYPE_CHECKING doc example

Changes by Ivan Levkivskyi : -- nosy: +levkivskyi ___ Python tracker ___ ___

[issue29974] Change typing.TYPE_CHECKING doc example

Mathias Rav added the comment: I have updated the patch after feedback from Jelle Zijlstra and Ivan Levkevskyi. Indeed the example was correct; the patch now adds wording from PEP 484 and PEP 526 to clarify why a function parameter annotation needs to be in quotes and a local variable

[issue29974] Change typing.TYPE_CHECKING doc example

Changes by Mathias Rav : -- title: typing.TYPE_CHECKING doc example is incorrect -> Change typing.TYPE_CHECKING doc example ___ Python tracker