[issue30290] IDLE: add tests for help_about.py

Terry J. Reedy added the comment: Postscript: this test that the retrieved text has at least two lines caught a bug in the new Windows Store python distribution. self.assertEqual(printer._Printer__lines[1], dialog._current_textview.textView.get('2.0', '2.end')) The

[issue30290] IDLE: add tests for help_about.py

Terry J. Reedy added the comment: New changeset 12cbd87ac0bb826d653040044c6b526dcdb6f6d1 by terryjreedy in branch '3.6': [3.6] bpo-30290: IDLE - pep8 names and tests for help-about (#2070) https://github.com/python/cpython/commit/12cbd87ac0bb826d653040044c6b526dcdb6f6d1 --

[issue30290] IDLE: add tests for help_about.py

Changes by Terry J. Reedy : -- pull_requests: +2133 ___ Python tracker ___ ___

[issue30290] IDLE: add tests for help_about.py

Changes by Terry J. Reedy : -- pull_requests: +2132 ___ Python tracker ___ ___

[issue30290] IDLE: add tests for help_about.py

Terry J. Reedy added the comment: A follow-up to my brief remarks about revamping About IDLE, in msg294298: idle-dev is subscription-required public forum for discussion of idle design issues. It has been dormant for a year and a half, but I would like to revive it to get broader user

[issue30290] IDLE: add tests for help_about.py

Changes by Terry J. Reedy : -- pull_requests: -1922 ___ Python tracker ___ ___

[issue30290] IDLE: add tests for help_about.py

Changes by Terry J. Reedy : -- pull_requests: +1927 ___ Python tracker ___ ___

[issue30290] IDLE: add tests for help_about.py

Terry J. Reedy added the comment: pr 1839 is now attached to new issue #30495. This issue is closed except for trivial bugs in the two merged PRs and backports. -- ___ Python tracker

[issue30290] IDLE: add tests for help_about.py

Cheryl Sabella added the comment: Thanks Terry. I've submitted a PR for the textview docstrings and PEP8 names and I'll work on the ttk conversion and the refactoring. -- ___ Python tracker

[issue30290] IDLE: add tests for help_about.py

Changes by Cheryl Sabella : -- pull_requests: +1922 ___ Python tracker ___ ___

[issue30290] IDLE: add tests for help_about.py

Terry J. Reedy added the comment: While reviewing, I decided to draw a widget tree. I believe it would have been easier if packs and grids were grouped. I want to continue with 'IDLE: modernize help-about' and ditto for textview. The help_about issue can begin with ttk conversion: change

[issue30290] IDLE: add tests for help_about.py

Terry J. Reedy added the comment: New changeset 5a346d5dbc1f0f70eca706a8ba19f7645bf17837 by terryjreedy (csabella) in branch 'master': bpo-30290: IDLE: Refactor help_about to PEP8 names (#1714) https://github.com/python/cpython/commit/5a346d5dbc1f0f70eca706a8ba19f7645bf17837 --

[issue30290] IDLE: add tests for help_about.py

Cheryl Sabella added the comment: Thanks Terry. I'll leave those other items alone for now. It makes sense what you said about the 'create widget' styles. Looking at it for the first time, I kind of liked the second version (in query) because I could more immediately understand what was

[issue30290] IDLE: add tests for help_about.py

Terry J. Reedy added the comment: At first glance, 1714 looks great. I hope to merge it tomorrow. On the issues you raised: 1. I want to leave existing constants alone for now. 2. There are two 'create widgets' styles: create, place, create, place, ...; and create, create, ..., place, place,

[issue30290] IDLE: add tests for help_about.py

Cheryl Sabella added the comment: I've made a pull request for 4, 5, and 6. I didn't remove the tk constants as it seemed you'd like to do all the files in one project for that. Also, in query.Query, I noticed that all the widgets were created first and then they were all added to the grid

[issue30290] IDLE: add tests for help_about.py

Changes by Cheryl Sabella : -- pull_requests: +1804 ___ Python tracker ___ ___

[issue30290] IDLE: add tests for help_about.py

Louie Lu added the comment: Terry: I see, I'll take some debugger stuff to try first. Cheryl: If you got any problem on 4/5/6, feel free to ask me on IRC or here! -- ___ Python tracker

[issue30290] IDLE: add tests for help_about.py

Terry J. Reedy added the comment: PR merged. I will worry about where in the test to call AboutDialog.Ok, which has the last uncovered line - and any other details -- later, perhaps when I merge this file into help.py. -- ___ Python tracker

[issue30290] IDLE: add tests for help_about.py

Terry J. Reedy added the comment: New changeset 054e09147aaa6f61aca6cd40c7bf7ce6dc54a04b by terryjreedy (mlouielu) in branch 'master': bpo-30290: IDLE: Add more tests for help_about dialog (#1697) https://github.com/python/cpython/commit/054e09147aaa6f61aca6cd40c7bf7ce6dc54a04b --

[issue30290] IDLE: add tests for help_about.py

Terry J. Reedy added the comment: I am about to go to bed, way late. I would like to review and apply all the non-test changes, 4,5,6 in one PR, and add 3 since I know what I meant. There can be multiple commits in one PR though. Louie, from #30422 and a tracker search, you can see that

[issue30290] IDLE: add tests for help_about.py

Louie Lu added the comment: Cheryl: yes, I may work on 4a/4b and msg294004 on Monday, or do you start at these tasks? -- ___ Python tracker ___

[issue30290] IDLE: add tests for help_about.py

Cheryl Sabella added the comment: Oh, I had started to make the changes, but that's OK. I'm still doing discovery too. 'Fun' did mean that I'll try something. This is exactly what I wanted to work on to dive into tkinter and idle, so I got excited. Louie, just to coordinate, are you

[issue30290] IDLE: add tests for help_about.py

Terry J. Reedy added the comment: Louie, at first glance, this appears to implement the remaining changes in 1 and 2. A possible problem is that I expect the needed 'self.' additions will conflict with the name changes on the same lines that Cheryl said she would do, about 10 hours ago.

[issue30290] IDLE: add tests for help_about.py

Louie Lu added the comment: Due to the merged of #30303, text_view now have _utest attribute for unittest, upload the unittest of help_about dialog in PR 1697 -- nosy: +louielu ___ Python tracker

[issue30290] IDLE: add tests for help_about.py

Changes by Louie Lu : -- pull_requests: +1790 ___ Python tracker ___ ___ Python-bugs-list

[issue30290] IDLE: add tests for help_about.py

Terry J. Reedy added the comment: I take 'fun' to mean you will try something. And yes, I have thought about the following for all IDLE modules. 6. Replace "from tkinter import *". It was mainly intended for interactive use. In production IDLE, use either a. from tkinter import Tk, Frame,

[issue30290] IDLE: add tests for help_about.py

Cheryl Sabella added the comment: Terry, Is there interest in changing the 'from tkinter import *'? -- ___ Python tracker ___

[issue30290] IDLE: add tests for help_about.py

Cheryl Sabella added the comment: This looks like fun! :-) I'll let you know if I have any questions. -- ___ Python tracker ___

[issue30290] IDLE: add tests for help_about.py

Terry J. Reedy added the comment: Follow-up issues. A. Move code and tests into help.py and test_help.py. B. Improve content: 1) #25224; 2) remove or update credits; 3) reconsider each item. C. Improve appearance: 1) ttk widgets; 2) Redo entire look. --

[issue30290] IDLE: add tests for help_about.py

Terry J. Reedy added the comment: 4a. Change uglyMidcap widget names and CamelCase function names to pep8_conformant names. Simplify: byline, email, docs, pyver, tkver, idlever, py_license, py_copyright, py_credits, readme, idle_news, idle_credits. 4b. Change CamelCase function names to

[issue30290] IDLE: add tests for help_about.py

New submission from Terry J. Reedy: Initial plan. 1a. Change AboutDialog to mimic query.Query with respect to _utest and suppression of dialog display and waiting. 1b. Create AboutDialog instance. 2a. Change textview.TextViewer as with AboutDialog. Also change textview functions and