[issue30484] Garbage Collector can cause Segfault whilst iterating dictionary items

Berker Peksag added the comment: PR 2248 (3.4) and PR 2396 (3.3) have been merged. I think this issue can be closed now. -- nosy: +berker.peksag resolution: -> fixed stage: patch review -> resolved status: open -> closed

[issue30484] Garbage Collector can cause Segfault whilst iterating dictionary items

Larry Hastings added the comment: Yes, and thank you for submitting the PR to backport it to 3.4! (And thank you for backporting it to 3.3, too!) -- ___ Python tracker

[issue30484] Garbage Collector can cause Segfault whilst iterating dictionary items

Serhiy Storchaka added the comment: Larry, does it worth to fix this issue in 3.4? -- assignee: -> larry ___ Python tracker ___

[issue30484] Garbage Collector can cause Segfault whilst iterating dictionary items

Serhiy Storchaka added the comment: PR 2248 backports the issue27945 patch to 3.4. Seems it fixes this issue. -- stage: -> patch review ___ Python tracker

[issue30484] Garbage Collector can cause Segfault whilst iterating dictionary items

Changes by Serhiy Storchaka : -- pull_requests: +2297 ___ Python tracker ___ ___

[issue30484] Garbage Collector can cause Segfault whilst iterating dictionary items

Serhiy Storchaka added the comment: 3.4 is open only for security fixes. Can this crash be considered a security issue? In that case I can backport the issue27945 patch to 3.4. -- nosy: +larry, serhiy.storchaka versions: -Python 3.5, Python 3.6 ___

[issue30484] Garbage Collector can cause Segfault whilst iterating dictionary items

Jim Wright added the comment: Hi Jelle, I think you're right about master; it looks like this very recent change: https://github.com/python/cpython/pull/1657 could have fixed the issue, but I didn't find it whilst doing my original investigation of the issue on our side. --

[issue30484] Garbage Collector can cause Segfault whilst iterating dictionary items

Jelle Zijlstra added the comment: I could reproduce this on 3.4, but not on 3.3, 2.7, or master. -- nosy: +Jelle Zijlstra versions: +Python 3.4 ___ Python tracker

[issue30484] Garbage Collector can cause Segfault whilst iterating dictionary items

New submission from Jim Wright: We discovered this issue whilst using h5py (HDF5 python library) under python 3.5.2 on Ubuntu 16.04.2 x86_64. The construct used is very dubious, and I will separately be raising an issue with the h5py team. However I thought you might like to know there is a