[issue30557] faulthandler does not correctly filter fatal exceptions on Windows

Changes by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue30557] faulthandler does not correctly filter fatal exceptions on Windows

Steve Dower added the comment: New changeset 2bafc0dccac2390a52670ba289878318b6ea0293 by Steve Dower in branch '3.6': [3.6] bpo-30557: faulthandler now correctly filters and displays exception … (#1960) https://github.com/python/cpython/commit/2bafc0dccac2390a52670ba289878318b6ea0293

[issue30557] faulthandler does not correctly filter fatal exceptions on Windows

Steve Dower added the comment: My backport wasn't merged, so I cherrypicked Victor's fix into that PR. Once the buildbots are green again, I'll merge it. -- ___ Python tracker

[issue30557] faulthandler does not correctly filter fatal exceptions on Windows

Steve Dower added the comment: New changeset 6a1d84e2b37291b7e3bc5ddad14a60aed430e404 by Steve Dower (Victor Stinner) in branch 'master': bpo-30557: Fix test_faulthandler (#1969) https://github.com/python/cpython/commit/6a1d84e2b37291b7e3bc5ddad14a60aed430e404 --

[issue30557] faulthandler does not correctly filter fatal exceptions on Windows

STINNER Victor added the comment: It seems like all 3.x Windows buildbots are red... except of x86 Windows7 3.x. Only on Windows older than 7 SP 1, so on Windows 7 for buildbots, the bit is cleared. I created https://github.com/python/cpython/pull/1969 to try to fix buildbots. --

[issue30557] faulthandler does not correctly filter fatal exceptions on Windows

Changes by STINNER Victor : -- pull_requests: +2035 ___ Python tracker ___ ___

[issue30557] faulthandler does not correctly filter fatal exceptions on Windows

Steve Dower added the comment: Thanks. Apparently that "filter out bit 4" thing didn't exist in Win7. Guess I need to track down the actual docs and confirm exactly where that happens. Doesn't break the important functionality though, just the test. I don't know that the exit code is stable

[issue30557] faulthandler does not correctly filter fatal exceptions on Windows

Ned Deily added the comment: Buildbot failure? http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/521 -- nosy: +ned.deily ___ Python tracker

[issue30557] faulthandler does not correctly filter fatal exceptions on Windows

Changes by Steve Dower : -- pull_requests: +2031 ___ Python tracker ___ ___

[issue30557] faulthandler does not correctly filter fatal exceptions on Windows

Steve Dower added the comment: New changeset e6a23c8f9a3ce05b759599696cc131c2d9d147ac by Steve Dower in branch 'master': bpo-30557: faulthandler now correctly filters and displays exception codes on Windows (#1924)

[issue30557] faulthandler does not correctly filter fatal exceptions on Windows

Changes by Steve Dower : -- pull_requests: +2004 ___ Python tracker ___ ___

[issue30557] faulthandler does not correctly filter fatal exceptions on Windows

Steve Dower added the comment: Also, it displays exception codes as decimal, but should be hex. I'll fix that too -- ___ Python tracker ___

[issue30557] faulthandler does not correctly filter fatal exceptions on Windows

New submission from Steve Dower: faulthandler adds a structured exception handler on Windows so we can dump a Python traceback before crashing. This should only be done for fatal exceptions, but is currently done for some non-fatal exceptions. The current test is `flags &