[issue30595] test_queue_feeder_donot_stop_onexc() of test_multiprocessing_spawn fails randomly on x86 Windows7 3.x

STINNER Victor added the comment: The Python 2.7 is to fix this failure: http://buildbot.python.org/all/#/builders/59/builds/61 test_lock (test.test_multiprocessing.TestForkAwareThreadLock) ... ok test_ignore (test.test_multiprocessing.TestIgnoreEINTR) ... ok test

[issue30595] test_queue_feeder_donot_stop_onexc() of test_multiprocessing_spawn fails randomly on x86 Windows7 3.x

STINNER Victor added the comment: New changeset b60f43a0e6052b29517931eea591b0b29903f382 by Victor Stinner in branch '2.7': bpo-30595: Increase test_queue_feeder_donot_stop_onexc() timeout (GH-2148) (GH-5429)

[issue30595] test_queue_feeder_donot_stop_onexc() of test_multiprocessing_spawn fails randomly on x86 Windows7 3.x

Change by STINNER Victor : -- pull_requests: +5264 ___ Python tracker ___ ___

[issue30595] test_queue_feeder_donot_stop_onexc() of test_multiprocessing_spawn fails randomly on x86 Windows7 3.x

STINNER Victor added the comment: I fixed multiprocessing.Queue.get(timeout) in 2.7, 3.6 and master. I close the issue. -- resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 2.7, Python 3.6 ___ Python tracker

[issue30595] test_queue_feeder_donot_stop_onexc() of test_multiprocessing_spawn fails randomly on x86 Windows7 3.x

STINNER Victor added the comment: New changeset ec9a7127b8196dc5ef27c5ee2772ecea7cbb32df by Victor Stinner in branch '2.7': [3.6] bpo-30595: Fix multiprocessing.Queue.get(timeout) (#2027) (#2881) (#2883) https://github.com/python/cpython/commit/ec9a7127b8196dc5ef27c5ee2772ecea7cbb32df

[issue30595] test_queue_feeder_donot_stop_onexc() of test_multiprocessing_spawn fails randomly on x86 Windows7 3.x

Changes by STINNER Victor : -- pull_requests: +2935 ___ Python tracker ___ ___

[issue30595] test_queue_feeder_donot_stop_onexc() of test_multiprocessing_spawn fails randomly on x86 Windows7 3.x

STINNER Victor added the comment: New changeset e42339d3a08a8fde3349722def85d7a8e49899be by Victor Stinner in branch '3.6': [3.6] bpo-30595: Fix multiprocessing.Queue.get(timeout) (#2027) (#2881) https://github.com/python/cpython/commit/e42339d3a08a8fde3349722def85d7a8e49899be --

[issue30595] test_queue_feeder_donot_stop_onexc() of test_multiprocessing_spawn fails randomly on x86 Windows7 3.x

Changes by STINNER Victor : -- pull_requests: +2933 ___ Python tracker ___ ___

[issue30595] test_queue_feeder_donot_stop_onexc() of test_multiprocessing_spawn fails randomly on x86 Windows7 3.x

STINNER Victor added the comment: New changeset 8f6eeaf21cdf4aea25fdefeec814a1ce07453fe9 by Victor Stinner in branch 'master': bpo-30595: Increase test_queue_feeder_donot_stop_onexc() timeout (#2148) https://github.com/python/cpython/commit/8f6eeaf21cdf4aea25fdefeec814a1ce07453fe9 --

[issue30595] test_queue_feeder_donot_stop_onexc() of test_multiprocessing_spawn fails randomly on x86 Windows7 3.x

STINNER Victor added the comment: > New changeset 1b7863c3b6519c6e134c28cab8b8af0dea43e375 by Victor Stinner in > branch 'master': > bpo-30595: Fix multiprocessing.Queue.get(timeout) (#2027) > https://github.com/python/cpython/commit/1b7863c3b6519c6e134c28cab8b8af0dea43e375 While this change

[issue30595] test_queue_feeder_donot_stop_onexc() of test_multiprocessing_spawn fails randomly on x86 Windows7 3.x

Changes by STINNER Victor : -- pull_requests: +2198 ___ Python tracker ___ ___

[issue30595] test_queue_feeder_donot_stop_onexc() of test_multiprocessing_spawn fails randomly on x86 Windows7 3.x

STINNER Victor added the comment: Let's *see* if it fixes the issue. It will be hard to check since it seems like the bug was random. -- ___ Python tracker

[issue30595] test_queue_feeder_donot_stop_onexc() of test_multiprocessing_spawn fails randomly on x86 Windows7 3.x

STINNER Victor added the comment: Thanks Grzegorz Grzywacz! I commited your idea of fix. Let's if it fixes the issue. It will be hard to check since it seems like the bug was random. Later, I will backport the fix to other branches. -- ___ Python

[issue30595] test_queue_feeder_donot_stop_onexc() of test_multiprocessing_spawn fails randomly on x86 Windows7 3.x

STINNER Victor added the comment: New changeset 1b7863c3b6519c6e134c28cab8b8af0dea43e375 by Victor Stinner in branch 'master': bpo-30595: Fix multiprocessing.Queue.get(timeout) (#2027) https://github.com/python/cpython/commit/1b7863c3b6519c6e134c28cab8b8af0dea43e375 --

[issue30595] test_queue_feeder_donot_stop_onexc() of test_multiprocessing_spawn fails randomly on x86 Windows7 3.x

STINNER Victor added the comment: > I am guessing `0.1` is too low because we have wrong condition in Queue.get. > It should be. I'm not sure that the buildbot took this code path, but I like your suggestion. Checking the reader in non-blocking mode is cheap. poll() with timeout < 0 works as

[issue30595] test_queue_feeder_donot_stop_onexc() of test_multiprocessing_spawn fails randomly on x86 Windows7 3.x

Changes by STINNER Victor : -- pull_requests: +2093 ___ Python tracker ___ ___

[issue30595] test_queue_feeder_donot_stop_onexc() of test_multiprocessing_spawn fails randomly on x86 Windows7 3.x

Grzegorz Grzywacz added the comment: of course it should be `if not`: diff --git a/Lib/multiprocessing/queues.py b/Lib/multiprocessing/queues.py index dda03dd..514f991 100644 --- a/Lib/multiprocessing/queues.py +++ b/Lib/multiprocessing/queues.py @@ -101,7 +101,7 @@ class Queue(object):

[issue30595] test_queue_feeder_donot_stop_onexc() of test_multiprocessing_spawn fails randomly on x86 Windows7 3.x

Grzegorz Grzywacz added the comment: Looks like build bot is too slow for timeout=0.1. I am guessing `0.1` is too low because we have wrong condition in Queue.get. It should be. diff --git a/Lib/multiprocessing/queues.py b/Lib/multiprocessing/queues.py index dda03dd..42e9884 100644 ---

[issue30595] test_queue_feeder_donot_stop_onexc() of test_multiprocessing_spawn fails randomly on x86 Windows7 3.x

Changes by STINNER Victor : -- pull_requests: +2092 ___ Python tracker ___ ___

[issue30595] test_queue_feeder_donot_stop_onexc() of test_multiprocessing_spawn fails randomly on x86 Windows7 3.x

STINNER Victor added the comment: Hum, it may be a regression a recent change like the commit bc50f03db4f58c869b78e98468e374d7e61f1227: bpo-30414: multiprocessing.Queue._feed do not break from main loop on exc (#1683) -- ___ Python tracker

[issue30595] test_queue_feeder_donot_stop_onexc() of test_multiprocessing_spawn fails randomly on x86 Windows7 3.x

New submission from STINNER Victor: http://buildbot.python.org/all/builders/x86%20Windows7%203.x/builds/712/steps/test/logs/stdio == ERROR: test_queue_feeder_donot_stop_onexc