[issue30687] build.bat should locate msbuild.exe rather than vcvarsall.bat

Ned Deily added the comment: New changeset 00134f64d982561750f57f1a0bb7bb073f9f237c by Ned Deily (Steve Dower) in branch '3.6': bpo-30687: Fixes build scripts to find msbuild.exe and stop relying on vcvarsall.bat (#2252) (#2280)

[issue30687] build.bat should locate msbuild.exe rather than vcvarsall.bat

Steve Dower added the comment: The bug is MSBuild 15.0 should be able to locate earlier versions of VC, even if you haven't installed it for VS 2017. -- ___ Python tracker

[issue30687] build.bat should locate msbuild.exe rather than vcvarsall.bat

Pär Björklund added the comment: I don't believe that this is a bug in Visual Studio as MSBuild is used for .NET projects as well it should be available even without the C++ tooling installed. Checking for the targets file seems like a workable solution. --

[issue30687] build.bat should locate msbuild.exe rather than vcvarsall.bat

Steve Dower added the comment: I suspect that should be filed as a bug against VS 2017 - I'll do that when I get to work on Monday. Our workaround should be to check for that targets file and keep searching if it's not found. Your best workaround is to start the build from the VS 2015

[issue30687] build.bat should locate msbuild.exe rather than vcvarsall.bat

Pär Björklund added the comment: Currently I have VS2017 installed without C++ tooling for .NET development. The C++ tooling breaks other projects I'm working on. I have VS2015 Community update 3 installed with C++ tooling and the latest compatible Windows SDK. Before this patch everything

[issue30687] build.bat should locate msbuild.exe rather than vcvarsall.bat

Steve Dower added the comment: You're going to get build failures without the C++ tooling anyway, and msbuild should find previous installs that are compatible. What is your system setup that causes this failure when you expect success? -- ___

[issue30687] build.bat should locate msbuild.exe rather than vcvarsall.bat

Pär Björklund added the comment: This change causes build failures when VS2017 is installed without the C++ tooling as it finds MSBuild belonging to VS2017 but it can't build using it. Microsoft recommends using this tool https://github.com/microsoft/vswhere to find and set up the paths, it

[issue30687] build.bat should locate msbuild.exe rather than vcvarsall.bat

Changes by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue30687] build.bat should locate msbuild.exe rather than vcvarsall.bat

Steve Dower added the comment: Ned - this has been merged into 3.6 branch and the buildbots look good. Feel free to move the NEWS item around and/or cherrypick into 3.6.2 at your leisure. -- nosy: +ned.deily ___ Python tracker

[issue30687] build.bat should locate msbuild.exe rather than vcvarsall.bat

Steve Dower added the comment: New changeset 2c899ccffda92a7f3d4e7a01f14a666504db07b5 by Steve Dower in branch '3.5': bpo-30687: Fixes build scripts to find msbuild.exe and stop relying on vcvarsall.bat (#2252) (#2281)

[issue30687] build.bat should locate msbuild.exe rather than vcvarsall.bat

Steve Dower added the comment: New changeset 06d6e3d0bb5b8a3d3105289034953a8014356a0b by Steve Dower in branch '3.6': bpo-30687: Fixes build scripts to find msbuild.exe and stop relying on vcvarsall.bat (#2252) (#2280)

[issue30687] build.bat should locate msbuild.exe rather than vcvarsall.bat

Changes by Steve Dower : -- pull_requests: +2330 ___ Python tracker ___ ___

[issue30687] build.bat should locate msbuild.exe rather than vcvarsall.bat

Changes by Steve Dower : -- pull_requests: +2329 ___ Python tracker ___ ___

[issue30687] build.bat should locate msbuild.exe rather than vcvarsall.bat

Steve Dower added the comment: New changeset 40a23e88994aca92c83c8e84ab8b8cdc11d7ec54 by Steve Dower in branch 'master': bpo-30687: Fixes build scripts to find msbuild.exe and stop relying on vcvarsall.bat (#2252)

[issue30687] build.bat should locate msbuild.exe rather than vcvarsall.bat

Changes by Jeremy Kloth : -- nosy: +jkloth ___ Python tracker ___ ___

[issue30687] build.bat should locate msbuild.exe rather than vcvarsall.bat

New submission from Steve Dower: Due to how installation of Visual Studio 2017 has changed, it's very possible to end up with a valid install of the build tools without vcvarsall.bat being valid. We only require MSBuild.exe to build, so we should find that tool and invoke it, rather than

[issue30687] build.bat should locate msbuild.exe rather than vcvarsall.bat

Changes by Steve Dower : -- pull_requests: +2302 ___ Python tracker ___ ___