[issue30722] Tools/demo/redemo.py broken

Change by Berker Peksag : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list

[issue30722] Tools/demo/redemo.py broken

Berker Peksag added the comment: New changeset 9d85856044a2c7d681ea38b5ff99af375b228a0f by Berker Peksag in branch '3.6': bpo-30722: Fix NEWS entry (GH-8501) https://github.com/python/cpython/commit/9d85856044a2c7d681ea38b5ff99af375b228a0f --

[issue30722] Tools/demo/redemo.py broken

Berker Peksag added the comment: New changeset 7cbde0e09daba4259565738e48f141851287fe29 by Berker Peksag (Miss Islington (bot)) in branch '3.7': bpo-30722: Fix NEWS entries (GH-8501) https://github.com/python/cpython/commit/7cbde0e09daba4259565738e48f141851287fe29 --

[issue30722] Tools/demo/redemo.py broken

Change by Berker Peksag : -- pull_requests: +8023 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30722] Tools/demo/redemo.py broken

Change by miss-islington : -- pull_requests: +8022 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30722] Tools/demo/redemo.py broken

Berker Peksag added the comment: New changeset 612dbefe9dfce0f67bce358613e472e913be8a57 by Berker Peksag in branch 'master': bpo-30722: Fix NEWS entries (GH-8501) https://github.com/python/cpython/commit/612dbefe9dfce0f67bce358613e472e913be8a57 --

[issue30722] Tools/demo/redemo.py broken

Change by Berker Peksag : -- pull_requests: +8019 stage: resolved -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue30722] Tools/demo/redemo.py broken

Serhiy Storchaka added the comment: The news message is verbose but looks misleading to me. There is nothing invalid with usages like getattr(re, 'DOTALL'). It is the same as re.DOTALL, and using enums haven't changed this. -- status: closed -> open

[issue30722] Tools/demo/redemo.py broken

Berker Peksag added the comment: Thank you, Christoph. I wasn't aware of Tools/demo/redemo.py and I must say it was fun to play with while reviewing PR 2311. -- components: +Demos and Tools -Regular Expressions resolution: -> fixed stage: patch review ->

[issue30722] Tools/demo/redemo.py broken

Berker Peksag added the comment: New changeset a5f9d24c171c7e3a3715161fd16b747c7dcaf76f by Berker Peksag (Miss Islington (bot)) in branch '3.6': bpo-30722: Make redemo work with Python 3.6+ (GH-2311)

[issue30722] Tools/demo/redemo.py broken

Change by Roundup Robot : -- keywords: +patch pull_requests: +4060 stage: -> patch review ___ Python tracker ___

[issue30722] Tools/demo/redemo.py broken

Berker Peksag added the comment: New changeset 62adc55aff0b78447568f73bd1abc610d2784bf8 by Berker Peksag (Christoph Sarnowski) in branch 'master': bpo-30722: Make redemo work with Python 3.6+ (GH-2311)

[issue30722] Tools/demo/redemo.py broken

Changes by Roundup Robot : -- pull_requests: +2356 ___ Python tracker ___

[issue30722] Tools/demo/redemo.py broken

Christoph Sarnowski added the comment: By the way, I confused the flags, in my error-reproduction steps, instead of the re.MULTILINE flag, it is the re.DOTALL flag that should lead to all lines being matched by ".*". -- ___ Python tracker

[issue30722] Tools/demo/redemo.py broken

Serhiy Storchaka added the comment: I think ideally it would be nice to provide a switch between Unicode and bytes and disable the LOCALE flag in the Unicode mode. But this is too complex task. I think it is better to remove LOCALE. -- nosy: +serhiy.storchaka

[issue30722] Tools/demo/redemo.py broken

Christoph Sarnowski added the comment: Hi, sorry for forgetting steps to reproduce the bug. Easiest way to see it is to start redemo.py from a console (important on windows), so you can see stdout/stderr. Then just a click on any of those flag checkboxes leads to an exception backtrace

[issue30722] Tools/demo/redemo.py broken

Louie Lu added the comment: Also, would you like to contribute with PR on GitHub? -- ___ Python tracker ___

[issue30722] Tools/demo/redemo.py broken

Louie Lu added the comment: Hi Christoph, chould you provide a small example that breaks the regex demo? thanks! -- nosy: +louielu ___ Python tracker

[issue30722] Tools/demo/redemo.py broken

New submission from Christoph Sarnowski: In Python 3.6, the flags in the "re" module became members of an enum.IntFlag, whereas before they were just ints. This breaks the regex demo in Tools/demo/redemo.py. To fix this, in line 86 of redemo.py, getattr(re, name) has to be replaced by