[issue30726] [Windows] Warnings in elementtree due to new expat

Change by Ned Deily : -- Removed message: https://bugs.python.org/msg342097 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue30726] [Windows] Warnings in elementtree due to new expat

Ned Deily added the comment: New changeset 71572bbe82aa0836c036d44d41c8269ba6a321be by larryhastings (Victor Stinner) in branch '3.4': [3.4] bpo-29591, bpo-30694: Upgrade Modules/expat to libexpat 2.2.1 (#2164) (#2203)

[issue30726] [Windows] Warnings in elementtree due to new expat

Ned Deily added the comment: New changeset ab90986600ba7dea2aa41e5c1773791070725453 by Ned Deily (Victor Stinner) in branch '3.3': [3.3] bpo-29591, bpo-30694: Upgrade Modules/expat to libexpat 2.2.1 (#2164) (#2204)

[issue30726] [Windows] Warnings in elementtree due to new expat

Larry Hastings added the comment: New changeset 71572bbe82aa0836c036d44d41c8269ba6a321be by larryhastings (Victor Stinner) in branch '3.4': [3.4] bpo-29591, bpo-30694: Upgrade Modules/expat to libexpat 2.2.1 (#2164) (#2203)

[issue30726] [Windows] Warnings in elementtree due to new expat

Ned Deily added the comment: New changeset 5777e79ecbd1f2adf36456e09f210608ee221691 by Ned Deily (Victor Stinner) in branch '3.6': [3.6] bpo-30726: PCbuild _elementtree: remove duplicate defines (#2348) (#2349) https://github.com/python/cpython/commit/5777e79ecbd1f2adf36456e09f210608ee221691

[issue30726] [Windows] Warnings in elementtree due to new expat

Steve Dower added the comment: I hope you notice I'm not against this particular change. I'm just voicing a general belief that suppressing an entire category of warnings for a whole project is not necessarily an improvement. In future, and when applied to our own project files, expect me to

[issue30726] [Windows] Warnings in elementtree due to new expat

STINNER Victor added the comment: Steve Dower: "The approach used to suppress this warning will also suppress other warnings that might be fixable. Hard to say it's definitely a good thing in this case, though in general I agree that selectively suppressing warnings that cannot be fixed is a

[issue30726] [Windows] Warnings in elementtree due to new expat

Segev Finer added the comment: > The approach used to suppress this warning will also suppress other warnings > that might be fixable. Hard to say it's definitely a good thing in this case, > though in general I agree that selectively suppressing warnings that cannot > be fixed is a good

[issue30726] [Windows] Warnings in elementtree due to new expat

Steve Dower added the comment: > I like decreasing the number of warnings. It helps to detect new warnings, > and so to prevent bugs. The approach used to suppress this warning will also suppress other warnings that might be fixable. Hard to say it's definitely a good thing in this case,

[issue30726] [Windows] Warnings in elementtree due to new expat

STINNER Victor added the comment: > It doesn't even fix a warning - only suppresses it. Since there is no > behavior change at all, I'm not inclined to backport any further than is > trivial. I like decreasing the number of warnings. It helps to detect new warnings, and so to prevent bugs.

[issue30726] [Windows] Warnings in elementtree due to new expat

Changes by STINNER Victor : -- resolution: -> fixed stage: backport needed -> resolved status: open -> closed ___ Python tracker

[issue30726] [Windows] Warnings in elementtree due to new expat

STINNER Victor added the comment: Thanks Segev Finer for backports. -- ___ Python tracker ___ ___

[issue30726] [Windows] Warnings in elementtree due to new expat

STINNER Victor added the comment: New changeset d0ae4be443332d63fafb304944842fbaece734a3 by Victor Stinner (Segev Finer) in branch '2.7': bpo-30726: Add _CRT_SECURE_NO_WARNINGS to _elementtree and pyexpat projects (#2572)

[issue30726] [Windows] Warnings in elementtree due to new expat

STINNER Victor added the comment: New changeset 320ee67f981f766ff55c55ef87d5ef17ce297824 by Victor Stinner (Segev Finer) in branch '3.5': [3.5] bpo-30726: Also fix pyexpat.vcxproj (GH-2375) (#2571) https://github.com/python/cpython/commit/320ee67f981f766ff55c55ef87d5ef17ce297824 --

[issue30726] [Windows] Warnings in elementtree due to new expat

STINNER Victor added the comment: New changeset d02c8416fe1b29b3322004b73133bf6c8a2e353a by Victor Stinner (Segev Finer) in branch '3.6': [3.6] bpo-30726: Also fix pyexpat.vcxproj (GH-2375) (#2570) https://github.com/python/cpython/commit/d02c8416fe1b29b3322004b73133bf6c8a2e353a --

[issue30726] [Windows] Warnings in elementtree due to new expat

Changes by Segev Finer : -- pull_requests: +2643 ___ Python tracker ___ ___

[issue30726] [Windows] Warnings in elementtree due to new expat

Segev Finer added the comment: Python 2.7 diverged https://github.com/python/cpython/commit/ab3b0ade505ce07a3d5ec4fbc991a154242732e6. It's only missing _CRT_SECURE_NO_WARNINGS. :P -- ___ Python tracker

[issue30726] [Windows] Warnings in elementtree due to new expat

Changes by Segev Finer : -- pull_requests: +2641 ___ Python tracker ___ ___

[issue30726] [Windows] Warnings in elementtree due to new expat

Changes by Segev Finer : -- pull_requests: +2642 ___ Python tracker ___ ___

[issue30726] [Windows] Warnings in elementtree due to new expat

STINNER Victor added the comment: Segev Finer: Would you mind to backport PR 2375 to 3.6 and 3.5 branches? Maybe also to 2.7, at least in PCbuild, maybe also PC/VS9.0/. -- ___ Python tracker

[issue30726] [Windows] Warnings in elementtree due to new expat

Steve Dower added the comment: It doesn't even fix a warning - only suppresses it. Since there is no behavior change at all, I'm not inclined to backport any further than is trivial. -- ___ Python tracker

[issue30726] [Windows] Warnings in elementtree due to new expat

STINNER Victor added the comment: > How far back does it need to be ported? Just to 3.5? Up to 2.7, expat 2.2.1 was updated to 2.7 as well. I even proposed a PR for 3.3 and 3.4 (not merged yet). But since this issue only fixes a warning, I don't think that it's worth it to backport it to 3.3

[issue30726] [Windows] Warnings in elementtree due to new expat

Changes by STINNER Victor : -- versions: +Python 2.7 ___ Python tracker ___ ___

[issue30726] [Windows] Warnings in elementtree due to new expat

Steve Dower added the comment: How far back does it need to be ported? Just to 3.5? -- stage: -> backport needed ___ Python tracker ___

[issue30726] [Windows] Warnings in elementtree due to new expat

Segev Finer added the comment: All that remains is back porting https://github.com/python/cpython/pull/2375 and than this issue is fixed. -- ___ Python tracker

[issue30726] [Windows] Warnings in elementtree due to new expat

Steve Dower added the comment: New changeset 7526cadd64566725ffc56071a7208828a46ddbd8 by Steve Dower (Segev Finer) in branch 'master': bpo-30726: Also fix pyexpat.vcxproj (#2375) https://github.com/python/cpython/commit/7526cadd64566725ffc56071a7208828a46ddbd8 --

[issue30726] [Windows] Warnings in elementtree due to new expat

Changes by Segev Finer : -- versions: +Python 3.5, Python 3.6 ___ Python tracker ___ ___

[issue30726] [Windows] Warnings in elementtree due to new expat

Segev Finer added the comment: It seems that the issue repeats in pyexpat.vcxproj. I submitted a PR for that one as well. -- ___ Python tracker ___

[issue30726] [Windows] Warnings in elementtree due to new expat

Changes by Segev Finer : -- pull_requests: +2422 ___ Python tracker ___ ___

[issue30726] [Windows] Warnings in elementtree due to new expat

STINNER Victor added the comment: New changeset 8f525882fa43209d52afdb99753de2f5111d7433 by Victor Stinner in branch 'master': bpo-30726: expat: Fix compiler warnings on Windows 64-bit (#2368) https://github.com/python/cpython/commit/8f525882fa43209d52afdb99753de2f5111d7433 --

[issue30726] [Windows] Warnings in elementtree due to new expat

Changes by STINNER Victor : -- pull_requests: +2418 ___ Python tracker ___ ___

[issue30726] [Windows] Warnings in elementtree due to new expat

STINNER Victor added the comment: New changeset d32a05953130fb5cc2d3c0c9fcb20ad0859353f3 by Victor Stinner in branch '3.6': [3.6] bpo-30726: PCbuild _elementtree: remove duplicate defines (#2348) (#2349) https://github.com/python/cpython/commit/d32a05953130fb5cc2d3c0c9fcb20ad0859353f3

[issue30726] [Windows] Warnings in elementtree due to new expat

STINNER Victor added the comment: New changeset f42ce179c8aaa7e211ac4123c58fa3dd9a452004 by Victor Stinner in branch '3.5': [3.5] bpo-30726: PCbuild _elementtree: remove duplicate defines (#2348) (#2350) https://github.com/python/cpython/commit/f42ce179c8aaa7e211ac4123c58fa3dd9a452004

[issue30726] [Windows] Warnings in elementtree due to new expat

STINNER Victor added the comment: New changeset 87c65550730a8f85ce339ba197bce4fb7e836619 by Victor Stinner (Segev Finer) in branch 'master': bpo-30726: Fix elementtree warnings on Windows due to expat upgrade (#2319)

[issue30726] [Windows] Warnings in elementtree due to new expat

STINNER Victor added the comment: > Oh... I'm sorry Segev Finer, I didn't see that you proposed a PR :-( Please rebase and rewrite your PR to just add _CRT_SECURE_NO_WARNINGS. Once merged, I will include this change to my 3.6 and 3.5 backports. --

[issue30726] [Windows] Warnings in elementtree due to new expat

STINNER Victor added the comment: For siphash.h warnings, I created a PR on libexpat: https://github.com/libexpat/libexpat/pull/58 -- ___ Python tracker

[issue30726] [Windows] Warnings in elementtree due to new expat

STINNER Victor added the comment: Oh... I'm sorry Segev Finer, I didn't see that you proposed a PR :-( -- ___ Python tracker ___

[issue30726] [Windows] Warnings in elementtree due to new expat

STINNER Victor added the comment: My commit c8fb58bd7917151e63398587a7fc2126db7c26de (co-written with Jeremy Kloth) fixes the "macro redefinition". There are still warnings in the siphash code, but I suggest to report them upstream, and *then* propose to cherry-pick fixes from libexpat (as I

[issue30726] [Windows] Warnings in elementtree due to new expat

Changes by STINNER Victor : -- pull_requests: +2393 ___ Python tracker ___ ___

[issue30726] [Windows] Warnings in elementtree due to new expat

Changes by STINNER Victor : -- pull_requests: +2395 ___ Python tracker ___ ___

[issue30726] [Windows] Warnings in elementtree due to new expat

STINNER Victor added the comment: New changeset c8fb58bd7917151e63398587a7fc2126db7c26de by Victor Stinner in branch 'master': bpo-30726: PCbuild _elementtree: remove duplicate defines (#2348) https://github.com/python/cpython/commit/c8fb58bd7917151e63398587a7fc2126db7c26de --

[issue30726] [Windows] Warnings in elementtree due to new expat

Changes by STINNER Victor : -- pull_requests: +2391 ___ Python tracker ___ ___

[issue30726] [Windows] Warnings in elementtree due to new expat

Changes by Louie Lu : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue30726] [Windows] Warnings in elementtree due to new expat

Changes by Segev Finer : -- type: -> compile error ___ Python tracker ___ ___

[issue30726] [Windows] Warnings in elementtree due to new expat

Changes by Segev Finer : -- pull_requests: +2369 ___ Python tracker ___ ___

[issue30726] [Windows] Warnings in elementtree due to new expat

New submission from Segev Finer: We are getting: Warning C4005 'HAVE_MEMMOVE': macro redefinition _elementtree c:\users\segev\prj\python\cpython\modules\expat\winconfig.h 34 Warning C4267 '=': conversion from 'size_t' to 'unsigned char', possible loss of data