[issue30841] A shadowing variable naming emitted for Python-ast.c

Yuan Chao Chou added the comment: This can be repro by setting -Wshadow-compatible-local when using gcc to compile Python-ast.c. An example on my machine: ➜ cpython git:(69c0db5050) ✗ gcc-7 -Wshadow-compatible-local -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3

[issue30841] A shadowing variable naming emitted for Python-ast.c

Benjamin Peterson added the comment: What actually omits warnings about this? -- ___ Python tracker ___ ___

[issue30841] A shadowing variable naming emitted for Python-ast.c

Changes by Brett Cannon : -- type: compile error -> enhancement ___ Python tracker ___ ___

[issue30841] A shadowing variable naming emitted for Python-ast.c

Changes by Brett Cannon : -- priority: normal -> low ___ Python tracker ___ ___

[issue30841] A shadowing variable naming emitted for Python-ast.c

Changes by Terry J. Reedy : -- nosy: +benjamin.peterson, brett.cannon, ncoghlan, yselivanov ___ Python tracker ___

[issue30841] A shadowing variable naming emitted for Python-ast.c

Changes by Yuan Chao Chou : -- pull_requests: +2619 ___ Python tracker ___ ___

[issue30841] A shadowing variable naming emitted for Python-ast.c

Changes by Yuan Chao Chou : -- pull_requests: +2618 ___ Python tracker ___ ___

[issue30841] A shadowing variable naming emitted for Python-ast.c

Changes by Yuan Chao Chou : -- pull_requests: +2617 ___ Python tracker ___ ___

[issue30841] A shadowing variable naming emitted for Python-ast.c

New submission from Yuan Chao Chou: When Parser/asdl_c.py is composing the content of Python/Python-ast.c, it uses "value" to name the variables in inner blocks, which can shadow the variables named the same in outer blocks. It would be a good practice to avoid the shadowing naming to prevent