[issue30869] regrtest: Add .idlerc to saved_test_environment

2017-07-08 Thread Terry J. Reedy
Terry J. Reedy added the comment: #27534 is about reducing run's imports. I believe that the current patch may remove one path by which config is indirectly imported. While writing msg297983 of #30868, I remembered that config files are not the only files put in .idlerc. So a solution to

[issue30869] regrtest: Add .idlerc to saved_test_environment

2017-07-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: The current tests do not write anything. But IDLE currently requires the existence of .idlerc to run, and tries to write it if not found. Changing this requirement without disabling multiple features would not be trivial. On possibility might be to replace

[issue30869] regrtest: Add .idlerc to saved_test_environment

2017-07-07 Thread STINNER Victor
STINNER Victor added the comment: test_site has a similar issue: bpo-30227, "test_site must not write outside the build directory: must not write into $HOME/.local/". -- ___ Python tracker

[issue30869] regrtest: Add .idlerc to saved_test_environment

2017-07-07 Thread STINNER Victor
STINNER Victor added the comment: I dislike the idea of opening all $HOME/.idlerc/ directory and store their content in memory. If a unit test writes into $HOME, we already have an issue. Unit tests must not modify the user configuration. If an unit test is interrupted, there is a high risk

[issue30869] regrtest: Add .idlerc to saved_test_environment

2017-07-06 Thread Terry J. Reedy
Terry J. Reedy added the comment: I would have liked the mistake in #30780 to have been noticed, but I don't think the patch would have caught it. What I failed to restore was an in memory date structure that is part of the config module. The patch seems to be concerned only with the

[issue30869] regrtest: Add .idlerc to saved_test_environment

2017-07-06 Thread Louie Lu
Changes by Louie Lu : -- pull_requests: +2679 ___ Python tracker ___ ___ Python-bugs-list

[issue30869] regrtest: Add .idlerc to saved_test_environment

2017-07-06 Thread Louie Lu
New submission from Louie Lu: In bpo #30780, there is a mistake of tearDownModule didn't restore the use rCfg. To prevent future mistake, Adding .idlerc to regrtest saved_test_environment, so that `--fail-env-changed` option can detect .idlerc been changed in IDLE test. --