[issue30876] SystemError on importing module from unloaded package

Larry Hastings added the comment: If the change has been checked into the 3.5 branch, it'll go out with 3.5.5. TBH we should probably stop accepting bug fixes into a branch when it hits rc1 of "last release to accept bugfixes" (e.g. 3.5.4rc1). There are two or three bugfixes in the 3.5

[issue30876] SystemError on importing module from unloaded package

Nick Coghlan added the comment: Tagging Petr Viktorin and Matthias Klose, as this may impact distro builds of 3.5.4 that run the tests over the installed version rather than directly from the VCS checkout. It would be slightly helpful to not have to carry the "fix Python's self-tests" patch

[issue30876] SystemError on importing module from unloaded package

Ned Deily added the comment: Just to clarify: the revision added since 3.5.4rc1, f9fbed19a964e55ee703005823d8a7408f83d7f4 ([3.5] bpo-30876: Add new import test files to projects) fixes a test failure seen on all non-Windows platforms when running tests from an installed Python. It's

[issue30876] SystemError on importing module from unloaded package

Larry Hastings added the comment: Okay, that's good news. That means I don't have to accept a fix for it in the 3.5 branch *after* 3.5 transitions to security-fixes-only mode tomorrow ;-) -- ___ Python tracker

[issue30876] SystemError on importing module from unloaded package

Serhiy Storchaka added the comment: This is a FreeBSD bug. It isn't related to this change. See issue31044 for details. -- ___ Python tracker ___

[issue30876] SystemError on importing module from unloaded package

Larry Hastings added the comment: It seems this change broke the 3.5 build on AMD FreeBSD: http://buildbot.python.org/all/builders/AMD64%20FreeBSD%20CURRENT%20Debug%203.5 On the 3.5 branch, the previous revision (19b2890014d3098147d16475c492a47a43893768) built and tested successfully on July

[issue30876] SystemError on importing module from unloaded package

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue30876] SystemError on importing module from unloaded package

Serhiy Storchaka added the comment: New changeset f9fbed19a964e55ee703005823d8a7408f83d7f4 by Serhiy Storchaka in branch '3.5': [3.5] bpo-30876: Add new import test files to projects. (GH-2851). (#2913) https://github.com/python/cpython/commit/f9fbed19a964e55ee703005823d8a7408f83d7f4

[issue30876] SystemError on importing module from unloaded package

Serhiy Storchaka added the comment: New changeset 95b16a9705d6b4d31c016c014e59744fc33d53ea by Serhiy Storchaka in branch '3.6': [3.6] bpo-30814, bpo-30876: Add new import test files to projects. (GH-2851). (#2912)

[issue30876] SystemError on importing module from unloaded package

Changes by Serhiy Storchaka : -- pull_requests: +2965 ___ Python tracker ___ ___

[issue30876] SystemError on importing module from unloaded package

Changes by Serhiy Storchaka : -- pull_requests: +2964 ___ Python tracker ___ ___

[issue30876] SystemError on importing module from unloaded package

Serhiy Storchaka added the comment: New changeset d5ed47dea25e04a3a144eddf99a4ac4a29242dbc by Serhiy Storchaka in branch 'master': bpo-30814, bpo-30876: Add new import test files to projects. (#2851) https://github.com/python/cpython/commit/d5ed47dea25e04a3a144eddf99a4ac4a29242dbc --

[issue30876] SystemError on importing module from unloaded package

Dmitry Kazakov added the comment: Please ignore my last message, I didn't notice the existing pull request... Sorry. -- ___ Python tracker ___

[issue30876] SystemError on importing module from unloaded package

Dmitry K added the comment: test_concurrency (test.test_import.ImportTests) seems to fail, too, with a similar error: ModuleNotFoundError: No module named 'package' Apparently, this happens because the LIBSUBDIRS variable in Makefile doesn't include all the subdirectories of

[issue30876] SystemError on importing module from unloaded package

Changes by Serhiy Storchaka : -- pull_requests: +2901 ___ Python tracker ___ ___

[issue30876] SystemError on importing module from unloaded package

Ned Deily added the comment: When running tests from installed location, test_import now fails on master, 3.6, and 3.5 (including v3.5.4rc1) with: == ERROR: test_import_from_unloaded_package

[issue30876] SystemError on importing module from unloaded package

Serhiy Storchaka added the comment: New changeset c824cc8426a16dd9f3949a3ed135523d37787bae by Serhiy Storchaka in branch '3.5': [3.5] Backport bpo-30876 (GH-2639), bpo-18018 and bpo-26367. (#2677) https://github.com/python/cpython/commit/c824cc8426a16dd9f3949a3ed135523d37787bae --

[issue30876] SystemError on importing module from unloaded package

Serhiy Storchaka added the comment: New changeset 28343e3392ca7b1ec7151f68d4d92c90efb91e50 by Serhiy Storchaka in branch '3.6': [3.6] bpo-30876: Relative import from unloaded package now reimports the package (GH-2639) (#2676)

[issue30876] SystemError on importing module from unloaded package

Changes by Serhiy Storchaka : -- pull_requests: +2744 ___ Python tracker ___ ___

[issue30876] SystemError on importing module from unloaded package

Serhiy Storchaka added the comment: Ah, this is because issue18018 was fixed only in 3.6. Issue18018 is similar to this issue, it is about confusing SystemError. As a side effect it solved an example from issue26367 in C builtin __import__. I think that both raising SystemError and returning

[issue30876] SystemError on importing module from unloaded package

Serhiy Storchaka added the comment: When backported issue30876 to 3.5 I found that the lines elif not package: raise ImportError('attempted relative import with no known parent ' 'package') don't exist in 3.5. They where added in issue26367,

[issue30876] SystemError on importing module from unloaded package

Changes by Serhiy Storchaka : -- pull_requests: +2743 ___ Python tracker ___ ___

[issue30876] SystemError on importing module from unloaded package

Nick Coghlan added the comment: The fix is unintrusive enough that I'm +1 for also fixing it in 3.6 and 3.5. Trying to fix it in 2.7 would likely be more trouble than it's worth, but I also wouldn't be opposed to fixing it there if you or anyone else wanted to do it. --

[issue30876] SystemError on importing module from unloaded package

Serhiy Storchaka added the comment: What about other branches? Should we backport this change to them? I think that even if not backport this change we should change SystemError to more appropriate exception. -- ___ Python tracker

[issue30876] SystemError on importing module from unloaded package

Serhiy Storchaka added the comment: New changeset 8a9cd20edca7d01b68292036029ae3735ce65edd by Serhiy Storchaka in branch 'master': bpo-30876: Relative import from unloaded package now reimports the package (#2639)

[issue30876] SystemError on importing module from unloaded package

Changes by STINNER Victor : -- pull_requests: +2731 ___ Python tracker ___ ___

[issue30876] SystemError on importing module from unloaded package

Serhiy Storchaka added the comment: It is easy to replace the SystemError with a recursive import of the missing parent package. It is enough to remove raising the SystemError. The other effect of this change is that relative import from the top-level module now raises ImportError "attempted

[issue30876] SystemError on importing module from unloaded package

Changes by Serhiy Storchaka : -- pull_requests: +2704 ___ Python tracker ___ ___

[issue30876] SystemError on importing module from unloaded package

Nick Coghlan added the comment: OK, so at least for 3.7, we'll replace the SystemError with a recursive import of the missing parent package, just as we'd expect to see with an absolute import. I'm classing this as "Won't fix" for the native import system in 2.7 - folks wanting the fix there

[issue30876] SystemError on importing module from unloaded package

Changes by Serhiy Storchaka : -- title: SystemError on importing module that deletes itself from sys.modules -> SystemError on importing module from unloaded package ___ Python tracker