[issue31050] IDLE, configdialog: Factor out GenTab class from ConfigDialog

Terry J. Reedy added the comment: Much easier the 2nd time ;-) -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker

[issue31050] IDLE, configdialog: Factor out GenTab class from ConfigDialog

Terry J. Reedy added the comment: New changeset 8c4e5be1dfb4d1c74e8cc7ac925e3196818e07ac by Terry Jan Reedy in branch '3.6': [3.6] bpo-31050: IDLE: Factor GenPage class from ConfigDialog (GH-2952) (#2955) https://github.com/python/cpython/commit/8c4e5be1dfb4d1c74e8cc7ac925e3196818e07ac

[issue31050] IDLE, configdialog: Factor out GenTab class from ConfigDialog

Changes by Terry J. Reedy : -- pull_requests: +3003 ___ Python tracker ___ ___

[issue31050] IDLE, configdialog: Factor out GenTab class from ConfigDialog

Terry J. Reedy added the comment: New changeset e8eb17b2c11dcd1550a94b175e557c234a804482 by Terry Jan Reedy (csabella) in branch 'master': bpo-31050: IDLE: Factor GenPage class from ConfigDialog (#2952) https://github.com/python/cpython/commit/e8eb17b2c11dcd1550a94b175e557c234a804482

[issue31050] IDLE, configdialog: Factor out GenTab class from ConfigDialog

Terry J. Reedy added the comment: I intentionally left using non-default options other than traversal for a new issue or issues, after we finish ttk replacement. I imagine there will be discussions about choices, and I will invite other participants. I would like to direct visual design

[issue31050] IDLE, configdialog: Factor out GenTab class from ConfigDialog

Terry J. Reedy added the comment: I did not refresh this before writing the above. It still applies, including deleting the commented out code once tests pass. See review. Whoops: I forgot that using make_default means that we can (and should) delete the replaced var_changed defs. I added

[issue31050] IDLE, configdialog: Factor out GenTab class from ConfigDialog

Terry J. Reedy added the comment: Above, I left out the last step, "* remove old general block". The old configdialog had an unwritten and undocumented template and rules for pages on the dialog. It went something like the following. # def create_widgets(): * Pick names for the pages. They

[issue31050] IDLE, configdialog: Factor out GenTab class from ConfigDialog

Changes by Cheryl Sabella : -- pull_requests: +3000 ___ Python tracker ___ ___

[issue31050] IDLE, configdialog: Factor out GenTab class from ConfigDialog

Cheryl Sabella added the comment: Made all the changes without any issue. One thing - I noticed that the var_changed_autosave, etc for the General tab were back, even though they aren't used by VarTrace. I know I had deleted them, so I'm not sure how they came back. Unless you re-added

[issue31050] IDLE, configdialog: Factor out GenTab class from ConfigDialog

Changes by Terry J. Reedy : -- dependencies: +IDLE, configdialog: Factor out FontTab class from ConfigDialog ___ Python tracker ___

[issue31050] IDLE, configdialog: Factor out GenTab class from ConfigDialog

Terry J. Reedy added the comment: Now that we know what we are doing, we can simplify the steps. These assume that #21004, PR2905, which prepares create_widgets and fixes the GeneralTest that was broken by Notebook, has been merged. For configdialog: * copy general block after FontPage; *

[issue31050] IDLE, configdialog: Factor out GenTab class from ConfigDialog

Changes by Terry J. Reedy : -- assignee: -> terry.reedy components: +IDLE stage: -> needs patch type: -> enhancement versions: +Python 3.6, Python 3.7 ___ Python tracker

[issue31050] IDLE, configdialog: Factor out GenTab class from ConfigDialog

New submission from Terry J. Reedy: Followup to 31003, tests, and 30853, tracers, similar to 31004, FontTab. After creating new class, we can change names without worry about clashing with names elsewhere in ConfigDialog. -- messages: 299259 nosy: csabella, terry.reedy priority: