[issue31051] IDLE, configdialog, General tab: re-arrange, test user entries

Terry J. Reedy added the comment: New changeset 87c50245b1ba21469cc2e4e84cd5e5cd54ff954d by Terry Jan Reedy in branch '3.6': [3.6] bpo-31051: Rearrange IDLE condigdialog GenPage into Window, Editor, and Help sections. (GH-3239) (#3240)

[issue31051] IDLE, configdialog, General tab: re-arrange, test user entries

Changes by Terry J. Reedy : -- pull_requests: +3283 ___ Python tracker ___ ___

[issue31051] IDLE, configdialog, General tab: re-arrange, test user entries

Terry J. Reedy added the comment: New changeset 390eadd6d041611511dc761bc7d4581530dbd287 by Terry Jan Reedy in branch 'master': bpo-31051: Rearrange IDLE condigdialog GenPage into Window, Editor, and Help sections. (#3239)

[issue31051] IDLE, configdialog, General tab: re-arrange, test user entries

Terry J. Reedy added the comment: 'autocomplete and parenmatch' (in that order). Code context should be last in the editor section. -- ___ Python tracker

[issue31051] IDLE, configdialog, General tab: re-arrange, test user entries

Changes by Terry J. Reedy : -- stage: needs patch -> patch review ___ Python tracker ___

[issue31051] IDLE, configdialog, General tab: re-arrange, test user entries

Terry J. Reedy added the comment: It does not matter for users what we call the class. MainPage reads a bit smoother than GenPage. I have also considered renaming HighPage as ColorPage and relabeling the tab 'Colors'. The above covers at least 2 issues. #31306 covers changing Vars and

[issue31051] IDLE, configdialog, General tab: re-arrange, test user entries

Changes by Terry J. Reedy : -- pull_requests: +3282 ___ Python tracker ___ ___

[issue31051] IDLE, configdialog, General tab: re-arrange, test user entries

Louie Lu added the comment: I don't like the name "gentab". There is a "genobject.c" in source code but stand for "generator object". In the code, both docstring and the name didn't mention "General", it only mention at `note.add(self.genpage, 'General')`. That is why I got ambiguous when I

[issue31051] IDLE, configdialog, General tab: re-arrange, test user entries

Terry J. Reedy added the comment: Given that I picked the page names without discussion, as part of quickly writing and merging the switch to Notebook (PR (to unblock the FontPage and GenPage conversion), I considered them subject to possible revision. I expect to review both the internal

[issue31051] IDLE, configdialog, General tab: re-arrange, test user entries

Louie Lu added the comment: This may relate to #31050, I would like to propose to change the name `GenTab` to `GeneralTab`. `GenTab` is ambiguous to `GenerateTab` in the first glimpse. How do you think, Terry and Cheryl ? -- ___ Python tracker

[issue31051] IDLE, configdialog, General tab: re-arrange, test user entries

Terry J. Reedy added the comment: Common code in tests: test_helplist_item_actions functions have common code that could be factored out into a non-test_ method (especially if settings not needed for one of them is added, like setting anchor). The listbox simulated click code in

[issue31051] IDLE, configdialog, General tab: re-arrange, test user entries

Terry J. Reedy added the comment: In 31003, Cheryl pointed out that loading helplist could use enumerate. https://github.com/python/cpython/pull/2859#pullrequestreview-52461722 -- ___ Python tracker

[issue31051] IDLE, configdialog, General tab: re-arrange, test user entries

Terry J. Reedy added the comment: In comment for 31003, Cheryl pointed to https://stackoverflow.com/questions/4140437/interactively-validating-entry-widget-content-in-tkinter#4140988 That prompted me to grep for 'validatecommand'. "validatecommand=is_int" is used on the extension tab. The

[issue31051] IDLE, configdialog, General tab: re-arrange, test user entries

New submission from Terry J. Reedy: Fix bugs and enhance the page. The three little frames are too much, and in the wrong order. Proposal: Window to open at startup: O Shell O Editor Initial size:Width [_] Height [] When run code in editor: ... (see bpo-19042 for