[issue31160] Enhance support.reap_children()

Change by STINNER Victor : -- pull_requests: +18675 pull_request: https://github.com/python/cpython/pull/19312 ___ Python tracker ___

[issue31160] Enhance support.reap_children()

Change by Michael Felt : -- pull_requests: +18670 pull_request: https://github.com/python/cpython/pull/19308 ___ Python tracker ___

[issue31160] Enhance support.reap_children()

STINNER Victor added the comment: > Pablo Galindo opened bpo-40140, let's use this one. Note: Oops, Batuhan created it, Pablo only commented. -- ___ Python tracker ___

[issue31160] Enhance support.reap_children()

STINNER Victor added the comment: > Please open a new issue. This one is closed. Pablo Galindo opened bpo-40140, let's use this one. -- ___ Python tracker ___

[issue31160] Enhance support.reap_children()

STINNER Victor added the comment: > I think something is not yet what it needs to be: (...) https://buildbot.python.org/all/#/builders/227/builds/571 build failed but it has my commit 16d75675d2ad2454f6dfbf333c94e6237df36018. Ok, something failed. Please open a new issue. This one is

[issue31160] Enhance support.reap_children()

Michael Felt added the comment: I think something is not yet what it needs to be: the bots both finish test with: test_zip_pickle (test.test_builtin.BuiltinTest) ... ok Timeout (0:15:00)! Thread 0x0001 (most recent call first): File

[issue31160] Enhance support.reap_children()

Michael Felt added the comment: Ah - great. Sorry for the noise then. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue31160] Enhance support.reap_children()

STINNER Victor added the comment: > Ah - great. Sorry for the noise then. It's not noise, it is useful :-) -- ___ Python tracker ___

[issue31160] Enhance support.reap_children()

STINNER Victor added the comment: > With PR19263 The AIX bots are now red. I know, I saw and I already pushed fixes. > NameError: name 'signal' is not defined Fixed by commit afeaea2d6e346f627b24cc9e84e2986a7266a70e. > 1 test failed again: test_builtin Fixed by commit

[issue31160] Enhance support.reap_children()

Michael Felt added the comment: With PR19263 The AIX bots are now red. == ERROR: test_input_no_stdout_fileno (test.test_builtin.PtyTests) -- Traceback (most

[issue31160] Enhance support.reap_children()

STINNER Victor added the comment: New changeset 16d75675d2ad2454f6dfbf333c94e6237df36018 by Victor Stinner in branch 'master': bpo-31160: Fix race condition in test_os.PtyTests (GH-19263) https://github.com/python/cpython/commit/16d75675d2ad2454f6dfbf333c94e6237df36018 --

[issue31160] Enhance support.reap_children()

Change by STINNER Victor : -- pull_requests: +18619 pull_request: https://github.com/python/cpython/pull/19263 ___ Python tracker ___

[issue31160] Enhance support.reap_children()

STINNER Victor added the comment: I pushed the most important change: reap_children() now makes tests fail with ENV_CHANGED on warning, so I close the issue. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker

[issue31160] Enhance support.reap_children()

STINNER Victor added the comment: New changeset 1247e2cda514d7a73187e0b53ec8c35d87a34a84 by Victor Stinner in branch '2.7': [2.7] bpo-31160: Backport reap_children fixes from master to 2.7 (#3063) https://github.com/python/cpython/commit/1247e2cda514d7a73187e0b53ec8c35d87a34a84 --

[issue31160] Enhance support.reap_children()

Changes by STINNER Victor : -- pull_requests: +3097 ___ Python tracker ___ ___

[issue31160] Enhance support.reap_children()

STINNER Victor added the comment: New changeset 719a15b32587de6c4add4385ee3f84a20711340f by Victor Stinner in branch '3.6': [3.6] bpo-31160: Backport reap_children() fixes from master to 3.6 (#3060) https://github.com/python/cpython/commit/719a15b32587de6c4add4385ee3f84a20711340f --

[issue31160] Enhance support.reap_children()

Changes by STINNER Victor : -- pull_requests: +3095 ___ Python tracker ___ ___

[issue31160] Enhance support.reap_children()

STINNER Victor added the comment: bpo-31151 fixed test_socketserver. -- ___ Python tracker ___ ___

[issue31160] Enhance support.reap_children()

STINNER Victor added the comment: New changeset 6c8c2943d996b59a48d331f61f22cbe72933910e by Victor Stinner in branch 'master': bpo-31160: test_tempfile: Fix reap_children() warning (#3056) https://github.com/python/cpython/commit/6c8c2943d996b59a48d331f61f22cbe72933910e --

[issue31160] Enhance support.reap_children()

Changes by STINNER Victor : -- pull_requests: +3091 ___ Python tracker ___ ___

[issue31160] Enhance support.reap_children()

STINNER Victor added the comment: bpo-31173 fixed a leaked child process in test_subprocess. -- ___ Python tracker ___

[issue31160] Enhance support.reap_children()

STINNER Victor added the comment: > New changeset 4baca1b0f7325032598cd38e7ceffc79b616d255 by Victor Stinner in > branch 'master': > bpo-31160: Fix test_builtin for zombie process (#3043) This change introduced a regression:

[issue31160] Enhance support.reap_children()

Changes by STINNER Victor : -- pull_requests: +3080 ___ Python tracker ___ ___

[issue31160] Enhance support.reap_children()

STINNER Victor added the comment: New changeset da5e9301877346942fa4279612750d6a09e05153 by Victor Stinner in branch 'master': bpo-31160: Fix test_random for zombie process (#3045) https://github.com/python/cpython/commit/da5e9301877346942fa4279612750d6a09e05153 --

[issue31160] Enhance support.reap_children()

STINNER Victor added the comment: New changeset e3510d74aacc477c30f42f2b941d69689bbc478e by Victor Stinner in branch 'master': bpo-31160: regrtest now reaps child processes (#3044) https://github.com/python/cpython/commit/e3510d74aacc477c30f42f2b941d69689bbc478e --

[issue31160] Enhance support.reap_children()

STINNER Victor added the comment: New changeset 4baca1b0f7325032598cd38e7ceffc79b616d255 by Victor Stinner in branch 'master': bpo-31160: Fix test_builtin for zombie process (#3043) https://github.com/python/cpython/commit/4baca1b0f7325032598cd38e7ceffc79b616d255 --

[issue31160] Enhance support.reap_children()

Changes by STINNER Victor : -- pull_requests: +3079 ___ Python tracker ___ ___

[issue31160] Enhance support.reap_children()

Changes by STINNER Victor : -- pull_requests: +3078 ___ Python tracker ___ ___

[issue31160] Enhance support.reap_children()

Changes by STINNER Victor : -- pull_requests: +3077 ___ Python tracker ___ ___

[issue31160] Enhance support.reap_children()

Changes by STINNER Victor : -- pull_requests: +3074 ___ Python tracker ___ ___

[issue31160] Enhance support.reap_children()

STINNER Victor added the comment: A reap_children() warning was fixed in test_thread: bpo-31150. It seems like the commit 88eee44a91c991dbbdf284fa220e2928b5de105c was not enough to fix all warnings. -- ___ Python tracker

[issue31160] Enhance support.reap_children()

STINNER Victor added the comment: > The GCC job of Travis CI failed with ENV_CHANGED: Ooops, in fact it was a macOS job: https://travis-ci.org/python/cpython/jobs/262606830 The GCC job failed with much more errors: https://travis-ci.org/python/cpython/jobs/262606831 --- 0:00:02 load avg:

[issue31160] Enhance support.reap_children()

STINNER Victor added the comment: The GCC job of Travis CI failed with ENV_CHANGED: Test wait() behavior when waitpid returns WIFSTOPPED; issue29335. ... Warning -- reap_children() reaped child process 19839 ok I tested and... WOW! When run in a loop, this test leaks 100 MB per second. It

[issue31160] Enhance support.reap_children()

New submission from STINNER Victor: Attached PR enhances the support.reap_children() function: * reap_children() now sets environment_altered to True to detect bugs using python3 -m test --fail-env-changed * Replace bare "except:" with "except OSError:" in reap_children() * Write an unit test