[issue31185] Miscellaneous errors in asyncio speedup module

Chris Jerdonek added the comment: FYI, there is a missing Py_DECREF from this change: https://bugs.python.org/issue40559 (though it's an obscure code path as mentioned elsewhere in these comments) -- nosy: +chris.jerdonek ___ Python tracker

[issue31185] Miscellaneous errors in asyncio speedup module

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue31185] Miscellaneous errors in asyncio speedup module

Serhiy Storchaka added the comment: New changeset 98bbeb78e06d5756491705920e72f9721850c727 by Serhiy Storchaka in branch '3.6': bpo-31185: Fixed miscellaneous errors in asyncio speedup module. (#3076) (#3269) https://github.com/python/cpython/commit/98bbeb78e06d5756491705920e72f9721850c727

[issue31185] Miscellaneous errors in asyncio speedup module

Changes by Serhiy Storchaka : -- pull_requests: +3313 ___ Python tracker ___ ___

[issue31185] Miscellaneous errors in asyncio speedup module

Serhiy Storchaka added the comment: New changeset bca4939d806170c3ca5d05f23710d11a8f1669cf by Serhiy Storchaka in branch 'master': bpo-31185: Fixed miscellaneous errors in asyncio speedup module. (#3076) https://github.com/python/cpython/commit/bca4939d806170c3ca5d05f23710d11a8f1669cf

[issue31185] Miscellaneous errors in asyncio speedup module

Serhiy Storchaka added the comment: They are occurred in very obscure cases like calling __init__ multiple times. The patch doesn't contain tests for them. -- ___ Python tracker

[issue31185] Miscellaneous errors in asyncio speedup module

Yury Selivanov added the comment: > "reference leaks" oh? our Refleaks buildbots didn't catch them. The test suite for Tasks and Futures is pretty extensive, but it obviously doesn't cover some obscure use cases. +1 to make sure that any refleak that was discovered should have a new

[issue31185] Miscellaneous errors in asyncio speedup module

STINNER Victor added the comment: "reference leaks" oh? our Refleaks buildbots didn't catch them. Do your new tests reproduce the bugs, to make sure that we don't leak anymore? -- ___ Python tracker

[issue31185] Miscellaneous errors in asyncio speedup module

Yury Selivanov added the comment: Huge thanks, Serhiy, btw. -- ___ Python tracker ___ ___ Python-bugs-list

[issue31185] Miscellaneous errors in asyncio speedup module

Yury Selivanov added the comment: Adding INADA, he is a co-author/reviewer of that code. -- nosy: +inada.naoki ___ Python tracker ___

[issue31185] Miscellaneous errors in asyncio speedup module

Changes by Serhiy Storchaka : -- pull_requests: +3113 ___ Python tracker ___ ___

[issue31185] Miscellaneous errors in asyncio speedup module

New submission from Serhiy Storchaka: Proposed patch fixes miscellaneous errors in asyncio speedup module. It is hard to enumerate they all, but they are mostly NULL dereferencing, reference leaks, and handling exceptions in corner cases. -- components: Extension Modules, asyncio