[issue31333] Implement ABCMeta in C

miss-islington added the comment: New changeset 034a945fa723bf68ca4127bb43bfa5c5be899f17 by Miss Islington (bot) in branch '3.7': bpo-31333: Fix typo in whatsnew/3.7.rst (GH-5744)

[issue31333] Implement ABCMeta in C

Change by miss-islington : -- pull_requests: +5522 ___ Python tracker ___

[issue31333] Implement ABCMeta in C

Ivan Levkivskyi added the comment: New changeset 3fb813d2c67fe28cc98ae51e53a6890294b6e423 by Ivan Levkivskyi (Terry Jan Reedy) in branch 'master': bpo-31333: Fix typo in whatsnew/3.7.rst (GH-5744)

[issue31333] Implement ABCMeta in C

Terry J. Reedy added the comment: PR fixes typo in What's new: rewrittent -- nosy: +terry.reedy ___ Python tracker ___

[issue31333] Implement ABCMeta in C

Change by Terry J. Reedy : -- pull_requests: +5521 ___ Python tracker ___ ___

[issue31333] Implement ABCMeta in C

Guido van Rossum added the comment: Congratulations all on this milestone! And thanks reviewers for your thorough work. -- ___ Python tracker

[issue31333] Implement ABCMeta in C

Ivan Levkivskyi added the comment: New changeset 38928992885d8a04b7188abdba3b04f350bde32d by Ivan Levkivskyi in branch '3.7': bpo-31333: Re-implement ABCMeta in C (GH-5733) https://github.com/python/cpython/commit/38928992885d8a04b7188abdba3b04f350bde32d --

[issue31333] Implement ABCMeta in C

Change by Ivan Levkivskyi : -- pull_requests: +5514 ___ Python tracker ___ ___

[issue31333] Implement ABCMeta in C

Change by Ivan Levkivskyi : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue31333] Implement ABCMeta in C

Ivan Levkivskyi added the comment: New changeset 03e3c340a0156891a036d6dbdb9e348108826255 by Ivan Levkivskyi in branch 'master': bpo-31333: Re-implement ABCMeta in C (#5273) https://github.com/python/cpython/commit/03e3c340a0156891a036d6dbdb9e348108826255 --

[issue31333] Implement ABCMeta in C

Guido van Rossum added the comment: > Isn't 800 lines of C code too high price for speeding up ABCs creation? I think it's well worth it. This has long felt as a sore point to me. On Sat, Feb 17, 2018 at 10:27 AM, Ivan Levkivskyi wrote: > > Ivan

[issue31333] Implement ABCMeta in C

Ivan Levkivskyi added the comment: > Isn't 800 lines of C code too high price for speeding up ABCs creation? 800 lines of C code is not something hard to notice, so I suppose the answer is obvious for all people involved in the work on PR :-) > ...this can save just

[issue31333] Implement ABCMeta in C

Serhiy Storchaka added the comment: Isn't 800 lines of C code too high price for speeding up ABCs creation? This will save several microseconds per ABC creation. Even if the program creates 1000 ABCs, this can save just several milliseconds at start-up.

[issue31333] Implement ABCMeta in C

Yury Selivanov added the comment: > Let's try to get it in as soon as we can, please! Thank you, Ned! We'll get it merged in the next few days. -- ___ Python tracker

[issue31333] Implement ABCMeta in C

Ned Deily added the comment: There has been a lot of work by a number of people on this feature leading up to the 3.7.0b1. Thank you! On PR 5273, Yury says that he believes the feature is ready to merge but would prefer an extension until 3.7.0b2 and that Guido has agreed.

[issue31333] Implement ABCMeta in C

Change by Ivan Levkivskyi : -- keywords: +patch pull_requests: +5117 stage: -> patch review ___ Python tracker ___

[issue31333] Implement ABCMeta in C

INADA Naoki added the comment: "python_startup_nosite" benchmark imports io module, and "python_startup" benchmark imports os too. So no need to additional test for them. You can see it with `python -v -S -c 'pass'` and `python -v -c 'pass'`. -- ___

[issue31333] Implement ABCMeta in C

Stefan Behnel added the comment: Since the number of applications that get along without any file access is probably close to irrelevant, "os" and "io" feel like sufficiently widely used modules to merit being part of a "usual Python startup" benchmark. Maybe we should add one to the

[issue31333] Implement ABCMeta in C

INADA Naoki added the comment: > Hm, indeed, but I see that module 'abc' is in 'sys.modules', probably it is > then only used by 'collections.abc'/'_collections_abc'. This means that the > influence of 'ABCMeta' on interpreter start-up time will be smaller than I > thought. But still start-up

[issue31333] Implement ABCMeta in C

Guido van Rossum added the comment: I've heard many anecdotal complaints about the lack of speed of ABCs. Even if it doesn't affect core Python startup, it does affect startup of apps, and if people are afraid to use them because of this, it's reasonable to try to do something about it.

[issue31333] Implement ABCMeta in C

Changes by Raymond Hettinger : -- nosy: +gvanrossum ___ Python tracker ___ ___

[issue31333] Implement ABCMeta in C

Ivan Levkivskyi added the comment: Eric, > the only ABCs in importlib are in importlib.abc (and used by importlib.util). > This does not impact interpreter startup. Hm, indeed, but I see that module 'abc' is in 'sys.modules', probably it is then only used by

[issue31333] Implement ABCMeta in C

Eric Snow added the comment: > This mostly influences the Python interpreter start-up time > (because of extensive use of ABCs in importlib) Just to be clear, the only ABCs in importlib are in importlib.abc (and used by importlib.util). This does not impact interpreter startup. --

[issue31333] Implement ABCMeta in C

Changes by Aaron Hall : -- nosy: +Aaron Hall ___ Python tracker ___ ___

[issue31333] Implement ABCMeta in C

Changes by Ivan Levkivskyi : -- nosy: +brett.cannon, haypo, serhiy.storchaka, yselivanov ___ Python tracker ___

[issue31333] Implement ABCMeta in C

New submission from Ivan Levkivskyi: The idea is that creating ABCs is approximately twice slower than normal classes. Plus there are smaller penalties for various operations with ABCs. This mostly influences the Python interpreter start-up time (because of extensive use of ABCs in