[issue31351] ensurepip discards pip's return code which leads to broken venvs

Igor Filatov added the comment: Thanks for the reviews, Nick! -- ___ Python tracker ___ ___ Python-bugs-list

[issue31351] ensurepip discards pip's return code which leads to broken venvs

Nick Coghlan added the comment: And done - thanks for the report and PRs, Igor! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue31351] ensurepip discards pip's return code which leads to broken venvs

Nick Coghlan added the comment: New changeset cf7197ae43767c4346864e5b41246f628edd9b51 by Nick Coghlan (Igor Filatov) in branch '2.7': [2.7] bpo-31351: Set return code in ensurepip when pip fails (GH-3734) https://github.com/python/cpython/commit/cf7197ae43767c4346864e5b41246f628edd9b51

[issue31351] ensurepip discards pip's return code which leads to broken venvs

Changes by Igor Filatov : -- pull_requests: +3720 stage: backport needed -> patch review ___ Python tracker ___

[issue31351] ensurepip discards pip's return code which leads to broken venvs

Mariatta Wijaya added the comment: Thanks :) Since Miss Islington couldn't backport this, I'll leave it to the patch author or the core dev who merged the PR ;) -- ___ Python tracker

[issue31351] ensurepip discards pip's return code which leads to broken venvs

Nick Coghlan added the comment: Aye, it is - while there's no venv integration in 2.7 (since there's no venv module), ensurepip itself is essentially identical across the two version, so 2.7 will suffer from the same problem. -- stage: patch review -> backport needed versions:

[issue31351] ensurepip discards pip's return code which leads to broken venvs

Mariatta Wijaya added the comment: This has been backported to 3.6. Is backport to 2.7 needed? -- ___ Python tracker ___

[issue31351] ensurepip discards pip's return code which leads to broken venvs

Mariatta Wijaya added the comment: New changeset eef49f5dd021d15396551880cf451042a79a1107 by Mariatta (Miss Islington (bot)) in branch '3.6': bpo-31351: Set return code in ensurepip when pip fails (GH-3626) (GH-3683)

[issue31351] ensurepip discards pip's return code which leads to broken venvs

Changes by Roundup Robot : -- pull_requests: +3672 stage: commit review -> patch review ___ Python tracker ___

[issue31351] ensurepip discards pip's return code which leads to broken venvs

Nick Coghlan added the comment: New changeset 9adda0cdf89432386b7a0a6199b580d287a1 by Nick Coghlan (Igor Filatov) in branch 'master': bpo-31351: Set return code in ensurepip when pip fails (GH-3626) https://github.com/python/cpython/commit/9adda0cdf89432386b7a0a6199b580d287a1

[issue31351] ensurepip discards pip's return code which leads to broken venvs

Nick Coghlan added the comment: 3.4 and 3.5 are in security fix only mode now, so the change won't be backported there. However, it will be applicable to 2.7, so I've updated the impacted version list accordingly. Igor's suggested approach in the PR looks reasonable to me as a first step, as

[issue31351] ensurepip discards pip's return code which leads to broken venvs

Changes by Ned Deily : -- nosy: +dstufft, ncoghlan ___ Python tracker ___ ___

[issue31351] ensurepip discards pip's return code which leads to broken venvs

Martin Vielsmaier added the comment: I guess this is also the root cause for the problem I reported on virtualenv: https://github.com/pypa/virtualenv/issues/1074 -- nosy: +Martin Vielsmaier ___ Python tracker

[issue31351] ensurepip discards pip's return code which leads to broken venvs

Changes by Igor Filatov : -- keywords: +patch pull_requests: +3615 stage: -> patch review ___ Python tracker ___

[issue31351] ensurepip discards pip's return code which leads to broken venvs

New submission from Igor Filatov: ensurepip runs pip with a function that discards the result code that pip produces: def _run_pip(args, additional_paths=None): # ... pip.main(args) pip.main() is designed not to raise command exceptions. Instead it returns exit codes