[issue31835] _PyFunction_FastCallDict and _PyFunction_FastCallKeywords: fast path not used

Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue31835] _PyFunction_FastCallDict and _PyFunction_FastCallKeywords: fast path not used

STINNER Victor added the comment: Thank you Anselm Kruis for spotting this nice optimization opportunity! Sadly, as I wrote, I don't want to backport the optimization to the stable Python 3.6 branch. -- ___ Python tracker

[issue31835] _PyFunction_FastCallDict and _PyFunction_FastCallKeywords: fast path not used

STINNER Victor added the comment: New changeset 086c3ae5f0995a62092b9080f32dd118c2923453 by Victor Stinner in branch 'master': bpo-31835: Optimize also FASTCALL using __future__ (#4087) https://github.com/python/cpython/commit/086c3ae5f0995a62092b9080f32dd118c2923453

[issue31835] _PyFunction_FastCallDict and _PyFunction_FastCallKeywords: fast path not used

STINNER Victor added the comment: I reset Versions to Python 3.7. I don't consider this issue as a bug, but only as a new optimization. So it can only go into the future Python 3.7. -- versions: -Python 2.7, Python 3.6

[issue31835] _PyFunction_FastCallDict and _PyFunction_FastCallKeywords: fast path not used

STINNER Victor added the comment: > The fix is simple. Replace the faulty sub-expression by > (co->co_flags & (~PyCF_MASK)) == (CO_OPTIMIZED | CO_NEWLOCALS | CO_NOFREE)) I proposed PR 4087 to implement this optimization. I wouldn't call it a "fix", since the

[issue31835] _PyFunction_FastCallDict and _PyFunction_FastCallKeywords: fast path not used

Change by STINNER Victor : -- keywords: +patch pull_requests: +4057 stage: -> patch review ___ Python tracker ___

[issue31835] _PyFunction_FastCallDict and _PyFunction_FastCallKeywords: fast path not used

Change by Antoine Pitrou : -- nosy: +haypo versions: +Python 3.7 ___ Python tracker ___ ___

[issue31835] _PyFunction_FastCallDict and _PyFunction_FastCallKeywords: fast path not used

New submission from Anselm Kruis : Just a minor performance issue. The C functions _PyFunction_FastCallDict() and _PyFunction_FastCallKeywords() (branch 'master', Objects/call.c) and their predecessors fast_function() and _PyFunction_FastCallDict() in