[issue31908] trace module cli does not write cover files

Berker Peksag added the comment: New changeset 8fc21c80af73226de875886132e0c32a4ffb32c5 by Berker Peksag (Miss Islington (bot)) in branch '3.7': bpo-26818: Add a test to make sure the bug is fixed (GH-8664) https://github.com/python/cpython/commit/8fc21c80af73226de875886132e0c32a4ffb32c5

[issue31908] trace module cli does not write cover files

Change by miss-islington : -- pull_requests: +8219 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31908] trace module cli does not write cover files

Berker Peksag added the comment: New changeset c8b0dbc4928a1fe4bd5abebd810b6849374c7af3 by Berker Peksag in branch 'master': bpo-26818: Add a test to make sure the bug is fixed (GH-8664) https://github.com/python/cpython/commit/c8b0dbc4928a1fe4bd5abebd810b6849374c7af3 --

[issue31908] trace module cli does not write cover files

Change by Berker Peksag : -- pull_requests: +8160 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31908] trace module cli does not write cover files

Zackery Spytz added the comment: This change causes test_trace to leave a trace.cover file in the Lib directory (see #34171). -- nosy: +ZackerySpytz ___ Python tracker ___

[issue31908] trace module cli does not write cover files

miss-islington added the comment: New changeset a607f8b9982ac95bb59f8f61e0a50fc5ae29dc14 by Miss Islington (bot) in branch '3.6': bpo-31908: Fix output of cover files for trace module command-line tool. (GH-4205)

[issue31908] trace module cli does not write cover files

Change by miss-islington : -- pull_requests: +6362 ___ Python tracker ___

[issue31908] trace module cli does not write cover files

miss-islington added the comment: New changeset e4eeb6eff12947a55df5eabee36e537cadefbbac by Miss Islington (bot) in branch '3.7': bpo-31908: Fix output of cover files for trace module command-line tool. (GH-4205)

[issue31908] trace module cli does not write cover files

Change by miss-islington : -- pull_requests: +6361 ___ Python tracker ___

[issue31908] trace module cli does not write cover files

Change by miss-islington : -- pull_requests: +6360 ___ Python tracker ___

[issue31908] trace module cli does not write cover files

Serhiy Storchaka added the comment: New changeset 47ab15470d72367694d7758004067313ae022f0e by Serhiy Storchaka (Michael Selik) in branch 'master': bpo-31908: Fix output of cover files for trace module command-line tool. (GH-4205)

[issue31908] trace module cli does not write cover files

Michael Selik added the comment: You're referring to something like this: +def test_count_and_summary(self): +name = TESTFN + '.py' +with open(name, 'w') as fd: +self.addCleanup(unlink, name) +fd.write("""\ +x = 1 +y = 2 + +def f(): +

[issue31908] trace module cli does not write cover files

Change by Michael Selik : -- nosy: +selik ___ Python tracker ___ ___ Python-bugs-list

[issue31908] trace module cli does not write cover files

Berker Peksag added the comment: I think the first part of your patch also fixes issue 26818. Could you adapt the test there and add a test case for the problem in this issue? -- nosy: +berker.peksag versions: -Python 3.5

[issue31908] trace module cli does not write cover files

Change by Raymond Hettinger : -- nosy: +belopolsky ___ Python tracker ___ ___

[issue31908] trace module cli does not write cover files

Michael Selik added the comment: Ok, pull request submitted: https://github.com/python/cpython/pull/4205 -- ___ Python tracker

[issue31908] trace module cli does not write cover files

Change by Michael Selik : -- keywords: +patch pull_requests: +4174 stage: -> patch review ___ Python tracker ___

[issue31908] trace module cli does not write cover files

Michael Selik added the comment: While writing a patch for this, I noticed the ``lnotab`` parameter seems nearly unused. It's a dict, but is only used for its keys. https://github.com/python/cpython/blob/master/Lib/trace.py#L333 Further, the choice to count unreached

[issue31908] trace module cli does not write cover files

Michael Selik added the comment: The problem appears to be a mistake in commit f026dae130bf6f9015c4b212f16852ba4a3f3dec https://github.com/python/cpython/commit/f026dae130bf6f9015c4b212f16852ba4a3f3dec This made the writing of cover files conditional on

[issue31908] trace module cli does not write cover files

Raymond Hettinger added the comment: It worked in Python 3.4, but not afterwards. -- components: +Library (Lib) nosy: +rhettinger versions: +Python 3.5, Python 3.7 ___ Python tracker

[issue31908] trace module cli does not write cover files

New submission from Michael Selik : The trace module command-line utility doesn't write cover files. I've noticed this issue for some years now. It works fine in Python 2. When using Python 3, no ".cover" files are written, regardless of how "--coverdir" is specified.