[issue32075] Expose ZipImporter Type Object in the include header files.

2018-09-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: zipimport have been rewritten in pure Python (issue25711). -- resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue32075] Expose ZipImporter Type Object in the include header files.

2017-11-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The C API cann't be changed in a bugfix release. Unless for fixing bugs, but even in that case we should be very very careful. There is no a bug. -- ___ Python tracker

[issue32075] Expose ZipImporter Type Object in the include header files.

2017-11-20 Thread Decorater
Decorater added the comment: Well since issue25711 might be for 3.7 and newer I guess this patch might actually be for 3.6.4 or something then. And then the rewrite would take over on 3.7 and newer depending on if the rewrite makes it in to 3.7. -- versions:

[issue32075] Expose ZipImporter Type Object in the include header files.

2017-11-20 Thread Decorater
Decorater added the comment: That is true, but Well, I am using this in a project of mine currently where it loads up encrypted scripts from a zip file. However I must have the import hook itself be in an C extension and subclass the current zipimporter. However

[issue32075] Expose ZipImporter Type Object in the include header files.

2017-11-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There is a plan of reimplementing zipimport in Python (see issue25711). What are you going to do with this? I think that C extensions should use a common import API. -- nosy: +brett.cannon, eric.snow, ncoghlan,

[issue32075] Expose ZipImporter Type Object in the include header files.

2017-11-19 Thread Decorater
Change by Decorater : -- assignee: -> docs@python components: +Build, Documentation nosy: +docs@python ___ Python tracker ___

[issue32075] Expose ZipImporter Type Object in the include header files.

2017-11-19 Thread Decorater
Decorater added the comment: After looking in the smelly tool it seems that now I got to rename the _Type to ZipImporter to have the ``Py`` prefix. Since this will be a probable breaking change this might not be a good idea on backporting to 3.6. --

[issue32075] Expose ZipImporter Type Object in the include header files.

2017-11-19 Thread Decorater
Change by Decorater : -- versions: -Python 3.6 ___ Python tracker ___ ___

[issue32075] Expose ZipImporter Type Object in the include header files.

2017-11-19 Thread Decorater
Decorater added the comment: Seems that now this is detected as an smelly symbol: ./python Tools/scripts/smelly.py + nm -p libpython3.7dm.a Ignored symbol types: b, d, r, t Smelly symbol: ZipImporter_Type (type: D) ERROR: Found 1 smelly symbols! make: *** [smelly] Error

[issue32075] Expose ZipImporter Type Object in the include header files.

2017-11-19 Thread Decorater
Change by Decorater : -- type: -> behavior ___ Python tracker ___ ___

[issue32075] Expose ZipImporter Type Object in the include header files.

2017-11-19 Thread Decorater
Change by Decorater : -- keywords: +patch pull_requests: +4402 stage: -> patch review ___ Python tracker ___

[issue32075] Expose ZipImporter Type Object in the include header files.

2017-11-19 Thread Decorater
New submission from Decorater : I would like to make an C extension module which basically would have the ZipImporter type defined in the ``zipimport.c`` which defines most things related to ZipImporter to be public so that way one can set it to ``.tp_base`` on their C