[issue32157] Remove explicit quotes around %r and {!r}

2017-11-28 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue32157] Remove explicit quotes around %r and {!r}

2017-11-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset a4a3020abc065d40f57069d6c69d0ddc85d6 by Serhiy Storchaka in branch 'master': bpo-32157: Removed explicit quotes around %r and {!r}. (#4582)

[issue32157] Remove explicit quotes around %r and {!r}

2017-11-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Yes, these are the only instances of quotes used with %r or {!r}. -- ___ Python tracker

[issue32157] Remove explicit quotes around %r and {!r}

2017-11-28 Thread Ethan Furman
Change by Ethan Furman : -- Removed message: https://bugs.python.org/msg307149 ___ Python tracker ___

[issue32157] Remove explicit quotes around %r and {!r}

2017-11-28 Thread Ethan Furman
Ethan Furman added the comment: Yup, I sure did. :/ Looks like a good change to me. Are these the only instances of quotes used with %r? -- ___ Python tracker

[issue32157] Remove explicit quotes around %r and {!r}

2017-11-28 Thread Yury Selivanov
Change by Yury Selivanov : -- nosy: -yselivanov ___ Python tracker ___ ___

[issue32157] Remove explicit quotes around %r and {!r}

2017-11-28 Thread Antoine Pitrou
Antoine Pitrou added the comment: Ethan, I think you misunderstood Serhiy's proposal. -- ___ Python tracker ___

[issue32157] Remove explicit quotes around %r and {!r}

2017-11-28 Thread Ethan Furman
Ethan Furman added the comment: I make sure to use %r in error-reporting and debugging messages precisely because it's output is (usually) valid python. If I see a 1 without quotes I know it's a number, and with quotes I know it's a string. -1 -- nosy:

[issue32157] Remove explicit quotes around %r and {!r}

2017-11-28 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : It is common to use quotes around %s. If the formatted argument is a string this will produce a string in qoutes, that look as a string literal in Python and other programming languages or just as a quoted string in English.

[issue32157] Remove explicit quotes around %r and {!r}

2017-11-28 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +4530 ___ Python tracker ___