[issue32197] Compiling against master branch fails; error: expected expression SET_DECODE_ERROR

Sanyam Khurana added the comment: Hey Victor, thanks for the update. I was confused about how the macro was replaced in the previous version. -- ___ Python tracker

[issue32197] Compiling against master branch fails; error: expected expression SET_DECODE_ERROR

STINNER Victor added the comment: I tested manually that compilation and tests succeed on macOS. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue32197] Compiling against master branch fails; error: expected expression SET_DECODE_ERROR

STINNER Victor added the comment: Oh sorry, I missed the macOS failure and I wasn't available last week-end for quickly fix it. So thanks Serhiy for the revert ;-) I reapplied my changes with the following fix. test_embed randomly failed, but it's unrelated (I was

[issue32197] Compiling against master branch fails; error: expected expression SET_DECODE_ERROR

STINNER Victor added the comment: New changeset 31a8393cf6a74c870c3484dd68500619f6232c6d by Victor Stinner in branch 'master': Revert "bpo-32197: Try to fix a compiler error on OS X introduced in bpo-32030. (#4681)" (#4694)

[issue32197] Compiling against master branch fails; error: expected expression SET_DECODE_ERROR

Change by STINNER Victor : -- pull_requests: +4606 ___ Python tracker ___ ___

[issue32197] Compiling against master branch fails; error: expected expression SET_DECODE_ERROR

Serhiy Storchaka added the comment: New changeset 13badcbc60cdbfae1dba1683fd2fae9d70717143 by Serhiy Storchaka in branch 'master': bpo-32197: Try to fix a compiler error on OS X introduced in bpo-32030. (#4681)

[issue32197] Compiling against master branch fails; error: expected expression SET_DECODE_ERROR

Change by Serhiy Storchaka : -- pull_requests: +4592 ___ Python tracker ___ ___

[issue32197] Compiling against master branch fails; error: expected expression SET_DECODE_ERROR

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +4590 stage: -> patch review ___ Python tracker ___

[issue32197] Compiling against master branch fails; error: expected expression SET_DECODE_ERROR

Sanyam Khurana added the comment: Even a simple use of ternary operator instead of using if-else inside do-while to handle the macro like: #define SET_DECODE_ERROR(NAME, LEN) \ pymain->err = ((LEN) == (size_t)-2) \ ? _Py_INIT_USER_ERR("cannot decode "

[issue32197] Compiling against master branch fails; error: expected expression SET_DECODE_ERROR

Sanyam Khurana added the comment: I tried to resolve the issue by trying to figure out the syntax for the SET_DECODE_ERROR macro. I tried to call a function from the macro, and eventually do the checking in that function. Second way I tried was to replace

[issue32197] Compiling against master branch fails; error: expected expression SET_DECODE_ERROR

Sanyam Khurana added the comment: I used git bisect to track down the commit that broke the build. Seems like this is the SHA: ebac19dad6263141d5db0a2c923efe049dba99d2 ebac19dad6263141d5db0a2c923efe049dba99d2 is the first bad commit commit

[issue32197] Compiling against master branch fails; error: expected expression SET_DECODE_ERROR

Change by Serhiy Storchaka : -- nosy: +vstinner type: crash -> compile error ___ Python tracker ___

[issue32197] Compiling against master branch fails; error: expected expression SET_DECODE_ERROR

New submission from Sanyam Khurana : The current master branch at commit af5a895073c24637c094772b27526b94a12ec897 fails while building the interpreter. The following is the traceback while running `make` after `./configure --with-pydebug` gcc -c -Wno-unused-result