[issue32493] UUID Module - FreeBSD build failure

STINNER Victor added the comment: > Would it be easier to split it into 3 issues? One for unixdll, one for > netstat, and one for test_uuid? One issue for AIX should be enough. -- ___ Python tracker

[issue32493] UUID Module - FreeBSD build failure

Michael Felt added the comment: I was not aware that _uuid was new to python3-3.7. I thought it had been around for a long time. Bpo-28009 goes back two years and i was unaware of uuid_create(). Would it be easier to split it into 3 issues? One for unixdll, one for netstat, and one for

[issue32493] UUID Module - FreeBSD build failure

STINNER Victor added the comment: > As noted on PR 7511 and PR 7567, I have merged Michael's configure.ac fixes > for testing for uuid_enc_be availability (independent of platform) that were > incorrect in earlier commits for this issue. Merged for 3.7.0rc1 and master > (3.8). Thanks,

[issue32493] UUID Module - FreeBSD build failure

Ned Deily added the comment: As noted on PR 7511 and PR 7567, I have merged Michael's configure.ac fixes for testing for uuid_enc_be availability (independent of platform) that were incorrect in earlier commits for this issue. Merged for 3.7.0rc1 and master (3.8). Thanks, everyone!

[issue32493] UUID Module - FreeBSD build failure

Ned Deily added the comment: New changeset ced0adb2638e4c02945bfa82e15595918eef74f1 by Ned Deily in branch 'master': bpo-32493: Correct test for uuid_enc_be availability in configure.ac. (GH-7511) (GH-7567) https://github.com/python/cpython/commit/ced0adb2638e4c02945bfa82e15595918eef74f1

[issue32493] UUID Module - FreeBSD build failure

Change by Ned Deily : -- pull_requests: +7198 stage: resolved -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing

[issue32493] UUID Module - FreeBSD build failure

Ned Deily added the comment: New changeset 20cd5c6e21559f35feded5b3cfa9069a281d4325 by Ned Deily (Michael Felt) in branch '3.7': bpo-32493: Correct test for uuid_enc_be availability in configure.ac. (GH-7511) https://github.com/python/cpython/commit/20cd5c6e21559f35feded5b3cfa9069a281d4325

[issue32493] UUID Module - FreeBSD build failure

Michael Felt added the comment: OK. I know I do not understand this well - when it goes in A, or B. So, if I understand correctly, like this issue was created after uuid_create() was added for AIX and created issues for FreeBSD )that I did not know had uuid_create(), I need to create a new

[issue32493] UUID Module - FreeBSD build failure

STINNER Victor added the comment: > @vstinner - I know this is "closed", however, I submit a minor PR to fix an > error in PR7104. The logic of configure.ac always defines HAVE_UUID_ENC_BE. I > cannot proceed with PR5183 (aka issue28009) until this is repaired. The title of this issue makes

[issue32493] UUID Module - FreeBSD build failure

Michael Felt added the comment: @vstinner - I know this is "closed", however, I submit a minor PR to fix an error in PR7104. The logic of configure.ac always defines HAVE_UUID_ENC_BE. I cannot proceed with PR5183 (aka issue28009) until this is repaired. Thx! --

[issue32493] UUID Module - FreeBSD build failure

Change by Michael Felt : -- pull_requests: +7139 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32493] UUID Module - FreeBSD build failure

Change by Michael Felt : -- pull_requests: +7082 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32493] UUID Module - FreeBSD build failure

Change by Ned Deily : -- priority: deferred blocker -> ___ Python tracker ___ ___

[issue32493] UUID Module - FreeBSD build failure

STINNER Victor added the comment: Thank you Serhiy Storchaka for the fix! If someone cares about AIX, please open a different issue. (AIX has other more important functions that you be fixed, IHMO.) -- resolution: -> fixed stage: patch review -> resolved status:

[issue32493] UUID Module - FreeBSD build failure

miss-islington added the comment: New changeset 5734f41a9b46b4fd65b6ba90240b108f8a0b7c57 by Miss Islington (bot) in branch '3.7': bpo-32493: Fix uuid.uuid1() on FreeBSD. (GH-7099)

[issue32493] UUID Module - FreeBSD build failure

Change by miss-islington : -- pull_requests: +6743 ___ Python tracker ___

[issue32493] UUID Module - FreeBSD build failure

STINNER Victor added the comment: New changeset 17d8830312d82e7de42ab89739b0771f712645ff by Victor Stinner (Serhiy Storchaka) in branch 'master': bpo-32493: Fix uuid.uuid1() on FreeBSD. (GH-7099)

[issue32493] UUID Module - FreeBSD build failure

Serhiy Storchaka added the comment: PR 7099 is an alternate solution. I uses uuid_enc_be() which is not part of the DCE 1.1 RPC specification but exists on all *BSD. Both solutions gives the same result on *BSD and AIX. I have no idea what solution is

[issue32493] UUID Module - FreeBSD build failure

Change by Serhiy Storchaka : -- pull_requests: +6736 ___ Python tracker ___ ___

[issue32493] UUID Module - FreeBSD build failure

Change by Serhiy Storchaka : -- stage: needs patch -> patch review ___ Python tracker ___

[issue32493] UUID Module - FreeBSD build failure

Serhiy Storchaka added the comment: Is AIX big-endian? On *BSD systems uuid_t is a structure of integers with platform-depending endianess. Thus on little-endian platform UUID should be called with the bytes_le argument. This doesn't fix test on OpenBSD and

[issue32493] UUID Module - FreeBSD build failure

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +6735 stage: needs patch -> patch review ___ Python tracker

[issue32493] UUID Module - FreeBSD build failure

Serhiy Storchaka added the comment: I will be busy next few hours, but will take this issue as soon as I can. However I do not promise the result. -- ___ Python tracker

[issue32493] UUID Module - FreeBSD build failure

Ned Deily added the comment: This problem is still unresolved and causing buildbot failures. It really should be fixed before we tag 3.7.0rc1. Serhiy, could you take a look at it, please? Thanks! http://buildbot.python.org/all/#/builders/87/builds/1014/steps/4/logs/stdio

[issue32493] UUID Module - FreeBSD build failure

Michael Felt added the comment: oops, sain openbsd, should be freebsd -- ___ Python tracker ___

[issue32493] UUID Module - FreeBSD build failure

Michael Felt added the comment: If it is a bug in OpenBSD how do you propose we "fix" this. imho, the problem is "outside" python. however, until it is fixed in openbsd, would you accept an 3error macro that prevents the mod from being built on the specific version of

[issue32493] UUID Module - FreeBSD build failure

Ned Deily added the comment: We are still seeing the 3.7 and 3.8 FreeBSD buildbot failures Victor identified in msg310147. Can someone please take this on and produce a PR? -- nosy: +ned.deily priority: normal -> deferred blocker versions: +Python 3.8

[issue32493] UUID Module - FreeBSD build failure

Change by Kubilay Kocak : -- stage: resolved -> needs patch ___ Python tracker ___

[issue32493] UUID Module - FreeBSD build failure

David CARLIER added the comment: Probably. Seems workable under Apple otherwise. -- ___ Python tracker ___

[issue32493] UUID Module - FreeBSD build failure

Michael Felt added the comment: Now that it is visible - maybe OpenBSD will treat it as a bug and get the "version bits" to work as their man page (https://man.openbsd.org/uuid.3) says it does: STANDARDS The

[issue32493] UUID Module - FreeBSD build failure

Change by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list

[issue32493] UUID Module - FreeBSD build failure

David CARLIER added the comment: In OpenBSD it s even "worse", the version for each call is random (not a surprise when looking at the source). The question is, do we go back to support only AIX or do we accept somehow wrong version ? --

[issue32493] UUID Module - FreeBSD build failure

Michael Felt added the comment: On 1/17/2018 11:16 AM, David CARLIER wrote: > David CARLIER added the comment: > > Might comes from uuid1 function itself ... e.g. line 704 not setting version > "field". IMHO: for uuid1 - the version number should be

[issue32493] UUID Module - FreeBSD build failure

David CARLIER added the comment: Gives same outcome but maybe someone else can confir, -- ___ Python tracker ___

[issue32493] UUID Module - FreeBSD build failure

David CARLIER added the comment: uuid_create only I think. -- ___ Python tracker ___

[issue32493] UUID Module - FreeBSD build failure

Michael Felt added the comment: typo here: So, I think the AMD64 FreeBSD 10.x Shared 3.x uuid_create() function is wrong (if that is what it is using - was it/can it also use the uuid_generate* routines? i.e., does AMD FreeBSD use uuid_create() or uuid_generate() - or

[issue32493] UUID Module - FreeBSD build failure

Michael Felt added the comment: Actually, the libc/libuuid function called should be setting the version/variant values as well. So, I think the AMD64 FreeBSD 10.x Shared 3.x uuid_generate() function is wrong (if that is what it is using - was it/can it also use the

[issue32493] UUID Module - FreeBSD build failure

David CARLIER added the comment: Might comes from uuid1 function itself ... e.g. line 704 not setting version "field". -- nosy: +David CARLIER2 ___ Python tracker

[issue32493] UUID Module - FreeBSD build failure

STINNER Victor added the comment: > New changeset b4ebaa7099c3413b42a9581c4ca560fe7540 by Antoine Pitrou > (David Carlier) in branch 'master': > bpo-32493: Not only AIX, but FreeBSD has uuid_create support (#5089) This change introduced a regression on AMD64

[issue32493] UUID Module - FreeBSD build failure

Antoine Pitrou added the comment: Thank you for the fix David! -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker

[issue32493] UUID Module - FreeBSD build failure

Antoine Pitrou added the comment: New changeset b4ebaa7099c3413b42a9581c4ca560fe7540 by Antoine Pitrou (David Carlier) in branch 'master': bpo-32493: Not only AIX, but FreeBSD has uuid_create support (#5089)

[issue32493] UUID Module - FreeBSD build failure

David Carlier added the comment: I guessed that :-) I trusted it worked just fine for you. To be honest I know nearly nothing about AIX specificities :-) -- ___ Python tracker

[issue32493] UUID Module - FreeBSD build failure

Michael Felt added the comment: On 08/01/2018 12:47, David Carlier wrote: > David Carlier added the comment: > > Perfect. That solves in the process OpenBSD uuid module build too. > > -- p.s. I did not 'invent' unsigned32 - just took the

[issue32493] UUID Module - FreeBSD build failure

David Carlier added the comment: Perfect. That solves in the process OpenBSD uuid module build too. -- ___ Python tracker ___

[issue32493] UUID Module - FreeBSD build failure

Antoine Pitrou added the comment: Seems to be in inttypes.h: https://www.ibm.com/support/knowledgecenter/en/ssw_aix_71/com.ibm.aix.files/inttypes.h.htm -- ___ Python tracker

[issue32493] UUID Module - FreeBSD build failure

Michael Felt added the comment: On 05/01/2018 13:38, Antoine Pitrou wrote: > Antoine Pitrou added the comment: > > Michael, does AIX have uint32_t? If so, we could happily drop the unsigned32 > reference. Yes, AIX has unit32_t.

[issue32493] UUID Module - FreeBSD build failure

Antoine Pitrou added the comment: Michael, does AIX have uint32_t? If so, we could happily drop the unsigned32 reference. -- ___ Python tracker

[issue32493] UUID Module - FreeBSD build failure

Antoine Pitrou added the comment: The AIX-specific code was contributed by Michael Felt in issue32399. -- nosy: +Michael.Felt, pitrou ___ Python tracker

[issue32493] UUID Module - FreeBSD build failure

New submission from David Carlier : UUID module build fails on FreeBSD since it supports uuid_create function. -- components: FreeBSD messages: 309479 nosy: David Carlier, koobs priority: normal pull_requests: 4970 severity: normal status: open title: UUID Module