[issue32560] [EASY C] inherit the py launcher's STARTUPINFO

miss-islington added the comment: New changeset 04b2a5eedac7ac0fecdafce1bda1028ee55e2aac by Miss Islington (bot) in branch '3.7': bpo-32560: inherit the py launcher's STARTUPINFO (GH-9000) https://github.com/python/cpython/commit/04b2a5eedac7ac0fecdafce1bda1028ee55e2aac -- nosy: +mi

[issue32560] [EASY C] inherit the py launcher's STARTUPINFO

miss-islington added the comment: New changeset cb0904762681031edc50f9d7d7ef48cffcf96d9a by Miss Islington (bot) (Shiva Saxena) in branch 'master': bpo-32560: inherit the py launcher's STARTUPINFO (GH-9000) https://github.com/python/cpython/commit/cb0904762681031edc50f9d7d7ef48cffcf96d9a --

[issue32560] [EASY C] inherit the py launcher's STARTUPINFO

Change by Steve Dower : -- nosy: -miss-islington resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue32560] [EASY C] inherit the py launcher's STARTUPINFO

Change by miss-islington : -- pull_requests: +11649, 11650, 11651 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue32560] [EASY C] inherit the py launcher's STARTUPINFO

Change by miss-islington : -- pull_requests: +11649, 11650 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue32560] [EASY C] inherit the py launcher's STARTUPINFO

Change by miss-islington : -- pull_requests: +11649 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue32560] [EASY C] inherit the py launcher's STARTUPINFO

Steve Dower added the comment: Great, thanks. I'll go ahead and merge. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue32560] [EASY C] inherit the py launcher's STARTUPINFO

Eryk Sun added the comment: Oops, I forgot the check: 0:000> ?? sizeof(test!_STARTUPINFOW) unsigned int64 0x68 -- ___ Python tracker ___ _

[issue32560] [EASY C] inherit the py launcher's STARTUPINFO

Eryk Sun added the comment: It should be fine. If the docs don't require initializing cb, we can assume it's done for us. For example, msvcrt.dll calls GetStartupInfo without initializing this field: 0:000> kc 3 Call Site KERNELBASE!GetStartupInfoW msvcrt!ioinit msvcrt!_

[issue32560] [EASY C] inherit the py launcher's STARTUPINFO

Steve Dower added the comment: Hi Shiva, sorry for not noticing your PR earlier. I have one question for Eryk, who may be able to answer more easily than I can: do we need to initialize cbSize before calling GetStartupInfoW()? The docs[1] don't seem to suggest it, and I can't look at the imp

[issue32560] [EASY C] inherit the py launcher's STARTUPINFO

Shiva Saxena added the comment: I am a new contributor, and happy to take this issue as my first contribution in cpython. I have sent a PR for the same. Please let me know if anything needs to be change. -- nosy: +GeekyShacklebolt ___ Python track

[issue32560] [EASY C] inherit the py launcher's STARTUPINFO

Change by Shiva Saxena : -- keywords: +patch pull_requests: +8472 stage: needs patch -> patch review ___ Python tracker ___ ___ Pyth

[issue32560] [EASY C] inherit the py launcher's STARTUPINFO

STINNER Victor added the comment: Ah, so the task is just open PC/launcher.c and replaced "si.cb = sizeof(si)" with "GetStartupInfoW(&si)". Ok, I agree, that's easy and I would be happy to review such PR ;-) I add the "[EASY C]" tag to the issue title in this case. -- title: inheri