[issue32729] socket error handling needed

Change by Serhiy Storchaka : -- type: crash -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32729] socket error handling needed

yang added the comment: Oh.. you are right. I think it's my bug. here is code ``` import urllib3 import certifi from functools import wraps import signal from urllib3 import Timeout def timeoutdec(sec): def decorator(func): def _timeout(signum, frame):

[issue32729] socket error handling needed

INADA Naoki added the comment: And your screenshot doesn't contain "full" traceback chain. It can be very important hint about who creates invalid TimeoutError. -- ___ Python tracker

[issue32729] socket error handling needed

INADA Naoki added the comment: It may be bug of raising TimeoutError, not catching. That's why I want example code to reproduce. -- ___ Python tracker

[issue32729] socket error handling needed

yang added the comment: When timeout error occurred in urllib3.Poolmanager.urlopen(), the built-in TimeoutError raised which is not caught in existing timeout exception clause. Thus, It is caught by 'error' except and it is not checking Nonetype so that raising IndexError

[issue32729] socket error handling needed

INADA Naoki added the comment: Please give us reproducible example. Otherwise, we can't know it's our bug or it's bug of caller. -- nosy: +inada.naoki ___ Python tracker

[issue32729] socket error handling needed

yang added the comment: In the lib/socket.py Inside of readinto function, 576 line needed None type check or something -- ___ Python tracker

[issue32729] socket error handling needed

Change by yang : -- keywords: +patch pull_requests: +5286 stage: -> patch review ___ Python tracker ___

[issue32729] socket error handling needed

yang added the comment: If socket error occurred I think it is a timeout error or something. but It's not error raising correctly but IndexError which is not correct error MSG. It will be fixed or None type check needed. -- resolution: -> fixed

[issue32729] socket error handling needed

New submission from 양영일 : socket error handling needed -- components: IO messages: 311313 nosy: 양영일 priority: normal severity: normal status: open title: socket error handling needed type: crash versions: Python 3.4, Python 3.5, Python 3.6, Python 3.7, Python 3.8