[issue32764] Popen doesn't work on Windows when args is a list

2018-02-19 Thread Steve Dower
Steve Dower added the comment: Sounds good to me -- resolution: -> duplicate stage: patch review -> resolved status: open -> closed superseder: -> Windows: subprocess debug assertion on failure to execute the process ___

[issue32764] Popen doesn't work on Windows when args is a list

2018-02-19 Thread Zachary Ware
Zachary Ware added the comment: I fixed this independently earlier today, tied to bpo-30121 (the issue that introduced the test bug) because I didn't find this one. See PR5758, PR5759 (3.7), and PR5760 (3.6). -- ___ Python

[issue32764] Popen doesn't work on Windows when args is a list

2018-02-19 Thread Steve Dower
Steve Dower added the comment: Turns out this is a trivial typo in the test, so I stole the issue from Greg and pushed a PR. -- assignee: gregory.p.smith -> steve.dower ___ Python tracker

[issue32764] Popen doesn't work on Windows when args is a list

2018-02-19 Thread Steve Dower
Change by Steve Dower : -- keywords: +patch pull_requests: +5540 stage: needs patch -> patch review ___ Python tracker ___

[issue32764] Popen doesn't work on Windows when args is a list

2018-02-06 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith ___ Python tracker ___ ___

[issue32764] Popen doesn't work on Windows when args is a list

2018-02-04 Thread Anders Lorentsen
Anders Lorentsen added the comment: Wait a minute. The failing test is test_nonexisting_with_pipes, and it fails because args[0] is a tuple - how can that be? Nobody is supposed to pass cmd=sequence-where-first-element-is-a-tuple! Is everything all right with the test

[issue32764] Popen doesn't work on Windows when args is a list

2018-02-04 Thread Anders Lorentsen
Anders Lorentsen added the comment: Also, isn't there continuous integration testing? Everything passed on the PR, so where does this come from? -- ___ Python tracker

[issue32764] Popen doesn't work on Windows when args is a list

2018-02-04 Thread Anders Lorentsen
Anders Lorentsen added the comment: This is strange, because _execute_child calls os.fsdecode with `args` as the argument, which may be a list. os.fsdecode calls fspath. Now, the python docstring of _fspath, as defined in Lib/os.py on line 1031, clearly states that it will

[issue32764] Popen doesn't work on Windows when args is a list

2018-02-04 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : test_subprocess is failing on Windows. C:\py\cpython3.7>./python -m test -uall -v -m test_nonexisting_with_pipes test_subprocess Running Debug|Win32 interpreter... == CPython 3.7.0b1+ (heads/3.7:1a0239e, Feb 4 2018, 16:19:37)