STINNER Victor victor.stin...@haypocalc.com added the comment:
I will open new issues for the two remaining patches.
Done: #9402 for pyexpat and #9403 for cElementTree.
--
resolution: - fixed
status: open - closed
___
Python tracker
STINNER Victor victor.stin...@haypocalc.com added the comment:
I will open new issues for the two remaining patches.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3299
___
Mark Lawrence breamore...@yahoo.co.uk added the comment:
Loads of comments about backports, can this be closed or are there still any
outstanding issues?
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
Nick Coghlan ncogh...@gmail.com added the comment:
I believe the two attached patches still need to be checked.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3299
___
Changes by STINNER Victor victor.stin...@haypocalc.com:
Removed file: http://bugs.python.org/file15863/thread_py_decref.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3299
___
Changes by STINNER Victor victor.stin...@haypocalc.com:
Removed file: http://bugs.python.org/file15880/_curses_panel_py_decref.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3299
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
thread fix commited: r78610 (trunk)
curses panel fix commited: r78635 (trunk)
Backport done in r79198 (2.6).
--
___
Python tracker rep...@bugs.python.org
STINNER Victor victor.stin...@haypocalc.com added the comment:
thread fix commited: r78610 (trunk), r78611 (py3k), r78612 (3.1).
Delay the backport to 2.6 after the 2.6.5 release.
--
___
Python tracker rep...@bugs.python.org
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +pitrou
stage: - patch review
versions: +Python 3.2 -Python 3.0
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3299
___
Antoine Pitrou pit...@free.fr added the comment:
Victor, your overflow test in the sre patch tests for TypeError, but
OverflowError is actually raised:
==
ERROR: test_dealloc (test.test_re.ReTests)
STINNER Victor victor.stin...@haypocalc.com added the comment:
Victor, your overflow test in the sre patch tests for TypeError,
but OverflowError is actually raised: (...)
Oops, fixed.
--
Added file: http://bugs.python.org/file15878/sre_py_decref-2.patch
Changes by STINNER Victor victor.stin...@haypocalc.com:
Removed file: http://bugs.python.org/file10891/_sre-2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3299
___
Changes by STINNER Victor victor.stin...@haypocalc.com:
Removed file: http://bugs.python.org/file15862/sre_py_decref.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3299
___
Changes by STINNER Victor victor.stin...@haypocalc.com:
Added file: http://bugs.python.org/file15880/_curses_panel_py_decref.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3299
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
Update _curses_panel patch. The crash occurs if malloc() fail in insert_lop().
I don't know how to write reliable test for this case. Maybe using
http://www.nongnu.org/failmalloc/ library (a little bit overkill, isn't it?).
Antoine Pitrou pit...@free.fr added the comment:
The sre patch has been committed, thank you!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3299
___
Changes by Antoine Pitrou pit...@free.fr:
Removed file: http://bugs.python.org/file15878/sre_py_decref-2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3299
___
Antoine Pitrou pit...@free.fr added the comment:
I don't know how to write reliable test for this case. Maybe using
http://www.nongnu.org/failmalloc/ library (a little bit overkill, isn't
it?).
Yes, it would IMO be overkill.
--
___
Python
Changes by STINNER Victor victor.stin...@haypocalc.com:
Removed file: http://bugs.python.org/file10892/_curses_panel.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3299
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
Update pyexpat patch. As _curses_panel, the bug is raised on malloc() failure.
The patch adds also a dummy test on ExternalEntityParserCreate().
--
Added file: http://bugs.python.org/file15881/pyexpat_py_decref.patch
STINNER Victor victor.stin...@haypocalc.com added the comment:
Patch for cElementTree:
* Replace PyObject_Del() by Py_DECREF()
* Catch element_new_extra() errors
* parser dealloc: replace Py_DECREF() by Py_XDECREF() because the pointer may
be NULL (error in the constructor)
* set all parser
Changes by STINNER Victor victor.stin...@haypocalc.com:
Removed file: http://bugs.python.org/file10893/pyobject_del.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3299
___
Changes by STINNER Victor victor.stin...@haypocalc.com:
Added file: http://bugs.python.org/file15862/sre_py_decref.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3299
___
Changes by STINNER Victor victor.stin...@haypocalc.com:
Added file: http://bugs.python.org/file15863/thread_py_decref.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3299
___
STINNER Victor victor.stin...@haypocalc.com added the comment:
This issue is still open, it's still possible to crash Python in debug mode. I
updated patches for the _sre and thread modules.
--
___
Python tracker rep...@bugs.python.org
Nick Coghlan ncogh...@gmail.com added the comment:
(changing title and unassigning from Fredrik since this isn't an RE
specific problem, flagged as also affecting interpreter core, flagged as
affecting all currently maintained versions)
--
assignee: effbot -
components: +Interpreter
26 matches
Mail list logo
