[issue32991] AttributeError in doctest.DocTestFinder.find

Change by Jason R. Coombs : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue32991] AttributeError in doctest.DocTestFinder.find

Jason R. Coombs added the comment: New changeset 5a0c3987abd6a71b4fadeb525477eb5f560e8514 by Jason R. Coombs (Miss Islington (bot)) in branch '3.7': bpo-32991: Restore expectation that inspect.getfile raises TypeError on namespace package (GH-5980) (GH-5997)

[issue32991] AttributeError in doctest.DocTestFinder.find

Jason R. Coombs added the comment: New changeset b9650a04a81355c8a7dcd0464c28febfb4bfc0a9 by Jason R. Coombs in branch 'master': bpo-32991: Restore expectation that inspect.getfile raises TypeError on namespace package (GH-5980)

[issue32991] AttributeError in doctest.DocTestFinder.find

Change by miss-islington : -- pull_requests: +5763 ___ Python tracker ___

[issue32991] AttributeError in doctest.DocTestFinder.find

Barry A. Warsaw added the comment: Good catch Jason. Your fix is exactly right. I approved your PR, which is against master, so it should definitely be backported to 3.7. No need to backport to 3.6; we reverted the change for that release. -- versions: +Python

[issue32991] AttributeError in doctest.DocTestFinder.find

Change by Jason R. Coombs : -- keywords: +patch pull_requests: +5746 stage: -> patch review ___ Python tracker ___

[issue32991] AttributeError in doctest.DocTestFinder.find

Jason R. Coombs added the comment: And [this patch](https://gist.github.com/7184fa32670f2c6377ddeb710676) corrects the failure such that the test passes. It does so by restoring the expectation that inspect.getfile will once again raise a TypeError for these namespace

[issue32991] AttributeError in doctest.DocTestFinder.find

Jason R. Coombs added the comment: Okay. I've wired up some unittests in test_doctest, and with [this patch](https://gist.github.com/jaraco/ea992719ac931fa761a6e9ef7a354542), it now captures the failed expectation of this ticket. --

[issue32991] AttributeError in doctest.DocTestFinder.find

Jason R. Coombs added the comment: I tried creating a test, but I'm struggling. I added [this patch](https://gist.github.com/e795a9a34594d202711aedf22c484af9), and tried to run it, but it's not being run. ``` $ ./python.exe Tools/scripts/run_tests.py 'test_doctest'

[issue32991] AttributeError in doctest.DocTestFinder.find

Jason R. Coombs added the comment: The main questions I have before proceeding with creating tests relate to what interfaces Python wishes to support. Here's the decision tree I have in my head. - Retain the change of adding a __file__ attribute to namespace packages for

[issue32991] AttributeError in doctest.DocTestFinder.find

New submission from Jason R. Coombs : In Python 3.6, one could find doctests on a namespace package: ``` $ mkdir foo $ python3.6 Python 3.6.4 (v3.6.4:d48ecebad5, Dec 18 2017, 21:07:28) [GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwin Type "help", "copyright", "credits"