[issue33173] GzipFile's .seekable() returns True even if underlying buffer is not seekable

2018-11-09 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: And I share Martin's concern about fast-forward with an unseekable underlying file. If this works in current code, we can't simply return break it. This may mean that we can't change the implementation of GzipFile.seekable() at all, even if it lies in

[issue33173] GzipFile's .seekable() returns True even if underlying buffer is not seekable

2018-11-09 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I share Martin's opinion that this is a misfeature. User code can check seekable() and use seek() if it returns True or cache necessary data in memory if it returns False, because it is expected that seek() is more efficient. But in case of GzipFile it is

[issue33173] GzipFile's .seekable() returns True even if underlying buffer is not seekable

2018-10-06 Thread Martin Panter
Martin Panter added the comment: If a change is made, it would be nice to bring the “gzip”, “bzip” and LZMA modules closer together. The current “bzip” and LZMA modules rely on the underlying “seekable” method without a fallback implementation, but also have a check for read mode. I think

[issue33173] GzipFile's .seekable() returns True even if underlying buffer is not seekable

2018-10-05 Thread Cheryl Sabella
Cheryl Sabella added the comment: Allowing for non seekable files was added in issue1675951. And under that issue in msg117131, the author of the change wrote: "The patch creates another problem with is not yet fixed: The implementation of .seekable() is becoming wrong. As one can now use

[issue33173] GzipFile's .seekable() returns True even if underlying buffer is not seekable

2018-09-14 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33173] GzipFile's .seekable() returns True even if underlying buffer is not seekable

2018-03-28 Thread Roundup Robot
Change by Roundup Robot : -- keywords: +patch pull_requests: +6021 stage: -> patch review ___ Python tracker ___

[issue33173] GzipFile's .seekable() returns True even if underlying buffer is not seekable

2018-03-28 Thread Walt Askew
New submission from Walt Askew : The seekable method on gzip.GzipFile always returns True, even if the underlying buffer is not seekable. However, if seek is called on the GzipFile, the seek will fail unless the underlying buffer is seekable. This can cause consumers of