[issue33216] [3.5] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

miss-islington added the comment: New changeset 1e7193bd027a5a4aa1a387e3f201a3e465c25f01 by Miss Islington (bot) in branch '3.6': bpo-33216: Improve the documentation for CALL_FUNCTION_* (GH-8338) (GH-8784) https://github.com/python/cpython/commit/1e7193bd027a5a4aa1a387e3f201a3e465c25f01

[issue33216] [3.5] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

miss-islington added the comment: New changeset f8e34eee74871b3343f6c3545bce41242ba378e8 by Miss Islington (bot) in branch '3.7': bpo-33216: Improve the documentation for CALL_FUNCTION_* (GH-8338) (GH-8784) https://github.com/python/cpython/commit/f8e34eee74871b3343f6c3545bce41242ba378e8

[issue33216] [3.5] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

Serhiy Storchaka added the comment: Thank you Larry for your rewriting. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue33216] [3.5] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

Change by miss-islington : -- pull_requests: +8778 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33216] [3.5] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

Serhiy Storchaka added the comment: New changeset afa591d7748c66831e6e650108024f3293be33f1 by Serhiy Storchaka in branch '2.7': [2.7] bpo-33216: Clarify the documentation for CALL_FUNCTION_* (GH-8338) (GH-8783)

[issue33216] [3.5] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

Change by miss-islington : -- pull_requests: +8777 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33216] [3.5] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

Serhiy Storchaka added the comment: New changeset 5e99b56d6b249995a4fa2bc09c0bb03841f49572 by Serhiy Storchaka in branch 'master': bpo-33216: Improve the documentation for CALL_FUNCTION_* (GH-8338) (GH-8784) https://github.com/python/cpython/commit/5e99b56d6b249995a4fa2bc09c0bb03841f49572

[issue33216] [3.5] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

Eric Snow added the comment: FYI, I opened bpo-34413 to address how the bytecode change is not mentioned in the porting section of the 3.5 "What's New" doc. In retrospect (I didn't notice that this issue was still open), I suppose that doesn't need a separate issue so feel free to close

[issue33216] [3.5] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

Eric Snow added the comment: FTR, the change was introduced by the PEP 448 implementation. [1] [1] https://github.com/python/cpython/pull/8338#issuecomment-406256152 -- nosy: +eric.snow ___ Python tracker

[issue33216] [3.5] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

Change by Serhiy Storchaka : -- pull_requests: +8257 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33216] [3.5] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

Change by Serhiy Storchaka : -- pull_requests: +8256 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33216] [3.5] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

Larry Hastings added the comment: New changeset 76aa2c0a9a8dd3ac90b91e7342c8ce8125bf21f9 by larryhastings in branch '3.5': bpo-33216: Clarify the documentation for CALL_FUNCTION_* (#8338) https://github.com/python/cpython/commit/76aa2c0a9a8dd3ac90b91e7342c8ce8125bf21f9 --

[issue33216] [3.5] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

Change by Larry Hastings : -- pull_requests: +7872 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33216] [3.5] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

Serhiy Storchaka added the comment: Sorry. I have attracted your attention, and this was the only purpose of this mark. You are aware of this issue now, and the further fate of it is up to you. -- ___ Python tracker

[issue33216] [3.5] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

Larry Hastings added the comment: Marking an issue as "Release Blocker" is completely inappropriate for "I'd like to see this documentation change get into the next bugfix release." Our Python Dev Guide discusses priority, here:

[issue33216] [3.5] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

Serhiy Storchaka added the comment: Because I don't want that this fix be missed in the next bugfix release. I think this documentation is important enough. There may be no chance to document it later. -- ___ Python

[issue33216] [3.5] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

STINNER Victor added the comment: If the issue is specific to Python 3.5, we can no longer fix it since 3.5 doesn't accept bugfixes anymore. No? -- nosy: +vstinner ___ Python tracker

[issue33216] [3.5] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

Larry Hastings added the comment: Documentation changes are okay. -- ___ Python tracker ___

[issue33216] [3.5] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

Larry Hastings added the comment: Serhiy, why did you mark this as a release blocker? This is a proposed documentation fix. -- priority: release blocker -> low ___ Python tracker

[issue33216] [3.5] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

Change by STINNER Victor : -- title: Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW -> [3.5] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW ___ Python tracker