[issue33330] Better error handling in PyImport_Cleanup()

Serhiy Storchaka added the comment: See also issue33379 about the bug in subinterpreters exposed when add yet one PyErr_WriteUnraisable() in PyImport_Cleanup() (it was not added because of this). -- ___ Python tracker

[issue33330] Better error handling in PyImport_Cleanup()

STINNER Victor added the comment: I reopen the issue because I created the PR 7068 to propose further checks (in debug mode). -- resolution: fixed -> status: closed -> open ___ Python tracker

[issue33330] Better error handling in PyImport_Cleanup()

Change by STINNER Victor : -- pull_requests: +6696 ___ Python tracker ___ ___

[issue33330] Better error handling in PyImport_Cleanup()

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue33330] Better error handling in PyImport_Cleanup()

Serhiy Storchaka added the comment: New changeset c1a6832f50b36ffec299e6e6038535904e2b158d by Serhiy Storchaka in branch 'master': bpo-0: Write exceptions occurred in PyImport_Cleanup() to stderr. (GH-6606)

[issue33330] Better error handling in PyImport_Cleanup()

Serhiy Storchaka added the comment: New changeset 55299fffe328c3d2dfc222a22116b7e53bf2e962 by Serhiy Storchaka in branch '2.7': [2.7] bpo-0: Improve error handling in PyImport_Cleanup(). (GH-6564). (GH-6605)

[issue33330] Better error handling in PyImport_Cleanup()

Serhiy Storchaka added the comment: New changeset b16681fb1e63f45361d1d68333d6dbdd4bf5435d by Serhiy Storchaka in branch '3.6': [3.6] bpo-0: Improve error handling in PyImport_Cleanup(). (GH-6564). (GH-6604)

[issue33330] Better error handling in PyImport_Cleanup()

Serhiy Storchaka added the comment: PR 6606 replaces PyErr_Clear() with PyErr_WriteUnraisable(). This may add an unexpected noise at shutdown' but on other hand, this may be a helpful information in the case if something wrong happen. It doesn't produce

[issue33330] Better error handling in PyImport_Cleanup()

Change by Serhiy Storchaka : -- pull_requests: +6302 ___ Python tracker ___ ___

[issue33330] Better error handling in PyImport_Cleanup()

Change by Serhiy Storchaka : -- pull_requests: +6300 ___ Python tracker ___ ___

[issue33330] Better error handling in PyImport_Cleanup()

Change by Serhiy Storchaka : -- pull_requests: +6301 ___ Python tracker ___ ___

[issue33330] Better error handling in PyImport_Cleanup()

miss-islington added the comment: New changeset 291c9d4f74f3c7c57ae18e1aca617206795a090d by Miss Islington (bot) in branch '3.7': bpo-0: Improve error handling in PyImport_Cleanup(). (GH-6564)

[issue33330] Better error handling in PyImport_Cleanup()

Change by miss-islington : -- pull_requests: +6296 ___ Python tracker ___

[issue33330] Better error handling in PyImport_Cleanup()

Serhiy Storchaka added the comment: New changeset e9d9494d6b2a5e0c2d48d22c7f0d5e95504b4f7e by Serhiy Storchaka in branch 'master': bpo-0: Improve error handling in PyImport_Cleanup(). (GH-6564)

[issue33330] Better error handling in PyImport_Cleanup()

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +6259 stage: -> patch review ___ Python tracker ___

[issue33330] Better error handling in PyImport_Cleanup()

New submission from Serhiy Storchaka : The proposed PR adds missed checks for errors and PyErr_Clear() calls in PyImport_Cleanup(). It may be worth to use PyErr_WriteUnraisable() in place of PyErr_Clear() (newly added and existing) in most cases. But this can add