Guilherme Polo ggp...@gmail.com added the comment:
Committed on r74446, will merge into py3k.
--
resolution: - accepted
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3344
Guilherme Polo ggp...@gmail.com added the comment:
Committed on r74446, will merge into py3k.
py3k: r74450
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3344
___
Daniel Diniz aja...@gmail.com added the comment:
+1 on committing this.
--
nosy: +ajaksu2, gpolo
priority: - normal
stage: - patch review
type: - feature request
versions: +Python 2.7, Python 3.1
___
Python tracker rep...@bugs.python.org
Raymond Hettinger rhettin...@users.sourceforge.net added the comment:
I would leave the variable name unchanged.
Also, better to use rstrip than file[0:-1].
--
nosy: +rhettinger
___
Python tracker rep...@bugs.python.org
Guilherme Polo ggp...@gmail.com added the comment:
I would prefer to rename it, why waste the chance to rename something
badly named ?
I agree on the rstrip use.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3344
Changes by Amaury Forgeot d'Arc [EMAIL PROTECTED]:
--
assignee: - kbk
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3344
___
___
Python-bugs-list
Changes by Terry J. Reedy [EMAIL PROTECTED]:
--
components: +IDLE
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3344
___
___
Python-bugs-list mailing
Terry J. Reedy [EMAIL PROTECTED] added the comment:
This looks as straightforward as patches get.
I verified that itertools.count is not used elsewhere in the file,
so it is ok to zap the import. Suggest apply.
--
nosy: +tjreedy
___
Python tracker
New submission from Tal Einat [EMAIL PROTECTED]:
Just minor code cleanup.
Only one instance of zip(count(), ...) in EditorWindow.py, where I also
changed 'file' to 'file_name' to avoid overriding the built-in 'file' class.
--
files: IDLE_EditorWindow_minor.patch
keywords: patch
