[issue33461] json.loads(encoding=) does not emit deprecation warning.

Change by Inada Naoki : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue33461] json.loads(encoding=) does not emit deprecation warning.

Inada Naoki added the comment: New changeset a8abe097c1165db25b429ca02a65c4f8acbc062b by Inada Naoki (Matthias Bussonnier) in branch 'master': bpo-33461: emit DeprecationWarning when json.loads(encoding=...) is used (GH-6762)

[issue33461] json.loads(encoding=) does not emit deprecation warning.

Inada Naoki added the comment: Since we didn't raise DeprecationWarning, I think at least one version with DeprecationWarning is preferable. -- nosy: +inada.naoki versions: +Python 3.8 ___ Python tracker

[issue33461] json.loads(encoding=) does not emit deprecation warning.

Matthias Bussonnier added the comment: I've opened https://github.com/python/cpython/pull/6784 as an alternative that removes it. I was worried to remove it so close to 3.7. -- ___ Python tracker

[issue33461] json.loads(encoding=) does not emit deprecation warning.

Change by Matthias Bussonnier : -- pull_requests: +6471 ___ Python tracker ___

[issue33461] json.loads(encoding=) does not emit deprecation warning.

Serhiy Storchaka added the comment: I'm wondering if it can be removed at all. Maybe it was left in issue4136 due to oversight. -- nosy: +bob.ippolito, ezio.melotti, pitrou, rhettinger, serhiy.storchaka ___ Python

[issue33461] json.loads(encoding=) does not emit deprecation warning.

Change by Matthias Bussonnier : -- keywords: +patch pull_requests: +6449 stage: -> patch review ___ Python tracker ___

[issue33461] json.loads(encoding=) does not emit deprecation warning.

New submission from Matthias Bussonnier : The `encoding` keyword of json.loads is ignored and deprecated. AFAICT this is since Python 3.1. Passing a value for encoding does not emit a deprecation warning. -- messages: 316384 nosy: mbussonn priority: