[issue33912] [EASY] test_warnings: test_exec_filename() fails when run with -Werror

STINNER Victor added the comment: Thank you Christopher Frederickson for your contribution! I merged your PR. I confirm that it fixes the issue. Thanks Thomas Kluyver for the hints ;-) -- ___ Python tracker

[issue33912] [EASY] test_warnings: test_exec_filename() fails when run with -Werror

Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue33912] [EASY] test_warnings: test_exec_filename() fails when run with -Werror

STINNER Victor added the comment: New changeset 419e88d18ccc83e182afca124d42f46794022aab by Victor Stinner (Christopher Frederickson) in branch 'master': bpo-33912: Fix test_warnings when run with -Werror (GH-7839)

[issue33912] [EASY] test_warnings: test_exec_filename() fails when run with -Werror

Change by Christopher Frederickson : -- keywords: +patch pull_requests: +7448 stage: -> patch review ___ Python tracker ___ ___

[issue33912] [EASY] test_warnings: test_exec_filename() fails when run with -Werror

Change by Brett Cannon : -- nosy: +brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33912] [EASY] test_warnings: test_exec_filename() fails when run with -Werror

Thomas Kluyver added the comment: Yes, this should be easy. I misunderstood how to use the catch_warnings context manager. I thought that catch_warnings itself set up the warnings filters you need. You actually need to do that with a separate call inside the with block, as shown here:

[issue33912] [EASY] test_warnings: test_exec_filename() fails when run with -Werror

Change by Serhiy Storchaka : -- nosy: +takluyver ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33912] [EASY] test_warnings: test_exec_filename() fails when run with -Werror

STINNER Victor added the comment: I consider that this issue is easy, core developers/long time contriubtors: please don't fix it, but explain how to fix it and let a newcomer to fix it! https://mail.python.org/pipermail/python-committers/2017-June/004564.html --

[issue33912] [EASY] test_warnings: test_exec_filename() fails when run with -Werror

New submission from STINNER Victor : vstinner@apu$ ./python -W error -m test -v test_warnings == ERROR: test_exec_filename (test.test_warnings.CWarnTests) --