[issue34027] python 3.7 openpty/forkpty build failure on macOS

Orivej Desh added the comment: The explicit conditional on __APPLE__ can be avoided with the attached patch. (Tested on NixOS and macOS with Nixpkgs.) -- nosy: +orivej Added file: https://bugs.python.org/file47666/darwin-libutil.patch ___ Python

[issue34027] python 3.7 openpty/forkpty build failure on macOS

Daiderd Jordan added the comment: Oh interesting, so it only used to worked by accident. I should have looked at the 3.6 log more closely. -- ___ Python tracker ___

[issue34027] python 3.7 openpty/forkpty build failure on macOS

Ned Deily added the comment: It's failing in 3.7 because of the change introduced in Issue27659 to prohibit implicit C function declarations by adding the -Werror=implicit-function-declaration to compiles. -- ___ Python tracker

[issue34027] python 3.7 openpty/forkpty build failure on macOS

Daiderd Jordan added the comment: The headers end up in the build environment because of Libsystem which is part of our base environment. But yes, this is also the case with 3.6 and that builds just fine so I'm not sure why it's failing now. These are the logs from our build service for

[issue34027] python 3.7 openpty/forkpty build failure on macOS

Ned Deily added the comment: Even on macOS 10.11.6, libutil.h is not installed and posixmodule.c builds just fine. So I don't think that the presence of something in opensource.apple.com necessarily means it was installed in place in a standard system. I'm not saying yet that we shouldn't

[issue34027] python 3.7 openpty/forkpty build failure on macOS

Daiderd Jordan added the comment: This is a build using the nix package manager, we use all of the opensource components provided by apple instead of relying on xcode. The libutil.h that's found in this case is the one from the 10.11.6 sources.

[issue34027] python 3.7 openpty/forkpty build failure on macOS

Ned Deily added the comment: I don't see this build failure. Can you say where you find libutil.h installed on macOS and what version of macOS this is? It doesn't seem to be part of the standard Apple-supplied /usr/include header files installed by xcode-select --install for macOS 10.13

[issue34027] python 3.7 openpty/forkpty build failure on macOS

Change by Daiderd Jordan : -- keywords: +patch pull_requests: +7664 stage: -> patch review ___ Python tracker ___ ___

[issue34027] python 3.7 openpty/forkpty build failure on macOS

Change by Ned Deily : -- components: +macOS nosy: +ned.deily, ronaldoussoren ___ Python tracker ___ ___ Python-bugs-list mailing

[issue34027] python 3.7 openpty/forkpty build failure on macOS

New submission from Daiderd Jordan : I can't really figure out why, but the import in posixmodule.c seems to get skipped since python 3.7. The condition doesn't look entirely correct in case libutil.h is also available on macOS, however this has not changed since 3.6 and it worked fine