[issue34070] Superfluous call to isatty in open() when buffering >= 0

STINNER Victor added the comment: David Herberth: Thanks for report the issue, I didn't noticed it previously even if I read strace output frequently! And thanks for the fix. > This generates an error (can be seen with strace): > ioctl(5, TCGETS, 0x7ffef1435b60) = -1 ENOTTY (Inappropriate

[issue34070] Superfluous call to isatty in open() when buffering >= 0

STINNER Victor added the comment: New changeset 8deab9672554edaf58f91e238cc899463d53f6ea by Victor Stinner (David Herberth) in branch 'master': bpo-34070: open() only checks for isatty if buffering < 0 (GH-8187)

[issue34070] Superfluous call to isatty in open() when buffering >= 0

Change by David Herberth : -- keywords: +patch pull_requests: +7742 stage: -> patch review ___ Python tracker ___ ___

[issue34070] Superfluous call to isatty in open() when buffering >= 0

New submission from David Herberth : _iomodule.c:_io_open_impl checks for isatty even if not necessary (when buffering >= 0). Code: https://github.com/python/cpython/blob/c0ee341b29bd7d978b49272a2c0e2dcfa77404d5/Modules/_io/_iomodule.c#L392 { PyObject *res =