[issue34084] possible free statically allocated string in compiler when easter egg on

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue34084] possible free statically allocated string in compiler when easter egg on

Serhiy Storchaka added the comment: New changeset ec729d5407adafaae566136448ef0551bb29c070 by Serhiy Storchaka (Miss Islington (bot)) in branch '3.6': bpo-34084: Fix setting an error message for the "Barry as BDFL" easter egg. (GH-8262) (GH-8424)

[issue34084] possible free statically allocated string in compiler when easter egg on

Serhiy Storchaka added the comment: New changeset 220afffb683af1ba9e04c37535cfaa41348e9ebb by Serhiy Storchaka (Miss Islington (bot)) in branch '3.7': bpo-34084: Fix setting an error message for the "Barry as BDFL" easter egg. (GH-8262) (GH-8423)

[issue34084] possible free statically allocated string in compiler when easter egg on

Change by miss-islington : -- pull_requests: +7950 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34084] possible free statically allocated string in compiler when easter egg on

Change by miss-islington : -- pull_requests: +7949 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34084] possible free statically allocated string in compiler when easter egg on

Serhiy Storchaka added the comment: New changeset aba24ff3601ddc86b85e01880a8be596fb799287 by Serhiy Storchaka in branch 'master': bpo-34084: Fix setting an error message for the "Barry as BDFL" easter egg. (GH-8262)

[issue34084] possible free statically allocated string in compiler when easter egg on

Serhiy Storchaka added the comment: The problem is that 'from __future__ import' is parsed after converting the sources to the AST. But this flag affects the behavior of the tokenizer, before an AST is created. -- ___ Python tracker

[issue34084] possible free statically allocated string in compiler when easter egg on

Serhiy Storchaka added the comment: PR 8262 fixes the intended setting of error message for the "Barry as BDFL" easter egg. >>> from __future__ import barry_as_FLUFL >>> 1 != 2 File "", line 1 1 != 2 ^ SyntaxError: with Barry as BDFL, use '<>' instead of '!=' But there is other

[issue34084] possible free statically allocated string in compiler when easter egg on

Change by Serhiy Storchaka : -- pull_requests: +7795 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34084] possible free statically allocated string in compiler when easter egg on

Change by STINNER Victor : -- pull_requests: +7792 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34084] possible free statically allocated string in compiler when easter egg on

Barry A. Warsaw added the comment: AFAICT, that future only works in the REPL. -- ___ Python tracker ___ ___ Python-bugs-list

[issue34084] possible free statically allocated string in compiler when easter egg on

STINNER Victor added the comment: > Could you add a test in test_flufl.py that will fail with not patched code? It seems like PyObject_FREE() is never called with the static string "with Barry as BDFL, use '<>' instead of '!='". When parsetok() goes to code path (1):

[issue34084] possible free statically allocated string in compiler when easter egg on

Serhiy Storchaka added the comment: Could you add a test in test_flufl.py that will fail with not patched code? This issue and issue34080 look unrelated to me. They can be fixed independently. -- ___ Python tracker

[issue34084] possible free statically allocated string in compiler when easter egg on

STINNER Victor added the comment: Oh, this easter egg is tested by Lib/test/test_flufl.py. -- ___ Python tracker ___ ___

[issue34084] possible free statically allocated string in compiler when easter egg on

STINNER Victor added the comment: > I expected it should be easy to reproduce a crash, but I failed to find an > example. I don't understand how parsetok.c is supposed to handle "from __future__ import barry_as_FLUFL": * Parser/parsetok.c tests (ps->p_flags & CO_FUTURE_BARRY_AS_BDFL) *

[issue34084] possible free statically allocated string in compiler when easter egg on

STINNER Victor added the comment: This issue is related to bpo-34080. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34084] possible free statically allocated string in compiler when easter egg on

Change by STINNER Victor : -- keywords: +patch pull_requests: +7775 stage: -> patch review ___ Python tracker ___ ___

[issue34084] possible free statically allocated string in compiler when easter egg on

Change by Xiang Zhang : -- nosy: +vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34084] possible free statically allocated string in compiler when easter egg on

Change by Serhiy Storchaka : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34084] possible free statically allocated string in compiler when easter egg on

Serhiy Storchaka added the comment: I expected it should be easy to reproduce a crash, but I failed to find an example. -- ___ Python tracker ___

[issue34084] possible free statically allocated string in compiler when easter egg on

Change by Xiang Zhang : -- title: possible free statically allocated string -> possible free statically allocated string in compiler when easter egg on ___ Python tracker ___

[issue34084] possible free statically allocated string

New submission from Xiang Zhang : While reviewing PR8222, I found `err_ret->text` is assigned a not malloced string, but it will finally get freed in `err_input`. -- keywords: easy messages: 321381 nosy: serhiy.storchaka, xiang.zhang priority: normal severity: normal status: open