[issue34229] Possible access to unintended variable in "cpython/Objects/sliceobject.c" line 116

Serhiy Storchaka added the comment: Thank you for your PR Karthikeyan! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue34229] Possible access to unintended variable in "cpython/Objects/sliceobject.c" line 116

Serhiy Storchaka added the comment: New changeset 2bea7716093012319b5e6a4260fe802b15031f21 by Serhiy Storchaka (Xtreak) in branch '2.7': bpo-34229: Check start and stop of slice object to be long when they are not int in PySlice_GetIndices (GH-8480)

[issue34229] Possible access to unintended variable in "cpython/Objects/sliceobject.c" line 116

Change by Karthikeyan Singaravelan : -- keywords: +patch pull_requests: +8003 stage: needs patch -> patch review ___ Python tracker ___

[issue34229] Possible access to unintended variable in "cpython/Objects/sliceobject.c" line 116

Serhiy Storchaka added the comment: You need to expose it in the _testcapi module as Python function. -- ___ Python tracker ___

[issue34229] Possible access to unintended variable in "cpython/Objects/sliceobject.c" line 116

Karthikeyan Singaravelan added the comment: Is there a way to test this or trigger this code using Python syntax? `slice(start, stop, step).indices()` uses slice_indices in Objects/sliceobject.c . I checked the function docs https://docs.python.org/2.7/c-api/slice.html#c.PySlice_GetIndices

[issue34229] Possible access to unintended variable in "cpython/Objects/sliceobject.c" line 116

Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34229] Possible access to unintended variable in "cpython/Objects/sliceobject.c" line 116

Serhiy Storchaka added the comment: Good catch! -- components: +Interpreter Core keywords: +easy (C) nosy: +serhiy.storchaka stage: -> needs patch type: -> behavior ___ Python tracker

[issue34229] Possible access to unintended variable in "cpython/Objects/sliceobject.c" line 116

New submission from Petru-Florin Mihancea : While experimenting with a CodeSonar plugin we develop, we noticed a potential bug in file "cpython/Objects/sliceobject.c" line 116 function PySlice_GetIndices. if (r->start == Py_None) { *start = *step < 0 ? length-1 : 0; } else { if