[issue34251] MSI build fails

2018-07-28 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report! -- components: +Library (Lib) -Distutils nosy: -dstufft, eric.araujo resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.8 ___ Python tracker

[issue34251] MSI build fails

2018-07-28 Thread miss-islington
miss-islington added the comment: New changeset 1e98d87961ec752a1623135f4d7e8a41820ae256 by Miss Islington (bot) in branch '3.7': bpo-34251: Restore msilib.Win64 to preserve compatibility (GH-8510) https://github.com/python/cpython/commit/1e98d87961ec752a1623135f4d7e8a41820ae256 --

[issue34251] MSI build fails

2018-07-28 Thread miss-islington
Change by miss-islington : -- pull_requests: +8055 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue34251] MSI build fails

2018-07-28 Thread Zachary Ware
Zachary Ware added the comment: New changeset 11eb1a94704142385ffc07852739863ced8587d2 by Zachary Ware (Berker Peksag) in branch 'master': bpo-34251: Restore msilib.Win64 to preserve compatibility (GH-8510) https://github.com/python/cpython/commit/11eb1a94704142385ffc07852739863ced8587d2 --

[issue34251] MSI build fails

2018-07-28 Thread Berker Peksag
Change by Berker Peksag : -- keywords: +patch pull_requests: +8027 stage: needs patch -> patch review ___ Python tracker ___ ___ Pyt

[issue34251] MSI build fails

2018-07-27 Thread Berker Peksag
Berker Peksag added the comment: msilib.Win64 has been removed in https://github.com/python/cpython/commit/49ce74efe845a8a91939ff3990a5f233262d3e1f#diff-c762e09a046c2ff3cd91f0643cc58049L12 I guess the ``if msilib.Win64:`` clause can be replaced with ``if msilib.AMD64:``. -- keywords

[issue34251] MSI build fails

2018-07-27 Thread Kay Hayen
New submission from Kay Hayen : Hello there, building an MSI for my project fails. I am calling it like this: assert subprocess.call( ( sys.executable, "setup.py", "bdist_msi", "--target-version=" + sys.version[:3] ) ) ==