[issue34271] Please support logging of SSL master secret by env variable SSLKEYLOGFILE

Change by Christian Heimes : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue34271] Please support logging of SSL master secret by env variable SSLKEYLOGFILE

Johannes Frank added the comment: Yes, I didn't revisit the issue since, but Malcolm is right. Implemented in python 3.8. Thanks to all the contributors. On Sat, Feb 29, 2020 at 8:58 AM Malcolm Smith wrote: > > Malcolm Smith added the comment: > > It looks like this has now been done and

[issue34271] Please support logging of SSL master secret by env variable SSLKEYLOGFILE

Malcolm Smith added the comment: It looks like this has now been done and released. Can the issue be closed? -- nosy: +Malcolm Smith ___ Python tracker ___

[issue34271] Please support logging of SSL master secret by env variable SSLKEYLOGFILE

Change by Sascha Silbe : -- nosy: +sascha_silbe ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34271] Please support logging of SSL master secret by env variable SSLKEYLOGFILE

Christian Heimes added the comment: New changeset e35d1ba9eab07a59b98b700c5e18ceb13b2561a6 by Christian Heimes in branch 'master': bpo-34271: Fix compatibility with 1.0.2 (GH-13728) https://github.com/python/cpython/commit/e35d1ba9eab07a59b98b700c5e18ceb13b2561a6 --

[issue34271] Please support logging of SSL master secret by env variable SSLKEYLOGFILE

Change by Christian Heimes : -- pull_requests: +13612 pull_request: https://github.com/python/cpython/pull/13728 ___ Python tracker ___

[issue34271] Please support logging of SSL master secret by env variable SSLKEYLOGFILE

Christian Heimes added the comment: New changeset c7f7069e77c58e83b847c0bfe4d5aadf6add2e68 by Christian Heimes in branch 'master': bpo-34271: Add ssl debugging helpers (GH-10031) https://github.com/python/cpython/commit/c7f7069e77c58e83b847c0bfe4d5aadf6add2e68 --

[issue34271] Please support logging of SSL master secret by env variable SSLKEYLOGFILE

Nathaniel Smith added the comment: It's confusing, but AFAICT what happened is that Mozilla started to disable it in release builds, but got a bunch of pushback from users and changed their minds and decided to keep it enabled. But then there was a snafu tracking the patch for that, so

[issue34271] Please support logging of SSL master secret by env variable SSLKEYLOGFILE

Dima Tisnek added the comment: Perhaps https://stackoverflow.com/questions/42332792/chrome-not-firefox-are-not-dumping-to-sslkeylogfile-variable is outdated, but it suggests that: in firefox, this feature os not on by default in chrome, this feature is not available I would be vary of

[issue34271] Please support logging of SSL master secret by env variable SSLKEYLOGFILE

Johannes Frank added the comment: Hello Christian, much appreciated. Thank you so much. Johannes -- ___ Python tracker ___ ___

[issue34271] Please support logging of SSL master secret by env variable SSLKEYLOGFILE

Christian Heimes added the comment: Nathaniel, I created a PR with keylog and message callback patch. The message callback is really useful to investigate handshake and trace messages like close alert. I decided against making the key log feature a callback and rather make it a filename

[issue34271] Please support logging of SSL master secret by env variable SSLKEYLOGFILE

Change by Christian Heimes : -- keywords: +patch pull_requests: +9369 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue34271] Please support logging of SSL master secret by env variable SSLKEYLOGFILE

Johannes Frank added the comment: Hi Christian I would be willing to give this a try, could you publish or send me that more elaborate code? Thanks Johannes On Wed, 26 Sep 2018 at 09:25, Christian Heimes wrote: > > Christian Heimes added the comment: > > Here is a horribly hacky and simple

[issue34271] Please support logging of SSL master secret by env variable SSLKEYLOGFILE

Christian Heimes added the comment: Here is a horribly hacky and simple implementation. I have a more elaborate implementation that does correct locking and has no global state. static BIO *bio_keylog = NULL; static void keylog_callback(const SSL *ssl, const char *line) {

[issue34271] Please support logging of SSL master secret by env variable SSLKEYLOGFILE

Christian Heimes added the comment: Cory contributed a high level API for OpenSSL 1.1.1, https://www.openssl.org/docs/man1.1.1/man3/SSL_CTX_set_keylog_callback.html I already have a patch somewhere on my disk. The patch is trivial if we ignore OpenSSL < 1.1.1. --

[issue34271] Please support logging of SSL master secret by env variable SSLKEYLOGFILE

Nathaniel Smith added the comment: I didn't know this, but apparently the SSLKEYLOGFILE envvar is a de-facto standard: chrome, firefox, and libcurl all check for this envvar, and if found they log TLS secrets to the file in a specific format. Reports of projects supporting this: -

[issue34271] Please support logging of SSL master secret by env variable SSLKEYLOGFILE

Change by Ionut Turturica : -- nosy: +jonozzz ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34271] Please support logging of SSL master secret by env variable SSLKEYLOGFILE

Change by Chih-Hsuan Yen : -- nosy: +yan12125 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34271] Please support logging of SSL master secret by env variable SSLKEYLOGFILE

Change by Johannes Frank : -- title: Please support logging of SSL master secret by env variable SSLKEYLOGFILe -> Please support logging of SSL master secret by env variable SSLKEYLOGFILE ___ Python tracker

[issue34271] Please support logging of SSL master secret by env variable SSLKEYLOGFILe

New submission from Johannes Frank : As discussed on the EuroPython 2018 it would be a great improvement if the python SSL module would respect the SSLKEYLOGFILE environment variable to log the master secret and the client random for packet trace decryption. The pycurl module compiled