[issue34573] Simplify __reduce__() of set and dict iterators.

STINNER Victor added the comment: Thanks Sergey Fedoseev! -- nosy: +vstinner resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue34573] Simplify __reduce__() of set and dict iterators.

Pablo Galindo Salgado added the comment: New changeset 6395844e6adebc12c4eba1fb75c5e7c9c8b89f85 by Pablo Galindo (Sergey Fedoseev) in branch 'master': bpo-34573: Simplify __reduce__() of set and dict iterators. (GH-9050)

[issue34573] Simplify __reduce__() of set and dict iterators.

Serhiy Storchaka added the comment: Perhaps the bug was specific to OrderedDict itrerators. I'll try to write additional tests, and after that I'll merge PR 9050. -- assignee: -> serhiy.storchaka ___ Python tracker

[issue34573] Simplify __reduce__() of set and dict iterators.

Kristján Valur Jónsson added the comment: Interesting, I'll have a look when I'm back from vacation. On Tue, 4 Sep 2018, 07:04 Raymond Hettinger, wrote: > > Raymond Hettinger added the comment: > > Also take a look at the other places that have similar logic. I believe > these all went in

[issue34573] Simplify __reduce__() of set and dict iterators.

Serhiy Storchaka added the comment: Seems there is a bug in the dict iter code, leading to a crash when pickle non-initial items iterator. Would be nice to add tests similar to issue34574, and if the bug will be exposed, fix it. -- nosy: +serhiy.storchaka

[issue34573] Simplify __reduce__() of set and dict iterators.

Raymond Hettinger added the comment: Also take a look at the other places that have similar logic. I believe these all went in at the same time. See commit 31668b8f7a3efc7b17511bb08525b28e8ff5f23a -- nosy: +kristjan.jonsson, rhettinger ___

[issue34573] Simplify __reduce__() of set and dict iterators.

Change by Sergey Fedoseev : -- keywords: +patch pull_requests: +8512 stage: -> patch review ___ Python tracker ___ ___

[issue34573] Simplify __reduce__() of set and dict iterators.

New submission from Sergey Fedoseev : Currently __reduce__() implementation of set and dict iterators saves items to list using next/PyList_Append(), it could be simplified by using PySequence_List(). -- components: Interpreter Core messages: 324550 nosy: sir-sigurd priority: normal