[issue34756] Few changes in sys.breakpointhook()

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue34756] Few changes in sys.breakpointhook()

miss-islington added the comment: New changeset 97d6a56d9d169f35cf2a24d62bf15adfc42fc672 by Miss Islington (bot) in branch '3.7': bpo-35742: Fix test_envar_unimportable in test_builtin. (GH-11561) https://github.com/python/cpython/commit/97d6a56d9d169f35cf2a24d62bf15adfc42fc672 --

[issue34756] Few changes in sys.breakpointhook()

Change by miss-islington : -- pull_requests: +11217, 11218 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34756] Few changes in sys.breakpointhook()

Change by miss-islington : -- pull_requests: +11217, 11218, 11220 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34756] Few changes in sys.breakpointhook()

Change by miss-islington : -- pull_requests: +11217, 11218, 11219, 11220 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34756] Few changes in sys.breakpointhook()

Change by miss-islington : -- pull_requests: +11217 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34756] Few changes in sys.breakpointhook()

Serhiy Storchaka added the comment: New changeset 3607ef43c4a1a24d44f39ff54a77fc0af5bfa09a by Serhiy Storchaka in branch 'master': bpo-35742: Fix test_envar_unimportable in test_builtin. (GH-11561) https://github.com/python/cpython/commit/3607ef43c4a1a24d44f39ff54a77fc0af5bfa09a --

[issue34756] Few changes in sys.breakpointhook()

Change by Serhiy Storchaka : -- pull_requests: +11206 stage: resolved -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue34756] Few changes in sys.breakpointhook()

Change by Serhiy Storchaka : -- pull_requests: +11206, 11207 stage: resolved -> patch review ___ Python tracker ___ ___

[issue34756] Few changes in sys.breakpointhook()

STINNER Victor added the comment: I reopen the issue. This change broke test_builtin: see bpo-35742. I can reproduce the test failure on my Fedoea 29 using: ./python -m test -v test_builtin -m TestBreakpoint -- nosy: +vstinner resolution: fixed -> status: closed -> open

[issue34756] Few changes in sys.breakpointhook()

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue34756] Few changes in sys.breakpointhook()

miss-islington added the comment: New changeset 6d0254bae4d739b487fcaa76705a2d309bce8e75 by Miss Islington (bot) in branch '3.7': bpo-34756: Silence only ImportError and AttributeError in sys.breakpointhook(). (GH-9457)

[issue34756] Few changes in sys.breakpointhook()

Serhiy Storchaka added the comment: The part of the clean up was applied in PR 9519. And since _PyObject_GetBuiltin() was gone, the rest of the clean up no longer applicable. The only part that is left is to make unexpected exceptions no longer silenced. --

[issue34756] Few changes in sys.breakpointhook()

Change by miss-islington : -- pull_requests: +11178, 11179 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34756] Few changes in sys.breakpointhook()

Change by miss-islington : -- pull_requests: +11178, 11179, 11180 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34756] Few changes in sys.breakpointhook()

Change by miss-islington : -- pull_requests: +11178 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34756] Few changes in sys.breakpointhook()

Serhiy Storchaka added the comment: New changeset 6fe9c446f8302553952f63fc6d96be4dfa48ceba by Serhiy Storchaka in branch 'master': bpo-34756: Silence only ImportError and AttributeError in sys.breakpointhook(). (GH-9457)

[issue34756] Few changes in sys.breakpointhook()

Serhiy Storchaka added the comment: I will drop cleanup changes if they don't look good to you. -- ___ Python tracker ___ ___

[issue34756] Few changes in sys.breakpointhook()

Serhiy Storchaka added the comment: This is a pure clean up except the last item which fixes a minor problem. I had wrote this patch a while ago (perhaps before 3.7.0 was released), and now revive my old patches. I think that the general rule is that exceptions shouldn't be ignored blindly,

[issue34756] Few changes in sys.breakpointhook()

Barry A. Warsaw added the comment: Hi Serhiy. I'm curious whether this is a pure clean up or if there are actual problems you're trying to fix. * I'm okay with using _PyObject_GetBuiltin() but it does bother me in general to use too many non-public (and thus undocumented) APIs. It makes

[issue34756] Few changes in sys.breakpointhook()

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +8871 stage: -> patch review ___ Python tracker ___ ___

[issue34756] Few changes in sys.breakpointhook()

New submission from Serhiy Storchaka : The proposed PR makes the following changes in sys.breakpointhook(): * Use _PyObject_GetBuiltin() for getting a builtin. This simplifies the code. * The only effect of using the "from" list is when the imported name is a submodule. But it should be a