[issue34759] Possible regression in ssl module in 3.7.1 and master

2018-09-24 Thread Nathaniel Smith
Nathaniel Smith added the comment: Whoops, yep, I forgot it doesn't auto-close. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue34759] Possible regression in ssl module in 3.7.1 and master

2018-09-24 Thread Ned Deily
Ned Deily added the comment: This issue can now be closed, right? -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34759] Possible regression in ssl module in 3.7.1 and master

2018-09-21 Thread miss-islington
miss-islington added the comment: New changeset 7529754d26f5e744ae25bee56fdc1937bcf08c7e by Miss Islington (bot) (Christian Heimes) in branch '3.6': [3.6] bpo-34759: Fix error handling in ssl 'unwrap()' (GH-9468) (GH-9492)

[issue34759] Possible regression in ssl module in 3.7.1 and master

2018-09-21 Thread miss-islington
miss-islington added the comment: New changeset c00f7037df3607c89323e68db3ab996b7df394de by Miss Islington (bot) in branch '3.7': bpo-34759: Fix error handling in ssl 'unwrap()' (GH-9468) https://github.com/python/cpython/commit/c00f7037df3607c89323e68db3ab996b7df394de --

[issue34759] Possible regression in ssl module in 3.7.1 and master

2018-09-21 Thread Christian Heimes
Change by Christian Heimes : -- pull_requests: +8902 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34759] Possible regression in ssl module in 3.7.1 and master

2018-09-21 Thread miss-islington
miss-islington added the comment: New changeset c0da582b227f311126e278b5553a7fa89c79b054 by Miss Islington (bot) (Nathaniel J. Smith) in branch 'master': bpo-34759: Fix error handling in ssl 'unwrap()' (GH-9468)

[issue34759] Possible regression in ssl module in 3.7.1 and master

2018-09-21 Thread miss-islington
Change by miss-islington : -- pull_requests: +8901 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34759] Possible regression in ssl module in 3.7.1 and master

2018-09-21 Thread Christian Heimes
Christian Heimes added the comment: Good catch, Nathaniel. I was about to ask for a reproducer test, but then I saw that you have added one already. Fantastic! -- ___ Python tracker

[issue34759] Possible regression in ssl module in 3.7.1 and master

2018-09-21 Thread Nathaniel Smith
Nathaniel Smith added the comment: PR posted. Also seems to affect 3.6, so adding that to the tags. -- keywords: +3.6regression versions: +Python 3.6 ___ Python tracker ___

[issue34759] Possible regression in ssl module in 3.7.1 and master

2018-09-20 Thread Nathaniel Smith
Change by Nathaniel Smith : -- keywords: +patch pull_requests: +8881 stage: -> patch review ___ Python tracker ___ ___

[issue34759] Possible regression in ssl module in 3.7.1 and master

2018-09-20 Thread Nathaniel Smith
Nathaniel Smith added the comment: Oh, here it is: https://github.com/python/cpython/commit/1229664f30dd5fd4da32174a19258f8312464d45#diff-e1cc5bf74055e388cda128367a814c8fR2587 -if (err < 0) { +if (err.ssl < 0) { Before in this function, 'err' was the return code from SSL_shutdown,

[issue34759] Possible regression in ssl module in 3.7.1 and master

2018-09-20 Thread Ned Deily
Ned Deily added the comment: Steve? Christian? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34759] Possible regression in ssl module in 3.7.1 and master

2018-09-20 Thread Nathaniel Smith
Nathaniel Smith added the comment: The ssl module's unwrap() method is intended to do a clean shutdown of TLS encryption on a socket (or memory BIO or whatever). The idea is that it sends a "close notify" frame (i.e., tells the peer that we're shutting down), and then it waits for the peer

[issue34759] Possible regression in ssl module in 3.7.1 and master

2018-09-20 Thread Ned Deily
Ned Deily added the comment: Thanks for the heads-up! If you become convinced it's a post-3.7.0 regression that would affect 3.7.1, please change the priority to "release blocker". -- ___ Python tracker

[issue34759] Possible regression in ssl module in 3.7.1 and master

2018-09-20 Thread Nathaniel Smith
Nathaniel Smith added the comment: The test doesn't involve any threads, so it does seem strange that this PR changed its behavior. I haven't checked against master carefully, but the original observation was that our Travis "3.7-dev" and "3.8-dev" tests started failing in the same way

[issue34759] Possible regression in ssl module in 3.7.1 and master

2018-09-20 Thread Steve Dower
Steve Dower added the comment: It should just be gathering SSL error codes before acquiring the GIL, which could switch thread and then get the wrong code. Of course, it's possible it is in the backport. How easily can you test against master? (I'm AFK, so can't easily do anything right

[issue34759] Possible regression in ssl module in 3.7.1 and master

2018-09-20 Thread Nathaniel Smith
Nathaniel Smith added the comment: Git bisect says: 1229664f30dd5fd4da32174a19258f8312464d45 is the first bad commit commit 1229664f30dd5fd4da32174a19258f8312464d45 Author: Miss Islington (bot) <31488909+miss-isling...@users.noreply.github.com> Date: Mon Sep 17 12:12:13 2018 -0700

[issue34759] Possible regression in ssl module in 3.7.1 and master

2018-09-20 Thread Nathaniel Smith
Nathaniel Smith added the comment: (And Christian, if you know of any risky-sounding recent changes in SSLObject.unwrap, lmk :-)) -- ___ Python tracker ___

[issue34759] Possible regression in ssl module in 3.7.1 and master

2018-09-20 Thread Nathaniel Smith
New submission from Nathaniel Smith : Hey Ned, we just noticed that since a few days ago the trio testsuite is failing on 3.7-dev (but not 3.7.0), in a test checking an obscure feature in the ssl module: https://travis-ci.org/python-trio/trio/builds/431291929 And I just reproduced the issue