[issue34872] investigate task/future cancellation in asynciomodule.c

Ned Deily added the comment: Both 3.7.1rc2 and 3.6.7rc2 -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34872] investigate task/future cancellation in asynciomodule.c

Yury Selivanov added the comment: Closing it now, Ned, thanks! I assume it will make it into 3.7.1rc2, right? -- priority: release blocker -> normal resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue34872] investigate task/future cancellation in asynciomodule.c

Ned Deily added the comment: Is there any reason this issue needs to remain open? Or can we at least remove the "release blocker" priority? -- ___ Python tracker ___

[issue34872] investigate task/future cancellation in asynciomodule.c

Serhiy Storchaka added the comment: New changeset dd0670f12b159eff5336d6011f046e1ccac495e1 by Serhiy Storchaka (Miss Islington (bot)) in branch '3.6': Fix a compiler warning added in bpo-34872. (GH-9722). (GH-9726) (GH-9728)

[issue34872] investigate task/future cancellation in asynciomodule.c

Serhiy Storchaka added the comment: New changeset d9212200fe8ddb55d73b8231869cfbb32635ba92 by Serhiy Storchaka in branch '3.7': [3.7] Fix a compiler warning added in bpo-34872. (GH-9722). (GH-9726) https://github.com/python/cpython/commit/d9212200fe8ddb55d73b8231869cfbb32635ba92 --

[issue34872] investigate task/future cancellation in asynciomodule.c

Change by miss-islington : -- pull_requests: +9113 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34872] investigate task/future cancellation in asynciomodule.c

Change by Serhiy Storchaka : -- pull_requests: +9111 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34872] investigate task/future cancellation in asynciomodule.c

Serhiy Storchaka added the comment: New changeset addf8afb43af58b9bf56a0ecfd0f316dd60ac0c3 by Serhiy Storchaka in branch 'master': Fix a compiler warning added in bpo-34872. (GH-9722) https://github.com/python/cpython/commit/addf8afb43af58b9bf56a0ecfd0f316dd60ac0c3 --

[issue34872] investigate task/future cancellation in asynciomodule.c

Change by Serhiy Storchaka : -- pull_requests: +9107 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34872] investigate task/future cancellation in asynciomodule.c

Serhiy Storchaka added the comment: Seems this change introduced a compiler warning. /home/serhiy/py/cpython3.7/Modules/_asynciomodule.c: In function ‘task_step_impl’: /home/serhiy/py/cpython3.7/Modules/_asynciomodule.c:2666:44: warning: passing argument 1 of ‘_PyObject_CallMethodId’ from

[issue34872] investigate task/future cancellation in asynciomodule.c

Yury Selivanov added the comment: > What's your assessment of the risk of option 2? Let's not rush it in without testing, for sure. Having 3.7.1rc2 would be great, but really up to you. -- ___ Python tracker

[issue34872] investigate task/future cancellation in asynciomodule.c

Ned Deily added the comment: Prior to this, there were no plans to have a 3.7.1rc2. We have three options: 1. do a 3.7.1rc2 with this and possibly a few other cherry-picked changes 2. just cherry-pick this fix into 3.7.1 final 3. wait for 3.7.2 (in one to three months) What's your

[issue34872] investigate task/future cancellation in asynciomodule.c

Yury Selivanov added the comment: Ned, elevating this to "release blocker", see https://bugs.python.org/msg326928 Feel free to close this issue. -- priority: normal -> release blocker ___ Python tracker

[issue34872] investigate task/future cancellation in asynciomodule.c

miss-islington added the comment: New changeset a67bd53d3f80ac9c518b5426aa35459bd373b2b3 by Miss Islington (bot) (Elvis Pranskevichus) in branch '3.7': [3.7] bpo-34872: Fix self-cancellation in C implementation of asyncio.Task (GH-9679) (GH-9691)

[issue34872] investigate task/future cancellation in asynciomodule.c

miss-islington added the comment: New changeset 166773df0ce6c852130f524029fa2e62b37b89cb by Miss Islington (bot) (Elvis Pranskevichus) in branch '3.6': [3.6] bpo-34872: Fix self-cancellation in C implementation of asyncio.Task (GH-9679) (GH-9690)

[issue34872] investigate task/future cancellation in asynciomodule.c

Change by Elvis Pranskevichus : -- pull_requests: +9078 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34872] investigate task/future cancellation in asynciomodule.c

Change by Elvis Pranskevichus : -- pull_requests: +9077 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34872] investigate task/future cancellation in asynciomodule.c

Yury Selivanov added the comment: New changeset 0c797a6aca1c293e530e18c5e9fa02c670a9a4ed by Yury Selivanov (Elvis Pranskevichus) in branch 'master': bpo-34872: Fix self-cancellation in C implementation of asyncio.Task (GH-9679)

[issue34872] investigate task/future cancellation in asynciomodule.c

Yury Selivanov added the comment: Ned, will we have 3.7.1rc2? If so, would it be possible to include the fix for this one? -- nosy: +ned.deily ___ Python tracker ___

[issue34872] investigate task/future cancellation in asynciomodule.c

Change by Elvis Pranskevichus : -- keywords: +patch pull_requests: +9068 stage: -> patch review ___ Python tracker ___ ___

[issue34872] investigate task/future cancellation in asynciomodule.c

Change by Vladimir Matveev : -- nosy: +v2m ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34872] investigate task/future cancellation in asynciomodule.c

Yury Selivanov added the comment: Elvis, please take a look at this. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34872] investigate task/future cancellation in asynciomodule.c

New submission from Yury Selivanov : Vladimir Matveev has discovered that C and Python implementation of asyncio.Task diverge: * asynciomodule.c: https://github.com/python/cpython/blob/9012a0fb4c4ec1afef9efb9fdb0964554ea17983/Modules/_asynciomodule.c#L2716 * tasks.py: