[issue34909] StrEnum subclasses cannot be created

Ethan Furman added the comment: Thank you both. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34909] StrEnum subclasses cannot be created

Ned Deily added the comment: NEWS entry added for 3.7.1 and master. Closing again. -- priority: deferred blocker -> stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue34909] StrEnum subclasses cannot be created

Ned Deily added the comment: New changeset 03ca8b5f23e9fe122bb0ca80397a2481c10cd7c4 by Ned Deily in branch '3.7': bpo-34909: NEWS entry. https://github.com/python/cpython/commit/03ca8b5f23e9fe122bb0ca80397a2481c10cd7c4 -- ___ Python tracker

[issue34909] StrEnum subclasses cannot be created

Stéphane Wirtel added the comment: Hi Ned, good news (I hope the best for the wife of Ethan) -- ___ Python tracker ___ ___

[issue34909] StrEnum subclasses cannot be created

Ned Deily added the comment: Thanks, Stéphane, but I’ve already taken care of it. I’ll be closing the issue shortly. (And ditto on the best wishes, Ethan.) -- ___ Python tracker

[issue34909] StrEnum subclasses cannot be created

Stéphane Wirtel added the comment: Hi Ethan and Ned, I am not fluent with the code of the Enum, but maybe I could work on this issue and try to finish it. Ethan, I am really sorry for your wife, take care of her. -- ___ Python tracker

[issue34909] StrEnum subclasses cannot be created

Ned Deily added the comment: New changeset 8c9fd9c91ba748df68a11e3bf216fa158314c9b5 by Ned Deily in branch 'master': bpo-34909: NEWS entry (GH-9995) https://github.com/python/cpython/commit/8c9fd9c91ba748df68a11e3bf216fa158314c9b5 -- ___ Python

[issue34909] StrEnum subclasses cannot be created

Change by Ned Deily : -- pull_requests: +9337 stage: commit review -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue34909] StrEnum subclasses cannot be created

Ethan Furman added the comment: Okay, the patch is here: https://github.com/ethanfurman/cpython/tree/enum_news_entry But I managed to screw something up, and my wife just got hit by a car so this is now a really low priority. Ned, if you could grab the relevant pieces from the wreck that

[issue34909] StrEnum subclasses cannot be created

Ethan Furman added the comment: Working on getting that news entry. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34909] StrEnum subclasses cannot be created

Ned Deily added the comment: My concern was that it seemed like at least one user had run into this while running 3.7.1rc1 (?), if I understood your comment; if so, I think we should mention in the changelog that the problem was fixed in rc2. In any case, the state of the code for any

[issue34909] StrEnum subclasses cannot be created

Ethan Furman added the comment: On 10/12/2018 09:52 PM, Ned Deily wrote: > Can you please merge a NEWS item for this issue using blurb since it > is a user-visible problem? I'll cherry-pick it into the 3.7.1 final. I don't believe the problem exists in 3.7.0 -- but I also don't know how

[issue34909] StrEnum subclasses cannot be created

Ned Deily added the comment: Can you please merge a NEWS item for this issue using blurb since it is a user-visible problem? I'll cherry-pick it into the 3.7.1 final. -- priority: release blocker -> deferred blocker stage: resolved -> commit review status: closed -> open

[issue34909] StrEnum subclasses cannot be created

Ethan Furman added the comment: Stéphane, thanks for the tip about bisect! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue34909] StrEnum subclasses cannot be created

Stéphane Wirtel added the comment: Ethan, I think you have fixed the issue, could you close this issue? Thank you -- ___ Python tracker ___

[issue34909] StrEnum subclasses cannot be created

Ethan Furman added the comment: New changeset 453b3b0e87cb16345c276b9064a4480ce3794a74 by Ethan Furman (Miss Islington (bot)) in branch '3.7': bpo-34909: keep searching mixins until base class is found (GH-9737) (GH-9738)

[issue34909] StrEnum subclasses cannot be created

Change by miss-islington : -- pull_requests: +9125 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34909] StrEnum subclasses cannot be created

Ethan Furman added the comment: New changeset cd45385ffad8910293e5659cfe7ab036e70613b7 by Ethan Furman in branch 'master': bpo-34909: keep searching mixins until base class is found (GH-9737) https://github.com/python/cpython/commit/cd45385ffad8910293e5659cfe7ab036e70613b7 --

[issue34909] StrEnum subclasses cannot be created

Change by Ethan Furman : -- keywords: +patch pull_requests: +9124 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue34909] StrEnum subclasses cannot be created

Stéphane Wirtel added the comment: git bisect start # bad: [1596fea0a329e1f5e4cce0135724881ca5f1d341] bpo-34899: Fix a possible assertion failure due to int_from_bytes_impl() (GH-9705) git bisect bad 1596fea0a329e1f5e4cce0135724881ca5f1d341 # good: [84b0129b5e0a0e22aad22ae8db2e3833a228aa57]

[issue34909] StrEnum subclasses cannot be created

Stéphane Wirtel added the comment: Hi Ethan, the issue appears with your patch 0c076caaa82a9c6596e1fe1dbe6384d53f30a1a3 is the first bad commit commit 0c076caaa82a9c6596e1fe1dbe6384d53f30a1a3 Author: Ethan Furman Date: Fri Sep 21 22:26:32 2018 -0700 [3.7] bpo-29577: Enum: mixin

[issue34909] StrEnum subclasses cannot be created

Ned Deily added the comment: > I just finished the fix and am currently running the tests locally. Great. Thanks! > Is it okay to have the PR directly against 3.7 instead of doing 3.8 first and > backporting? If you want but it's probably easier to do it the normal way and let the bot do

[issue34909] StrEnum subclasses cannot be created

Ethan Furman added the comment: It really is. I got a message from Michal Arbet from OpenStack about it. I just finished the fix and am currently running the tests locally. Is it okay to have the PR directly against 3.7 instead of doing 3.8 first and backporting? -- stage: test

[issue34909] StrEnum subclasses cannot be created

Ned Deily added the comment: Ethan, do you an ETA of a fix for this? 3.7.1 final is scheduled for fewer than 24 hours from now but if it's truly a release blocker I will hold for a fix and probably do a rc2 instead. -- ___ Python tracker

[issue34909] StrEnum subclasses cannot be created

New submission from Ethan Furman : from enum import Enum, unique class StrEnum(str, Enum): def __new__(cls, *args, **kwargs): for a in args: if not isinstance(a, str): raise TypeError("Enumeration '%s' (%s) is not" " a