[issue34970] Protect tasks weak set manipulation in asyncio.all_tasks()

Ned Deily added the comment: Released in 3.7.1 -- priority: release blocker -> resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue34970] Protect tasks weak set manipulation in asyncio.all_tasks()

Ned Deily added the comment: New changeset 60c663c0f76c790afbed4d673c3ce264dd226b8c by Ned Deily (Miss Islington (bot)) in branch '3.7': bpo-34970: Protect tasks weak set manipulation in asyncio.all_tasks() (GH-9837) (GH-9849)

[issue34970] Protect tasks weak set manipulation in asyncio.all_tasks()

Andrew Svetlov added the comment: Cool! Thanks, Ned -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34970] Protect tasks weak set manipulation in asyncio.all_tasks()

Ned Deily added the comment: Thanks, Andrew and Yury! Just leave the issue open as a "release blocker" for now and I will take care of it for 3.7.1 final. -- ___ Python tracker

[issue34970] Protect tasks weak set manipulation in asyncio.all_tasks()

Andrew Svetlov added the comment: Ned, the fix has landed on both master and 3.7 Your turn, please. -- ___ Python tracker ___ ___

[issue34970] Protect tasks weak set manipulation in asyncio.all_tasks()

Andrew Svetlov added the comment: New changeset 5dbb1b7df1d9ecaa6b5344028cd1777502cf5c73 by Andrew Svetlov (Miss Islington (bot)) in branch '3.7': bpo-34970: Protect tasks weak set manipulation in asyncio.all_tasks() (GH-9837) (GH-9849)

[issue34970] Protect tasks weak set manipulation in asyncio.all_tasks()

miss-islington added the comment: New changeset 97cf0828727ac2a269c89c5aa09570a69a22c83c by Miss Islington (bot) (Andrew Svetlov) in branch 'master': bpo-34970: Protect tasks weak set manipulation in asyncio.all_tasks() (GH-9837)

[issue34970] Protect tasks weak set manipulation in asyncio.all_tasks()

Change by miss-islington : -- pull_requests: +9219 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34970] Protect tasks weak set manipulation in asyncio.all_tasks()

Yury Selivanov added the comment: >> we could consider risking cherry-picking it to 3.7.1 final. Sound OK? > Let's wait for Yuri opinion. I agree it's a pretty serious bug; basically a time bomb that can crash a perfectly fine asyncio application. The PR itself seems to be safe to

[issue34970] Protect tasks weak set manipulation in asyncio.all_tasks()

Andrew Svetlov added the comment: Let's wait for Yuri opinion. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34970] Protect tasks weak set manipulation in asyncio.all_tasks()

Ned Deily added the comment: 3.7.1rc2 is about to be released so to add this would require retagging and remanufacturing release bits. If the chances of it happening are "very low", I would prefer to not further delay rc2. If you and Yury agree that the risk is low and the benefit is

[issue34970] Protect tasks weak set manipulation in asyncio.all_tasks()

Andrew Svetlov added the comment: Ned, would be nice to have this trivial bugfix in 3.7.1. The problem happens if wakes up on weakset iteration. The chance is very low, it leads to a flaky scary bug. -- stage: patch review -> ___ Python tracker

[issue34970] Protect tasks weak set manipulation in asyncio.all_tasks()

Change by Andrew Svetlov : -- keywords: +patch pull_requests: +9211 stage: -> patch review ___ Python tracker ___ ___

[issue34970] Protect tasks weak set manipulation in asyncio.all_tasks()

Andrew Svetlov added the comment: The issue is hard to reproduce, the problem happens on an implicit garbage collector run during iteration over `_all_tasks` weakset. -- ___ Python tracker

[issue34970] Protect tasks weak set manipulation in asyncio.all_tasks()

Change by Andrew Svetlov : -- title: Protect all_tasks manipulation in asyncio.all_tasks() -> Protect tasks weak set manipulation in asyncio.all_tasks() ___ Python tracker